Skip to contentSkip to conversation

Musicpal: Fix wm8750 I2C address

PATCH Applied Jan Kiszka 2 participants 3 messages Jan 23, 2010 – Jan 26, 2010

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 Musicpal: Fix wm8750 I2C address

Commit b3a219883e uncovered that we attached the Wolfson with an I2C address shifted left by one. Fixing this makes sound work again for the Musicpal.

---
 hw/musicpal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
hw/musicpal.c +1 -1
index 4a33e28..e424a7d 100644
@@ -67,7 +67,7 @@
 #define MP_AUDIO_IRQ            30
 
 /* Wolfson 8750 I2C address */
-#define MP_WM_ADDR              0x34
+#define MP_WM_ADDR              0x1A
 
 /* Ethernet register offsets */
 #define MP_ETH_SMIR             0x010
author
#1 lore raw
Quoted 3 lines · Jan Kiszka

Commit b3a219883e uncovered that we attached the Wolfson with an I2C address shifted left by one. Fixing this makes sound work again for the Musicpal.

Please merge into stable as well so that 0.12.3 will have a working Musicpal again.

Thanks,
Jan

Quoted 20 lines
---
 hw/musicpal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
hw/musicpal.c +1 -1
index 4a33e28..e424a7d 100644
@@ -67,7 +67,7 @@
 #define MP_AUDIO_IRQ            30
 
 /* Wolfson 8750 I2C address */
-#define MP_WM_ADDR              0x34
+#define MP_WM_ADDR              0x1A
 
 /* Ethernet register offsets */
 #define MP_ETH_SMIR             0x010
#2 lore raw
In reply to Jan Kiszka
Quoted 6 lines · Jan Kiszka

Commit b3a219883e uncovered that we attached the Wolfson with an I2C address shifted left by one. Fixing this makes sound work again for the Musicpal.

Applied to stable. Thanks.

Regards,

Anthony Liguori

Quoted 19 lines
---
  hw/musicpal.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
hw/musicpal.c +1 -1
index 4a33e28..e424a7d 100644
@@ -67,7 +67,7 @@
  #define MP_AUDIO_IRQ            30
 
  /* Wolfson 8750 I2C address */
-#define MP_WM_ADDR              0x34
+#define MP_WM_ADDR              0x1A
 
  /* Ethernet register offsets */
  #define MP_ETH_SMIR             0x010