Problems with cx18
Hi Devin/Andy/Jean,
The cx88-alsa and cx18-drivers are broken: the driver depend of request_modules that doesn't exist when !CONFIG_MODULES, and has some wrong __init annotations.
The sq905c has a warning.
I'm compiling it with:
make ARCH=i386 allmodconfig drivers/media/|grep -v "^ CC" |grep -v "^ LD"
Those are the errors found:
drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_init is wrong.
WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_init is wrong.
drivers/media/video/gspca/sq905c.c: In function ‘sd_config’:drivers/media/video/gspca/sq905c.c:207: warning: unused variable ‘i’
WARNING: drivers/media/video/built-in.o(.text+0x28d24e): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_init is wrong.
WARNING: drivers/media/built-in.o(.text+0x2d2a2a): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_init is wrong.
Please fix.
Cheers,
Mauro.
Quoted 33 lines · Mauro Carvalho Chehab
Hi Devin/Andy/Jean,
The cx88-alsa and cx18-drivers are broken: the driver depend of
request_modulesthat doesn't exist when !CONFIG_MODULES, and has some wrong__initannotations.The sq905c has a warning.
I'm compiling it with:
make ARCH=i386 allmodconfig drivers/media/|grep -v "^ CC" |grep -v "^ LD"Those are the errors found:
drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the functioncx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function
cx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.
drivers/media/video/gspca/sq905c.c: In function ‘sd_config’:drivers/media/video/gspca/sq905c.c:207: warning: unused variable ‘i’
WARNING: drivers/media/video/built-in.o(.text+0x28d24e): Section mismatch in reference from the functioncx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.
Quoted 5 lines
WARNING: drivers/media/built-in.o(.text+0x2d2a2a): Section mismatch in reference from the function
cx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.
This looks like breakage I probably introduced with the cx18 alsa support. I will dig into this tonight.
Devin
Signature · 2 lines
Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com
Quoted 1 line · Mauro Carvalho Chehab
Hi Devin/Andy/Jean,
<snip>
Quoted 1 line
The sq905c has a warning.
<snip>
Quoted 2 lines
drivers/media/video/gspca/sq905c.c: In function ?sd_config?:drivers/media/video/gspca/sq905c.c:207: warning: unused variable ?i?
<snip>
Quoted 4 lines
Please fix.
Cheers,
Mauro.
This one has been fixed, already. A more recent version of sq905c.c is in the pipeline somewhere.
Theodore Kilgore
Quoted 19 lines · Theodore Kilgore
Quoted 1 line · Mauro Carvalho Chehab
Hi Devin/Andy/Jean,
<snip>
Quoted 1 line
The sq905c has a warning.
<snip>
Quoted 2 lines
drivers/media/video/gspca/sq905c.c: In function ?sd_config?:drivers/media/video/gspca/sq905c.c:207: warning: unused variable ?i?<snip>
Quoted 2 lines
Please fix.
Quoted 7 lines
Quoted 2 lines
Cheers,
Mauro.This one has been fixed, already. A more recent version of
sq905c.cis in the pipeline somewhere.Theodore Kilgore
Not intending to hijack this thread, but maybe it would be a good idea for Hans's nightly rig to do a build with module support disabled on at least one platform. I'm not saying we should do it on all platforms, but if we at least run it on x86 then we would spot this class of issue earlier.
Devin
Signature · 2 lines
Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com
Quoted 35 lines · Devin Heitmueller
Quoted 33 lines · Mauro Carvalho Chehab
Hi Devin/Andy/Jean,
The cx88-alsa and cx18-drivers are broken: the driver depend of
request_modulesthat doesn't exist when !CONFIG_MODULES, and has some wrong__initannotations.The sq905c has a warning.
I'm compiling it with:
make ARCH=i386 allmodconfig drivers/media/|grep -v "^ CC" |grep -v "^ LD"Those are the errors found:
drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the functioncx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function
cx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.
drivers/media/video/gspca/sq905c.c: In function ‘sd_config’:drivers/media/video/gspca/sq905c.c:207: warning: unused variable ‘i’
WARNING: drivers/media/video/built-in.o(.text+0x28d24e): Section mismatch in reference from the functioncx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.
Quoted 8 lines
Quoted 5 lines
WARNING: drivers/media/built-in.o(.text+0x2d2a2a): Section mismatch in reference from the function
cx18_alsa_load()to the function .init.text:snd_cx18_init() The functioncx18_alsa_load()references
the function__initsnd_cx18_init().
This is often becausecx18_alsa_loadlacks a__init
annotation or the annotation ofsnd_cx18_initis wrong.This looks like breakage I probably introduced with the cx18 alsa support. I will dig into this tonight.
Devin,
If it's easiest to not treat the cx18-alsa stuff as a module and just always have the cx18 ALSA device interface available, that's OK by me. Your call.
Regards,
Andy
Quoted 2 lines
Devin