PATCH: silent subscription
Got bitten by this one, too! The documentation for mlmmj-sub has an interesting use of the word 'silent'. I've changed the documentation and added an option to actually allow silent subscription even when moderation is turned on.
I also added a tunable to disable the message to the requester. Mail moderation doesn't spam the requester each time they send a mail, so why should subscription requests? (Though notifying posters that their mail is awaiting moderation is a feature I will need, too, and will send a patch shortly for that as it should be fairly straightforward.)
Patch attached. Could it be included in mlmmj?
Cheers,
Ben.
TUNABLES +6 -0
@@ -158,6 +158,12 @@ when it was rejected due to an access rule (see 'access') or whether it's a subscribers only posting list (see 'subonlypost'). + ��� nosubmodmails (boolean) + + This switch turns off whether mlmmj sends out notification about + subscription being moderated to the person requesting subscription + (see 'submod'). + ��� smtpport (normal) In this file a port other than port 25 for connecting to the relayhost
contrib/web/perl-admin/conf/tunables.pl +6 -0
@@ -156,6 +156,12 @@ "This switch turns off whether mlmmj sends out notification about postings ". "being rejected due to a subscribers only posting list (see 'subonlypost')."); +mlmmj_boolean("nosubmodmails", + "No subscription moderated mails", + "This switch turns off whether mlmmj sends out notification about ". + "subscription being moderated to the person requesting subscription". + "(see 'submod')."); + mlmmj_boolean("nodigesttext", "No digest text summary", "This switch turns off whether digest mails will have a text part with a thread ".
contrib/web/php-admin/conf/tunables.pl +6 -0
@@ -156,6 +156,12 @@ "This switch turns off whether mlmmj sends out notification about postings ". "being rejected due to a subscribers only posting list (see 'subonlypost')."); +mlmmj_boolean("nosubmodmails", + "No subscription moderated mails", + "This switch turns off whether mlmmj sends out notification about ". + "subscription being moderated to the person requesting subscription". + "(see 'submod')."); + mlmmj_boolean("nodigesttext", "No digest text summary", "This switch turns off whether digest mails will have a text part with a thread ".
man/mlmmj-sub.1 +10 -5
@@ -1,18 +1,20 @@ -.TH mlmmj-sub "1" "September 2004" mlmmj-sub +.TH mlmmj-sub "1" "January 2010" mlmmj-sub .SH NAME mlmmj-sub \- subscribe address to a mailinglist run by mlmmj .SH SYNOPSIS .B mlmmj-sub \fI-L /path/to/list -a [email protected] \fR[\fI-c\fR | \fI-C\fR] \fR[\fI-d\fR | \fI-n\fR] -[\fI-h\fR] [\fI-U\fR] [\fI-V\fR] +[\fI-f\fR] [\fI-h\fR] [\fI-U\fR] [\fI-V\fR] .HP \fB\-a\fR: Email address to subscribe .HP \fB\-c\fR: Send welcome mail .HP +\fB\-C\fR: Request mail confirmation +.HP \fB\-d\fR: Subscribe to digest version of the list .HP -\fB\-C\fR: Request mail confirmation +\fB\-f\fR: Force subscription (do not moderate) .HP \fB\-h\fR: This help .HP
@@ -44,8 +46,11 @@ Normally a mail is sent to the subscriber if the address is already subscribed to the list. If the \fB\-s\fR switch is used such a mail will not be sent. -When neither \fB\-c\fR nor \fB\-C\fR are specified, subscription silently -happens. +Subscription may be moderated (if <listdir>/control/submod exists) unless the +\fB\-f\fR switch is given. + +To ensure a silent subscription, use \fB\-f\fR, but neither \fB\-c\fR +nor \fB\-C\fR. .SH "SEE ALSO" mlmmj-unsub(1), setuid(2) .SH AUTHORS
src/mlmmj-sub.c +17 -6
@@ -172,13 +172,19 @@log_error (LOG_ARGS ,"execl() of '%s' failed" , mlmmjsend);exit (EXIT_FAILURE ); } - +myfree (to);myfree (replyto);myfree (moderators);/* send mail to requester that the list is submod'ed */ +if (statctrl (listdir,"nosubmodmails" )) { +myfree (listname); +myfree (listfqdn); +exit (EXIT_SUCCESS ); + } + from =concatstr (4 , listname, listdelim,"bounces-help@" , listfqdn); queuefilename =prepstdreply (listdir,"submod-requester" ,"$listowner$" , subaddr,NULL ,0 ,NULL ,NULL ,NULL );
@@ -429,11 +435,12 @@static void print_help (const char *prg) {printf ("Usage: %s -L /path/to/list [-a [email protected] | -m str]" -"[-c] [-C] [-h]\n [-L] [-d | -n] [-s] [-U] [-V]\n" +"[-c] [-C] [-f]\n [-h] [-L] [-d | -n] [-s] [-U] [-V]\n" " -a: Email address to subscribe \n" " -c: Send welcome mail\n" " -C: Request mail confirmation\n" " -d: Subscribe to digest of list\n" +" -f: Force subscription (do not moderate)\n" " -h: This help\n" " -L: Full path to list directory\n" " -m: moderation string\n"
@@ -441,8 +448,8 @@printf (" -s: Don't send a mail to subscriber if already subscribed\n" " -U: Don't switch to the user id of the listdir owner\n" " -V: Print version\n" -"When no options are specified, subscription silently " -"happens\n" ); +"When no options are specified, subscription may be " +"moderated;\nto ensure a silent subscription, use -f\n" );exit (EXIT_SUCCESS ); }
@@ -487,6 +494,7 @@int subconfirm =0 , confirmsub =0 , opt, subfilefd, lock, notifysub;int changeuid =1 , status, digest =0 , nomail =0 , i =0 , submod =0 ;int groupwritable =0 , sublock, sublockfd, nogensubscribed =0 , subbed; +int force =0 ;size_t len;struct stat st;pid_t pid, childpid;
@@ -501,7 +509,7 @@ mlmmjsend =concatstr (2 , bindir,"/mlmmj-send" );myfree (bindir); -while ((opt =getopt (argc, argv,"hcCdm:nsVUL:a:" )) !=-1 ) { +while ((opt =getopt (argc, argv,"hcCdfm:nsVUL:a:" )) !=-1 ) {switch (opt) {case 'a' : address = optarg;
@@ -515,6 +523,9 @@case 'd' : digest =1 ;break ; +case 'f' : + force =1 ; +break ;case 'h' :print_help (argv[0 ]);break ;
@@ -670,7 +681,7 @@ subbed =is_subbed_in (subddirname, address); listdelim =getlistdelim (listdir);if (modstr ==NULL ) - submod =statctrl (listdir,"submod" ); + submod = !force &&statctrl (listdir,"submod" );if (subbed) {if (subconfirm) {
This is a better version of the patch. As I was implementing the notification of moderation, I realised this forking behaviour was far from ideal and could be better. Now it does the forking similarly to how it is done for confirming subscriptions while notifying the list owner. It, too, makes sending the notification the lower priority, with the exit status representing whether it succeeded in sending the mail to moderators.
The comments below still apply.
Quoted 11 lines · Ben Schmidt
Got bitten by this one, too! The documentation for mlmmj-sub has an interesting use of the word 'silent'. I've changed the documentation and added an option to actually allow silent subscription even when moderation is turned on.
I also added a tunable to disable the message to the requester. Mail moderation doesn't spam the requester each time they send a mail, so why should subscription requests? (Though notifying posters that their mail is awaiting moderation is a feature I will need, too, and will send a patch shortly for that as it should be fairly straightforward.)
Quoted 5 lines
Patch attached. Could it be included in mlmmj?
Cheers,
Ben.
TUNABLES +6 -0
@@ -158,6 +158,12 @@ when it was rejected due to an access rule (see 'access') or whether it's a subscribers only posting list (see 'subonlypost'). + ��� nosubmodmails (boolean) + + This switch turns off whether mlmmj sends out notification about + subscription being moderated to the person requesting subscription + (see 'submod'). + ��� smtpport (normal) In this file a port other than port 25 for connecting to the relayhost
contrib/web/perl-admin/conf/tunables.pl +6 -0
@@ -156,6 +156,12 @@ "This switch turns off whether mlmmj sends out notification about postings ". "being rejected due to a subscribers only posting list (see 'subonlypost')."); +mlmmj_boolean("nosubmodmails", + "No subscription moderated mails", + "This switch turns off whether mlmmj sends out notification about ". + "subscription being moderated to the person requesting subscription". + "(see 'submod')."); + mlmmj_boolean("nodigesttext", "No digest text summary", "This switch turns off whether digest mails will have a text part with a thread ".
contrib/web/php-admin/conf/tunables.pl +6 -0
@@ -156,6 +156,12 @@ "This switch turns off whether mlmmj sends out notification about postings ". "being rejected due to a subscribers only posting list (see 'subonlypost')."); +mlmmj_boolean("nosubmodmails", + "No subscription moderated mails", + "This switch turns off whether mlmmj sends out notification about ". + "subscription being moderated to the person requesting subscription". + "(see 'submod')."); + mlmmj_boolean("nodigesttext", "No digest text summary", "This switch turns off whether digest mails will have a text part with a thread ".
man/mlmmj-sub.1 +10 -5
@@ -1,18 +1,20 @@ -.TH mlmmj-sub "1" "September 2004" mlmmj-sub +.TH mlmmj-sub "1" "January 2010" mlmmj-sub .SH NAME mlmmj-sub \- subscribe address to a mailinglist run by mlmmj .SH SYNOPSIS .B mlmmj-sub \fI-L /path/to/list -a [email protected] \fR[\fI-c\fR | \fI-C\fR] \fR[\fI-d\fR | \fI-n\fR] -[\fI-h\fR] [\fI-U\fR] [\fI-V\fR] +[\fI-f\fR] [\fI-h\fR] [\fI-U\fR] [\fI-V\fR] .HP \fB\-a\fR: Email address to subscribe .HP \fB\-c\fR: Send welcome mail .HP +\fB\-C\fR: Request mail confirmation +.HP \fB\-d\fR: Subscribe to digest version of the list .HP -\fB\-C\fR: Request mail confirmation +\fB\-f\fR: Force subscription (do not moderate) .HP \fB\-h\fR: This help .HP
@@ -44,8 +46,11 @@ Normally a mail is sent to the subscriber if the address is already subscribed to the list. If the \fB\-s\fR switch is used such a mail will not be sent. -When neither \fB\-c\fR nor \fB\-C\fR are specified, subscription silently -happens. +Subscription may be moderated (if <listdir>/control/submod exists) unless the +\fB\-f\fR switch is given. + +To ensure a silent subscription, use \fB\-f\fR, but neither \fB\-c\fR +nor \fB\-C\fR. .SH "SEE ALSO" mlmmj-unsub(1), setuid(2) .SH AUTHORS
src/mlmmj-sub.c +30 -17
117 lines not on this page · raw message