Skip to contentSkip to conversation

ARM11 MPCore: Adding nop to __delay() doubles the BogoMIPS/lpj

PATCH Dirk Behme 4 participants 4 messages Jan 27, 2010 – Jan 29, 2010 Arm (32-bit)

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

On a 400MHz ARM11 MPCore system (NEC NaviEngine based) with kernel 2.6.32 we found that BogoMIPS/loops per jiffies ~doubles (see below [1]) by adding a nop to __delay():

arch/arm/lib/delay.S +3 -0
@@ -41,6 +41,9 @@ ENTRY(__const_udelay)    @ 0 <= r0 <= 0x
  @ Delay routine
  ENTRY(__delay)
+#if defined(CONFIG_CPU_V6) && defined(CONFIG_SMP)
+        nop
+#endif
          subs    r0, r0, #1
  #if 0
          movls    pc, lr
 

Any ideas what might happen here?

Many thanks and best regards

Dirk

[1] 2.6.32 without and with additional nop in __delay():

====> Clean 2.6.32 without nop in __delay():

...
Calibrating delay loop... 159.74 BogoMIPS (lpj=798720) Mount-cache hash table entries: 512
CPU: Testing write buffer coherency: ok Calibrating local timer... 199.98MHz.
CPU1: Booted secondary processor
Calibrating delay loop... 159.33 BogoMIPS (lpj=796672)
CPU2: Booted secondary processor
Calibrating delay loop... 159.74 BogoMIPS (lpj=798720) Brought up 3 CPUs
SMP: Total of 3 processors activated (478.82 BogoMIPS).
...

Disassembly:

|@ Delay routine
|ENTRY(__delay)

C0940600|E2500001  __delay:  subs    r0,r0,#0x1
C0940604|8AFFFFFD        bhi     0xC0940600       ; __delay
C0940608|E1A0F00E        cpy     pc,r14

====> With an additional nop in __delay():

...
Calibrating delay loop... 398.95 BogoMIPS (lpj=1994752) Mount-cache hash table entries: 512
CPU: Testing write buffer coherency: ok Calibrating local timer... 199.97MHz.
CPU1: Booted secondary processor
Calibrating delay loop... 398.95 BogoMIPS (lpj=1994752)
CPU2: Booted secondary processor
Calibrating delay loop... 398.95 BogoMIPS (lpj=1994752) Brought up 3 CPUs
SMP: Total of 3 processors activated (1196.85 BogoMIPS).
...

Disassembly:

         |@ Delay routine
         |ENTRY(__delay)
         |#if defined(CONFIG_CPU_V6) && defined(CONFIG_SMP)
C0940600|E320F000  __delay:  nop
         |#endif
C0940604|E2500001        subs    r0,r0,#0x1
C0940608|8AFFFFFC        bhi     0xC0940600       ; __delay
C094060C|E1A0F00E        cpy     pc,r14
#1 lore raw
Quoted 16 lines · Dirk Behme

On a 400MHz ARM11 MPCore system (NEC NaviEngine based) with kernel 2.6.32 we found that BogoMIPS/loops per jiffies ~doubles (see below [1]) by adding a nop to __delay():

arch/arm/lib/delay.S +3 -0
@@ -41,6 +41,9 @@ ENTRY(__const_udelay)    @ 0 <= r0 <= 0x
  @ Delay routine
  ENTRY(__delay)
+#if defined(CONFIG_CPU_V6) && defined(CONFIG_SMP)
+        nop
+#endif
          subs    r0, r0, #1
  #if 0
          movls    pc, lr
 
Quoted 1 line

Any ideas what might happen here?

Branch (mis-)prediction? Alignment?

It doesn't really matter, bogomips should not be used as some form of performance checking.

BTW, local timers give a more accurate estimate of the CPU frequency (they are counting at half this frequency).

Signature · 1 line
Catalin
#2 lore raw
Quoted 29 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm-kernel- bounces at lists.infradead.org] On Behalf Of Catalin Marinas
Sent: Thursday, January 28, 2010 6:33 PM
To: Dirk Behme
Cc: linux-arm-kernel at lists.infradead.org
Subject: Re: ARM11 MPCore: Adding nop to __delay() doubles the BogoMIPS/lpj

Quoted 16 lines · Dirk Behme

On a 400MHz ARM11 MPCore system (NEC NaviEngine based) with kernel 2.6.32 we found that BogoMIPS/loops per jiffies ~doubles (see below [1]) by adding a nop to __delay():

arch/arm/lib/delay.S +3 -0
@@ -41,6 +41,9 @@ ENTRY(__const_udelay)    @ 0 <= r0 <= 0x
  @ Delay routine
  ENTRY(__delay)
+#if defined(CONFIG_CPU_V6) && defined(CONFIG_SMP)
+        nop
+#endif
          subs    r0, r0, #1
  #if 0
          movls    pc, lr
 
Quoted 1 line

Any ideas what might happen here?

Branch (mis-)prediction? Alignment?

Quoted 5 lines

It doesn't really matter, bogomips should not be used as some form of performance checking.

BTW, local timers give a more accurate estimate of the CPU frequency (they are counting at half this frequency).

Last time I was experimenting with this, the data I got from for A9 was " the loop prediction" makes this faster on the hw support fast loop mode . It is a feature of the C-A9 pipeline that enables it to spot short loops like
"BHI {pc}-4 ; 0x100 **" nd just issue store them in the pipiline queue
to be dispatched from there rather than being fetched from the Icache all the time.

Regards,
Santosh

#3 lore raw
In reply to Dirk Behme
Quoted 8 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm- kernel-bounces at lists.infradead.org] On Behalf Of Dirk Behme
Sent: 27 January 2010 16:45

On a 400MHz ARM11 MPCore system (NEC NaviEngine based) with kernel 2.6.32 we found that BogoMIPS/loops per jiffies ~doubles (see below [1]) by adding a nop to __delay():

The reason for this is that the ARM11 MPCore doesn't fold branch instructions for busy-wait-style loops. Inserting the nop (or any other non-branch instruction) removes the branch instruction from the execution stream.
http://infocenter.arm.com/help/topic/com.arm.doc.ddi0360f/ch06s02s04.html

But as Catalin says, this makes no functional difference, even though it might look "more impressive" :)

/
Leif