libibverbs: Undo changes in memory range tree when madvise() fails

PATCH Applied Alex Vainman 1 participant 1 message Feb 1, 2010 InfiniBand

Share & tools

Alex Vainman

author

2010-02-01 05:58 UTC #0 lore raw

PATCH v2 2/4 libibverbs: Undo changes in memory range tree when madvise() fails

ibv_madvise_range() doesn't cleanup if madvise() fails.
This patch comes to handle reference counter update on madvise() failure:

ibv_madvise_range() first updates memory range reference counter and only then calls to madvise(). If madvise() fails, the reference counter of the failed node is incorrect. This issue is fixed by updating node's reference counter only after a successful call to madvise() or if no call to madvise() was need since it was done in the past.

Signed-off-by Alex Vainman <alexv-smomgflXvOZWk0Htik3J/[email protected]>

---
 src/memory.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

src/memory.c +3 -4

index 51839e2..6a3305f 100644
@@ -521,10 +521,8 @@ static int ibv_madvise_range(void *base, size_t size, int advice)
 			}
 		}
 
-		node->refcnt += inc;
-
-		if ((inc == -1 && node->refcnt == 0) ||
-		    (inc ==  1 && node->refcnt == 1)) {
+		if ((inc == -1 && node->refcnt == 1) ||
+		    (inc ==  1 && node->refcnt == 0)) {
 			/*
 			 * If this is the first time through the loop,
 			 * and we merged this node with the previous

@@ -547,6 +545,7 @@ static int ibv_madvise_range(void *base, size_t size, int advice)
 				goto out;
 		}
 
+		node->refcnt += inc;
 		node = __mm_next(node);
 	}

Signature · 7 lines

1.6.5.3


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html