Skip to contentSkip to conversation

s3c64xx: Add ifdef at the S3C64XX only codes

PATCH New Joonyoung Shim 2 participants 3 messages Feb 8, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s3c64xx: Add ifdef at the S3C64XX only codes

The pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu. The pheripheral port setup codes should be executed by only S3C64XX cpu.

---
 cpu/arm1176/start.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
cpu/arm1176/start.S +2 -0
index 68a356d..5d9fba9 100644
@@ -190,10 +190,12 @@ mmu_disable:
 #endif
 
 mmu_disable_phys:
+#ifdef CONFIG_S3C64XX
 	/* Peri port setup */
 	ldr	r0, =0x70000000
 	orr	r0, r0, #0x13
 	mcr	p15,0,r0,c15,c2,4       @ 256M (0x70000000 - 0x7fffffff)
+#endif
 
 	/*
 	 * Go setup Memory and board specific bits prior to relocation.
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 s3c64xx: Add ifdef at the S3C64XX only codes

Quoted 9 lines · Joonyoung Shim

The pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu. The pheripheral port setup codes should be executed by only S3C64XX cpu.

---
 cpu/arm1176/start.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Sorry, i missed something. Please use the below patch.

#2 lore raw

PATCH 1/1 s3c64xx: Add ifdef at the S3C64XX only codes

Dear Joonyoung Shim,

Quoted 23 lines · Joonyoung Shim
Quoted 9 lines · Joonyoung Shim

The pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu. The pheripheral port setup codes should be executed by only S3C64XX cpu.

---
?cpu/arm1176/start.S | ? ?2 ++
?1 files changed, 2 insertions(+), 0 deletions(-)

Sorry, i missed something. Please use the below patch.

From 89017aa05e1cbb94aeddb3625584eca474d57684 Mon Sep 17 00:00:00 2001
From: Joonyoung Shim <[email protected]>
Date: Mon, 8 Feb 2010 20:25:23 +0900
Subject: [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes

The s3c6400.h file is only for S3C64XX cpu and the pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu, so they should be included by only S3C64XX cpu.

Quoted 6 lines

---
?cpu/arm1176/cpu.c ? | ? ?2 ++
?cpu/arm1176/start.S | ? ?4 ++++
?2 files changed, 6 insertions(+), 0 deletions(-)

Please add a version to the subject (like "[PATCH v2]"). So please resend the patch version 2.

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net