Skip to contentSkip to conversation

FRV: possibly bad unsigned comparison in show_backtrace()

DISCUSSION Roel Kluin 1 participant 2 messages Feb 8, 2010

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0 then the dump does not succeed because stop was set to 0 and unaltered when we reach the unsigned comparison:

while (tos < stop) {...}

The naming stop may on the other hand suggest that this is desired, is it?

Roel

author
#1 lore raw
Quoted 5 lines · Roel Kluin

In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0 then the dump does not succeed because stop was set to 0 and unaltered when we reach the unsigned comparison:

 while (tos < stop) {...}

I was mistaken, a while (tos >= stop) won't end

Roel