Skip to contentSkip to conversation

s5pc1xx: update the README file

PATCH New Minkyu Kang 3 participants 6 messages Feb 12, 2010 – Feb 18, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 s5pc1xx: update the README file

Because adds support the GPIO Interface, README file is updated.

---
 doc/README.s5pc1xx |   18 +++++++++++++++++-
 1 files changed, 17 insertions(+), 1 deletions(-)
doc/README.s5pc1xx +17 -1
index 5a0fe33..ab1f024 100644
@@ -41,7 +41,23 @@ To check SoC:
 		printf("cpu is s5pc110\n");
 
 gpio
-	not supported yet.
+
+	struct s5pc100_gpio *gpio = (struct s5pc100_gpio*)S5PC100_GPIO_BASE;
+
+	/* GPA[0] pin set to irq */
+	gpio_cfg_pin(&gpio->gpio_a, 0, GPIO_IRQ);
+
+	/* GPA[0] pin set to input */
+	gpio_direction_input(&gpio->gpio_a, 0);
+
+	/* GPA[0] pin set to output/high */
+	gpio_direction_output(&gpio->gpio_a, 0, 1);
+
+	/* GPA[0] value set to low */
+	gpio_set_value(&gpio->gpio_a, 0, 0);
+
+	/* get GPA[0] value */
+	value = gpio_get_value(&gpio->gpio_a, 0);
 
 Links
 =====
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 2/2 s5pc1xx: update the README file

Quoted 7 lines · Minkyu Kang

Because adds support the GPIO Interface, README file is updated.

---
?doc/README.s5pc1xx | ? 18 +++++++++++++++++- ?1 files changed, 17 insertions(+), 1 deletions(-)

applied to u-boot-samsung

Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 2/2 s5pc1xx: update the README file

Dear Minkyu Kang,

Quoted 9 lines · In message <[email protected]> you…
Quoted 6 lines · Minkyu Kang

Because adds support the GPIO Interface, README file is updated.

---
doc/README.s5pc1xx | =A0 18 +++++++++++++++++-

1 files changed, 17 insertions(+), 1 deletions(-)

applied to u-boot-samsung

Would it be possible to squash these two commits into one? They actually are one change and should not be split apart. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The amount of time between slipping on the peel and  landing  on  the
pavement is precisely 1 bananosecond.
#3 lore raw

PATCH 2/2 s5pc1xx: update the README file

Dear Wolfgang,

Quoted 11 lines · Wolfgang Denk

Dear Minkyu Kang,

Quoted 8 lines · In message <[email protected]> you…
Quoted 6 lines · Minkyu Kang

Because adds support the GPIO Interface, README file is updated.

---
doc/README.s5pc1xx | =A0 18 +++++++++++++++++-

1 files changed, 17 insertions(+), 1 deletions(-)
Quoted 4 lines
Quoted 1 line

applied to u-boot-samsung

Would it be possible to squash these two commits into one? They actually are one change and should not be split apart. ?Thanks.

I already pushed these patches.
Do I need to revert the patchset?
Or, give me your opinion, if you have any idea.

Quoted 12 lines

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The amount of time between slipping on the peel and ?landing ?on ?the pavement is precisely 1 bananosecond.

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#4 lore raw

PATCH 2/2 s5pc1xx: update the README file

Dear Minkyu Kang,

Quoted 7 lines · In message <[email protected]> you…
Quoted 3 lines

Would it be possible to squash these two commits into one? They actually are one change and should not be split apart. =A0Thanks.

I already pushed these patches.
Do I need to revert the patchset?
Or, give me your opinion, if you have any idea.

If you agree, you can "git rebase -i" your branch and squash the two commits into one.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
                     several applications can crash at the same time.
#5 lore raw

PATCH 2/2 s5pc1xx: update the README file

Dear Wolfgang,

Quoted 7 lines · Wolfgang Denk

Dear Minkyu Kang,

Quoted 4 lines · In message <[email protected]> you…
Quoted 3 lines

Would it be possible to squash these two commits into one? They actually are one change and should not be split apart. =A0Thanks.

Quoted 6 lines
Quoted 3 lines

I already pushed these patches.
Do I need to revert the patchset?
Or, give me your opinion, if you have any idea.

If you agree, you can "git rebase -i" your branch and squash the two commits into one.

I did it.
But, there are remained old two commits.
Did I something wrong?

I appreciate your help.

Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net