Skip to contentSkip to conversation

Doc/SubmitChecklist: add rule #1

PATCH New Randy Dunlap 1 participant 1 message Feb 16, 2010 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Doc/SubmitChecklist: add rule #1

From: Randy Dunlap <[email protected]>

Add header file requirements.
Complements of Stephen Rothwell.

Stephen calls this Rule #1, so I put it there, but I didn't want to demote any of the others in the list, so I made one of them number 2b.

Cc Stephen Rothwell <[email protected]>
---
 Documentation/SubmitChecklist |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Documentation/SubmitChecklist +6 -2
@@ -9,10 +9,14 @@ Documentation/SubmittingPatches and else
 kernel patches.
 
 
-1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
+1: If you use a facility then #include the file that defines/declares
+   that facility.  Don't depend on other header files pulling in ones
+   that you use.
+
+2: Builds cleanly with applicable or modified CONFIG options =y, =m, and
    =n.  No gcc warnings/errors, no linker warnings/errors.
 
-2: Passes allnoconfig, allmodconfig
+2b: Passes allnoconfig, allmodconfig
 
 3: Builds on multiple CPU architectures by using local cross-compile tools
    or some other build farm.