AT91: Added support for taskit Stamp9G20 and PortuxG20
PATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
--- Makefile | 9 ++ board/taskit/stamp9G20/Makefile | 56 ++++++++++ board/taskit/stamp9G20/config.mk | 1 + board/taskit/stamp9G20/led.c | 35 ++++++ board/taskit/stamp9G20/partition.c | 40 +++++++ board/taskit/stamp9G20/stamp9G20.c | 200 ++++++++++++++++++++++++++++++++++++ include/configs/stamp9G20.h | 197 +++++++++++++++++++++++++++++++++++ 7 files changed, 538 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9G20/Makefile create mode 100644 board/taskit/stamp9G20/config.mk create mode 100644 board/taskit/stamp9G20/led.c create mode 100644 board/taskit/stamp9G20/partition.c create mode 100644 board/taskit/stamp9G20/stamp9G20.c create mode 100644 include/configs/stamp9G20.h
Makefile +9 -0
@@ -2906,6 +2906,15 @@ TNY_A9260_config : unconfig @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 +portuxG20_config \ +stamp9G20_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring portux,$@)" ] ; then \ + echo "#define CONFIG_PORTUXG20 1" >$(obj)include/config.h; \ + $(XECHO) "... PortuxG20";\ + fi; + @$(MKCONFIG) -a stamp9G20 arm arm926ejs stamp9G20 taskit at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \
board/taskit/stamp9G20/Makefile new file +56 -0
56 lines not on this page · raw message
board/taskit/stamp9G20/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
board/taskit/stamp9G20/led.c new file +35 -0
@@ -0,0 +1,35 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#include <common.h> +#include <asm/arch/at91sam9260.h> +#include <asm/arch/at91_pmc.h> +#include <asm/arch/gpio.h> +#include <asm/arch/io.h> + +void coloured_LED_init (void ) +{ +/* Enable clock */ +at91_sys_write (AT91_PMC_PCER ,1 <<AT91SAM9260_ID_PIOC ); +}
board/taskit/stamp9G20/partition.c new file +40 -0
@@ -0,0 +1,40 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS1 ,1 } +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x000041FF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00004200 ,0x000083FF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00008400 ,0x00041FFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, + {0x00042000 ,0x00251FFF ,FLAG_PROTECT_CLEAR ,0 ,"Kernel" }, + {0x00252000 ,0xFFFFFFFF ,FLAG_PROTECT_CLEAR ,0 ,"FS" }, +};
board/taskit/stamp9G20/stamp9G20.c new file +200 -0
200 lines not on this page · raw message
include/configs/stamp9G20.h new file +197 -0
197 lines not on this page · raw message
Signature · 1 line
1.6.4.4
PATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
Dear Achim Ehrlich,
Quoted 2 lines · In message <[email protected]> you wrote:
Signed-off-by Achim Ehrlich <[email protected]>---
...
Makefile TNY_A9260_config : unconfig · line 2915
Quoted 13 lines
Makefile +7
-0@@ -2906,6 +2906,15 @@ TNY_A9260_config : unconfig @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 +portuxG20_config \ +stamp9G20_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring portux,$@)" ] ; then \ + echo "#define CONFIG_PORTUXG20 1" >$(obj)include/config.h; \ + $(XECHO) "... PortuxG20";\ + fi;
NAK. We don't accept such scripting in the Makefile any more. Please use the available mkconfig features instead.
board/taskit/stamp9G20/partition.c
Quoted 5 lines
board/taskit/stamp9G20/partition.c new file +0
-0
So we are adding yet another copy of this file. We already have 12 of these. Mostly identical.
Isn't there a more intelligent way to handle this?
...
board/taskit/stamp9G20/partition.c
Quoted 6 lines
board/taskit/stamp9G20/partition.c new file +6
-0+int dram_init (void ) +{ + gd->bd->bi_dram[0 ].start =PHYS_SDRAM ; + gd->bd->bi_dram[0 ].size =PHYS_SDRAM_SIZE ; +return 0 ; +}
Please consider using get_ram_size() for memory auto-sizing and testing.
board/taskit/stamp9G20/partition.c
Quoted 4 lines
board/taskit/stamp9G20/partition.c new file +4
-0+#ifdef CONFIG_RESET_PHY_R +void reset_phy (void ) +{ +#ifdef CONFIG_MACB
CONFIG_MACB seems to be an undocumented variable. What is it supposed to do?
Quoted 5 lines
include/configs/stamp9G20.h new file +0
-0
...
include/configs/stamp9G20.h line 36
Quoted 2 lines
include/configs/stamp9G20.h new file +2
-0+/* ARM asynchronous clock */ +#define AT91_MAIN_CLOCK 18432000/* 18.432 MHz crystal */
This should be changed into a CONFIG_SYS_ (globally).
Quoted 1 line
+#define
AT91_CPU_NAME"AT91SAM9G20"
Ditto.
include/configs/stamp9G20.h line 66
Quoted 5 lines
include/configs/stamp9G20.h new file +5
-0+#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART3 1/* USART 3 is DBGU */
Do not undefine what is not defined anyway.
include/configs/stamp9G20.h line 70
Quoted 3 lines
include/configs/stamp9G20.h new file +3
-0+/* LED */ + +#undef CONFIG_AT91_LED
Ditto.
include/configs/stamp9G20.h line 91
Quoted 9 lines
include/configs/stamp9G20.h new file +9
-0+/* +* Command line configuration. +*/ +#include <config_cmd_default.h> +#undef CONFIG_CMD_BDI +#undef CONFIG_CMD_FPGA +#undef CONFIG_CMD_IMI +#undef CONFIG_CMD_IMLS +#undef CONFIG_CMD_SOURCE
Is there any specific reason for disabling the "bdi", "imi", "imls" and "source" commands? They are pretty useful, and you don't seem to be especially short on resources...
...
include/configs/stamp9G20.h line 139
Quoted 6 lines
include/configs/stamp9G20.h new file +6
-0+/* USB */ +#define CONFIG_USB_ATMEL +#define CONFIG_USB_OHCI_NEW 1 +#define CONFIG_DOS_PARTITION 1 +#define CONFIG_SYS_USB_OHCI_CPU_INIT 1 +#define CONFIG_SYS_USB_OHCI_REGS_BASE 0x00500000/* AT91SAM9260_UHP_BASE */
Line too long. Please fix globally.
...
include/configs/stamp9G20.h line 174
Quoted 5 lines
include/configs/stamp9G20.h new file +5
-0+"basicargs=console=ttyS0,115200 mem=64M\0" \ +"" + + +
Excessive white space. Drop 3 of the empty lines.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Do we define evil as the absence of goodness? It seems only logical
that shit happens--we discover this by the process of elimination."
-- Larry WallPATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
In reply to Achim EhrlichHi Achim,
Quoted 43 lines
Signed-off-by Achim Ehrlich <[email protected]>--- Makefile | 9 ++ board/taskit/stamp9G20/Makefile | 56 ++++++++++ board/taskit/stamp9G20/config.mk | 1 + board/taskit/stamp9G20/led.c | 35 ++++++ board/taskit/stamp9G20/partition.c | 40 +++++++ board/taskit/stamp9G20/stamp9G20.c | 200 ++++++++++++++++++++++++++++++++++++ include/configs/stamp9G20.h | 197 +++++++++++++++++++++++++++++++++++ 7 files changed, 538 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9G20/Makefile create mode 100644 board/taskit/stamp9G20/config.mk create mode 100644 board/taskit/stamp9G20/led.c create mode 100644 board/taskit/stamp9G20/partition.c create mode 100644 board/taskit/stamp9G20/stamp9G20.c create mode 100644 include/configs/stamp9G20.hMakefile +9
-0@@ -2906,6 +2906,15 @@ TNY_A9260_config : unconfig @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 +portuxG20_config \ +stamp9G20_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring portux,$@)" ] ; then \ + echo "#define CONFIG_PORTUXG20 1" >$(obj)include/config.h; \ + $(XECHO) "... PortuxG20";\ + fi; + @$(MKCONFIG) -a stamp9G20 arm arm926ejs stamp9G20 taskit at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \board/taskit/stamp9G20/Makefile new file +0
-0
board/taskit/stamp9G20/Makefile line 7
Quoted 7 lines
board/taskit/stamp9G20/Makefile new file +7
-0@@ -0,0 +1,56 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# (C) Copyright 2008 +# Stelian Pop <[email protected]> +# Lead Tech Design <www.leadtechdesign.com>
Well actually I am not a fan of including all these copyrights in a file which has so little content - so I'd vote to remove them and include your own copyright.
But if for some reason the copyrights are not removed, then please at least add yourself in.
[...]
board/taskit/stamp9G20/led.c line 4
Quoted 10 lines
board/taskit/stamp9G20/led.c new file +4
-0@@ -0,0 +1,35 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com>
Dito.
Quoted 37 lines
board/taskit/stamp9G20/led.c new file +31
-0+* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#include <common.h> +#include <asm/arch/at91sam9260.h> +#include <asm/arch/at91_pmc.h> +#include <asm/arch/gpio.h> +#include <asm/arch/io.h> + +void coloured_LED_init (void ) +{ +/* Enable clock */ +at91_sys_write (AT91_PMC_PCER ,1 <<AT91SAM9260_ID_PIOC ); +}board/taskit/stamp9G20/partition.c new file +0
-0
board/taskit/stamp9G20/partition.c line 3
Quoted 3 lines
board/taskit/stamp9G20/partition.c new file +3
-0@@ -0,0 +1,40 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]>
Dito.
board/taskit/stamp9G20/stamp9G20.c line 7
Quoted 13 lines
board/taskit/stamp9G20/stamp9G20.c new file +7
-0@@ -0,0 +1,200 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* Achim Ehrlich <[email protected]> +* taskit GmbH <www.taskit.de>
Ok, this time you added your name - although I would have expected a year.
Cheers
Detlev
Signature · 8 lines
Infolge sklavischer "Kategoritis" werden die wissenschaftlichen unlogischen und - wie wir sehen werden - oft sinnlosen Fragen wie "Wo wohnst du?", "Was bist du?", "Welche Religion?", "Welche Rasse?", "Welche Nationalit?t?" alle- samt heute f?r logische Fragen gehalten. -- Richard Buckminster Fuller -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
In reply to Wolfgang DenkDear Wolfgang Denk,
Quoted 11 lines
Quoted 2 lines · In message <[email protected]> you wrote:
Signed-off-by Achim Ehrlich <[email protected]>---
...
Quoted 6 lines
Makefile +0
-0@@ -2906,6 +2906,15 @@ TNY_A9260_config : unconfig @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91
Quoted 11 lines
Makefile TNY_A9260_config : unconfig · line 2915
Quoted 7 lines
Makefile +7
-0+portuxG20_config \ +stamp9G20_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring portux,$@)" ] ; then \ + echo "#define CONFIG_PORTUXG20 1" >$(obj)include/config.h; \ + $(XECHO) "... PortuxG20";\ + fi;NAK. We don't accept such scripting in the
Makefileany more. Please use the available mkconfig features instead.
Sorry, I overlooked that feature and will change that.
Quoted 10 lines
board/taskit/stamp9G20/partition.c
Quoted 6 lines
board/taskit/stamp9G20/partition.c new file +0
-0So we are adding yet another copy of this file. We already have 12 of these. Mostly identical.
Quoted 2 lines
Isn't there a more intelligent way to handle this?
The file has not much content anyway. I can get rid of it completely.
Quoted 10 lines
...
board/taskit/stamp9G20/partition.c
Quoted 6 lines
board/taskit/stamp9G20/partition.c new file +6
-0+int dram_init (void ) +{ + gd->bd->bi_dram[0 ].start =PHYS_SDRAM ; + gd->bd->bi_dram[0 ].size =PHYS_SDRAM_SIZE ; +return 0 ; +}Please consider using
get_ram_size()for memory auto-sizing and testing.
Thanks for the hint, i will test it.
Quoted 10 lines
board/taskit/stamp9G20/partition.c
Quoted 5 lines
board/taskit/stamp9G20/partition.c new file +4
-0+#ifdef CONFIG_RESET_PHY_R +void reset_phy (void ) +{ +#ifdef CONFIG_MACB
CONFIG_MACBseems to be an undocumented variable. What is it supposed to do?
It switches on the pin initialization for the Ethernet MAC. Actually, i just copied this part from the AT91SAM9260ek board code.
Quoted 7 lines
Quoted 6 lines
include/configs/stamp9G20.h new file +0
-0...
Quoted 5 lines
include/configs/stamp9G20.h line 36
Quoted 2 lines
include/configs/stamp9G20.h new file +2
-0+/* ARM asynchronous clock */ +#define AT91_MAIN_CLOCK 18432000/* 18.432 MHz crystal */ This should be changed into a
CONFIG_SYS_(globally).
Do you mean, I should change that for all AT91-Boards in u-boot? How or who is going to test that?
Quoted 43 lines
Quoted 2 lines
+#define
AT91_CPU_NAME"AT91SAM9G20"Ditto.
include/configs/stamp9G20.h line 66
Quoted 5 lines
include/configs/stamp9G20.h new file +5
-0+#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART3 1/* USART 3 is DBGU */ Do not undefine what is not defined anyway.
include/configs/stamp9G20.h line 70
Quoted 3 lines
include/configs/stamp9G20.h new file +3
-0+/* LED */ + +#undef CONFIG_AT91_LEDDitto.
include/configs/stamp9G20.h line 91
Quoted 9 lines
include/configs/stamp9G20.h new file +9
-0+/* +* Command line configuration. +*/ +#include <config_cmd_default.h> +#undef CONFIG_CMD_BDI +#undef CONFIG_CMD_FPGA +#undef CONFIG_CMD_IMI +#undef CONFIG_CMD_IMLS +#undef CONFIG_CMD_SOURCEIs there any specific reason for disabling the "bdi", "imi", "imls" and "source" commands? They are pretty useful, and you don't seem to be especially short on resources...
...
include/configs/stamp9G20.h line 139
Quoted 6 lines
include/configs/stamp9G20.h new file +6
-0+/* USB */ +#define CONFIG_USB_ATMEL +#define CONFIG_USB_OHCI_NEW 1 +#define CONFIG_DOS_PARTITION 1 +#define CONFIG_SYS_USB_OHCI_CPU_INIT 1 +#define CONFIG_SYS_USB_OHCI_REGS_BASE 0x00500000/* AT91SAM9260_UHP_BASE */ Line too long. Please fix globally.
Quoted 8 lines
...
include/configs/stamp9G20.h line 174
Quoted 5 lines
include/configs/stamp9G20.h new file +5
-0+"basicargs=console=ttyS0,115200 mem=64M\0" \ +"" + + +Excessive white space. Drop 3 of the empty lines.
I will fix these as well.
Thank you for your corrections.
Kind regards
Achim
Signature · 13 lines
product manager email:aehrlich at taskit.de Tel.: ++49 30 611295-25 Fax: ++49 30 611295-11 -- taskit GmbH Seelenbinderstr. 33 | D-12555 Berlin web:http://www.taskit.de Amtsgericht Charlottenburg: 93HRB39014 Managing director: Thorsten Raulfs --
PATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
In reply to Detlev ZundelHello Detlef,
Quoted 55 lines
Quoted 43 lines
Signed-off-by Achim Ehrlich <[email protected]>--- Makefile | 9 ++ board/taskit/stamp9G20/Makefile | 56 ++++++++++ board/taskit/stamp9G20/config.mk | 1 + board/taskit/stamp9G20/led.c | 35 ++++++ board/taskit/stamp9G20/partition.c | 40 +++++++ board/taskit/stamp9G20/stamp9G20.c | 200 ++++++++++++++++++++++++++++++++++++ include/configs/stamp9G20.h | 197 +++++++++++++++++++++++++++++++++++ 7 files changed, 538 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9G20/Makefile create mode 100644 board/taskit/stamp9G20/config.mk create mode 100644 board/taskit/stamp9G20/led.c create mode 100644 board/taskit/stamp9G20/partition.c create mode 100644 board/taskit/stamp9G20/stamp9G20.c create mode 100644 include/configs/stamp9G20.hMakefile +9
-0@@ -2906,6 +2906,15 @@ TNY_A9260_config : unconfig @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 +portuxG20_config \ +stamp9G20_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring portux,$@)" ] ; then \ + echo "#define CONFIG_PORTUXG20 1" >$(obj)include/config.h; \ + $(XECHO) "... PortuxG20";\ + fi; + @$(MKCONFIG) -a stamp9G20 arm arm926ejs stamp9G20 taskit at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \board/taskit/stamp9G20/Makefile new file +0
-0board/taskit/stamp9G20/Makefile line 7
Quoted 7 lines
board/taskit/stamp9G20/Makefile new file +7
-0@@ -0,0 +1,56 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# (C) Copyright 2008 +# Stelian Pop <[email protected]> +# Lead Tech Design <www.leadtechdesign.com>Well actually I am not a fan of including all these copyrights in a file which has so little content - so I'd vote to remove them and include your own copyright.
Quoted 5 lines
But if for some reason the copyrights are not removed, then please at least add yourself in.
[...]
OK.
Quoted 13 lines
board/taskit/stamp9G20/led.c line 4
Quoted 11 lines
board/taskit/stamp9G20/led.c new file +4
-0@@ -0,0 +1,35 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> Dito.
I haven't changed one bit in this file, I really do not feel like even adding my copyright.
Quoted 44 lines
Quoted 38 lines
board/taskit/stamp9G20/led.c new file +31
-0+* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#include <common.h> +#include <asm/arch/at91sam9260.h> +#include <asm/arch/at91_pmc.h> +#include <asm/arch/gpio.h> +#include <asm/arch/io.h> + +void coloured_LED_init (void ) +{ +/* Enable clock */ +at91_sys_write (AT91_PMC_PCER ,1 <<AT91SAM9260_ID_PIOC ); +}board/taskit/stamp9G20/partition.c new file +0
-0board/taskit/stamp9G20/partition.c line 3
Quoted 3 lines
board/taskit/stamp9G20/partition.c new file +3
-0@@ -0,0 +1,40 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> Dito.
Quoted 17 lines
board/taskit/stamp9G20/stamp9G20.c line 7
Quoted 13 lines
board/taskit/stamp9G20/stamp9G20.c new file +7
-0@@ -0,0 +1,200 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* Achim Ehrlich <[email protected]> +* taskit GmbH <www.taskit.de> Ok, this time you added your name - although I would have expected a year.
Hmm, right.
Kind regards
Achim
Signature · 13 lines
product manager email:aehrlich at taskit.de Tel.: ++49 30 611295-25 Fax: ++49 30 611295-11 -- taskit GmbH Seelenbinderstr. 33 | D-12555 Berlin web:http://www.taskit.de Amtsgericht Charlottenburg: 93HRB39014 Managing director: Thorsten Raulfs --
PATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
Hello Achim,
[...]
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
board/taskit/stamp9G20/led.c new file +0
-1--- /dev/nullQuoted 8 lines
board/taskit/stamp9G20/led.c line 4
Quoted 6 lines
+++
b/board/taskit/stamp9G20/led.cboard/taskit/stamp9G20/led.c new file +4
-0@@ -0,0 +1,35 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> Dito.
Quoted 2 lines
I haven't changed one bit in this file, I really do not feel like even adding my copyright.
Actually you have copied the file into a new context and use it in a different way than the original file.
I know that this case is somewhat on the border but if somebody reads the code from a tar-archive, it surely looks like Stelian Pop created this specific instance of this file which is not correct.
Cheers
Detlev
Signature · 7 lines
Given that I had no time for a nervous breakdown, I chose to fix the
issue instead...
-- Philippe Gerum
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH 1/1 AT91: Added support for taskit Stamp9G20 and PortuxG20
In reply to Achim EhrlichDear Achim Ehrlich,
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 9 lines
board/taskit/stamp9G20/stamp9G20.c line 183
Quoted 5 lines
board/taskit/stamp9G20/stamp9G20.c new file +4
-0+#ifdef CONFIG_RESET_PHY_R +void reset_phy (void ) +{ +#ifdef CONFIG_MACB
CONFIG_MACBseems to be an undocumented variable. What is it supposed to do?
Quoted 2 lines
It switches on the pin initialization for the Ethernet MAC. Actually, i just copied this part from the AT91SAM9260ek board code.
If you uuse it, please add a short note to the READMe, then.
But do you really need this? What would reset_phy() do if this variable was not set?
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
include/configs/stamp9G20.h new file +0
-0...
Quoted 7 lines
Quoted 5 lines
include/configs/stamp9G20.h line 36
Quoted 2 lines
include/configs/stamp9G20.h new file +2
-0+/* ARM asynchronous clock */ +#define AT91_MAIN_CLOCK 18432000/* 18.432 MHz crystal */ This should be changed into a
CONFIG_SYS_(globally).Do you mean, I should change that for all AT91-Boards in u-boot?
Such a change would indeed make sense to me (it should be done separately and indenpendent from your patch, probably before adding your code).
Quoted 1 line
How or who is going to test that?
We can compare the binary images for all AT91 builds - except for the time stamps they should be unaffected by this change. And we can actually test the images on a few boards.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Use the Force, Luke.