Skip to contentSkip to conversation

xfstests: don't delete scratch loop device w/ umount -d

PATCH In review Eric Sandeen 2 participants 2 messages Feb 17, 2010 – Feb 19, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: don't delete scratch loop device w/ umount -d

Recent fixes to 073 added umount -d, but if we happen to be using a scratch device on loopback, subsequent tests get very, very unhappy when their loopback block device goes away!

---

073 +2 -1
index 90fa1f0..7ce6efb 100755
@@ -119,7 +119,8 @@ _verify_copy()
 	diff -u $tmp.geometry1 $tmp.geometry2
 
 	echo unmounting and removing new image
-	umount -d $source_dir $target_dir
+	umount $source_dir
+	umount -d $target_dir
 	rm -f $target
 }
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Eric Sandeen

Recent fixes to 073 added umount -d, but if we happen to be using a scratch device on loopback, subsequent tests get very, very unhappy when their loopback block device goes away!

True, we only need -d for the loop devices created in the test.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs