Skip to contentSkip to conversation

QEMU kill CR3_CACHE references

PATCH Applied Jes Sorensen 4 participants 4 messages Feb 19, 2010 – Feb 21, 2010 KVM

lore
Share & tools
lore

Jes Sorensen

author
#0 lore raw

PATCH 1/1 QEMU kill CR3_CACHE references

Hi,

The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c.

Cheers,
Jes

commit 5ed16687929511d015dd3542c4359cabe170401a

Author: Jes Sorensen <[email protected]>
Date:   Fri Feb 19 07:39:56 2010 +0100

Remove all references to KVM_CR3_CACHE as it was never implemented.

Signed-off-by Jes Sorensen <[email protected]>
target-i386/kvm.c +0 -3
index 0d08cd5..5d9aecc 100644
@@ -158,9 +158,6 @@ struct kvm_para_features {
 #ifdef KVM_CAP_PV_MMU
         { KVM_CAP_PV_MMU, KVM_FEATURE_MMU_OP },
 #endif
-#ifdef KVM_CAP_CR3_CACHE
-        { KVM_CAP_CR3_CACHE, KVM_FEATURE_CR3_CACHE },
-#endif
         { -1, -1 }
 };
#1 lore raw
Quoted 5 lines

Hi,

The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c.

This feature was broken by design. Glad to see it go.

Zach

#2 lore raw
In reply to Jes Sorensen
Quoted 5 lines · Jes Sorensen

Hi,

The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c.

Let's bring this through uq/master? Sound reasonable Marcelo?

Regards,

Anthony Liguori

Quoted 3 lines

Cheers,
Jes

Applied
#3 lore raw
In reply to Jes Sorensen
Quoted 6 lines · Jes Sorensen

Hi,

The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function