ARM: misplaced parentheses?
Subsystems (2)
PATCH 1/1 ARM: misplaced parentheses?
The parentheses appear misplaced.
Signed-off-by Roel Kluin <[email protected]>
---
Correct?
arch/arm/mach-u300/gpio.c +1 -1
@@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)for (i =0 ; i <U300_GPIO_MAX ; i++) { val =0 ;for (j =0 ; j <8 ; j++) - val |= (u32)((u300_gpio_config[i][j].pull_up ==DISABLE_PULL_UP )) << j; + val |= (u32)((u300_gpio_config[i][j].pull_up ==DISABLE_PULL_UP ) << j);local_irq_save (flags);writel (val, virtbase +U300_GPIO_PXPER + i *U300_GPIO_PORTX_SPACING );local_irq_restore (flags);
[Roel]
Quoted 19 lines
The parentheses appear misplaced.
Signed-off-by Roel Kluin <[email protected]>---
Correct?arch/arm/mach-u300/gpio.c +1
-1@@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)for (i =0 ; i <U300_GPIO_MAX ; i++) { val =0 ;for (j =0 ; j <8 ; j++) - val |= (u32)((u300_gpio_config[i][j].pull_up ==DISABLE_PULL_UP )) << j; + val |= (u32)((u300_gpio_config[i][j].pull_up ==DISABLE_PULL_UP ) << j);local_irq_save (flags);
Quoted 3 lines
writel(val, virtbase +
U300_GPIO_PXPER+ i *U300_GPIO_PORTX_SPACING);
local_irq_restore(flags);
Acked-by Linus Walleij <[email protected]>
BTW this should go in through Russells patch tracker, can you put it there?
http://www.arm.linux.org.uk/developer/patches/
Linus Walleij
Quoted 6 lines
Quoted 1 line
The parentheses appear misplaced.
Acked-by Linus Walleij <[email protected]>BTW this should go in through Russells patch tracker, can you put it there?
Ok, its here:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5956/1
Thanks, Roel