Skip to contentSkip to conversation

ARM: misplaced parentheses?

PATCH In review Roel Kluin 2 participants 3 messages Feb 20, 2010 – Feb 23, 2010

Subsystems (2)
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 ARM: misplaced parentheses?

The parentheses appear misplaced.

---
Correct?

arch/arm/mach-u300/gpio.c +1 -1
index 0b35826..5f61fd4 100644
@@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
 	for (i = 0; i < U300_GPIO_MAX; i++) {
 		val = 0;
 		for (j = 0; j < 8; j++)
-			val |= (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
+			val |= (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
 		local_irq_save(flags);
 		writel(val, virtbase + U300_GPIO_PXPER + i * U300_GPIO_PORTX_SPACING);
 		local_irq_restore(flags);
Acked-by on v1 1/1
#1 lore raw

[Roel]

Quoted 19 lines

The parentheses appear misplaced.

---
Correct?

arch/arm/mach-u300/gpio.c +1 -1
index 0b35826..5f61fd4 100644
@@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
 	for (i = 0; i < U300_GPIO_MAX; i++) {
 		val = 0;
 		for (j = 0; j < 8; j++)
-			val |= 
 (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
+			val |= 
 (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
 		local_irq_save(flags);
Quoted 3 lines

writel(val, virtbase + U300_GPIO_PXPER + i *
U300_GPIO_PORTX_SPACING);
local_irq_restore(flags);

BTW this should go in through Russells patch tracker, can you put it there?
http://www.arm.linux.org.uk/developer/patches/

Linus Walleij