Skip to contentSkip to conversation

m68k,m68knommu: missing asterisk?

PATCH In review Roel Kluin 2 participants 2 messages Feb 20, 2010 – Feb 23, 2010 m68k architecture

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 m68k,m68knommu: missing asterisk?

An asterisk was missing.

---
Correct?

 arch/m68k/include/asm/apollohw.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/m68k/include/asm/apollohw.h +1 -1
index a1373b9..87e0cc4 100644
@@ -94,7 +94,7 @@ extern u_long timer_physaddr;
 
 #define sio01 ((*(volatile struct SCN2681 *)(IO_BASE + sio01_physaddr)))
 #define sio23 ((*(volatile struct SCN2681 *)(IO_BASE + sio23_physaddr)))
-#define rtc (((volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
+#define rtc ((*(volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
 #define cpuctrl (*(volatile unsigned int *)(IO_BASE + cpuctrl_physaddr))
 #define pica (IO_BASE + pica_physaddr)
 #define picb (IO_BASE + picb_physaddr)
#1 lore raw
Quoted 5 lines · Roel Kluin

An asterisk was missing.

---
Correct?

No, see arch/m68k/apollo/config.c:dn_dummy_hwclk().
Andrew: please dequeue.

Quoted 8 lines

 arch/m68k/include/asm/apollohw.h |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
arch/m68k/include/asm/apollohw.h +0 -0
index a1373b9..87e0cc4 100644

arch/m68k/include/asm/apollohw.h extern u_long timer_physaddr; · line 100

Quoted 8 lines
arch/m68k/include/asm/apollohw.h +1 -1
@@ -94,7 +94,7 @@ extern u_long timer_physaddr;
 
  #define sio01 ((*(volatile struct SCN2681 *)(IO_BASE + sio01_physaddr)))
  #define sio23 ((*(volatile struct SCN2681 *)(IO_BASE + sio23_physaddr)))
-#define rtc (((volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
+#define rtc ((*(volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
  #define cpuctrl (*(volatile unsigned int *)(IO_BASE + cpuctrl_physaddr))
  #define pica (IO_BASE + pica_physaddr)
  #define picb (IO_BASE + picb_physaddr)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds