imx27lite board support no longer compile
Hello Stefano,
your following commit breaks building the imx27lite board (and all boards, which uses the ./drivers/net/fec_mxc.c I think), because the following function is missing:
[hs at pollux u-boot]$ grep -lr imx_get_fecclk ../drivers/net/fec_mxc.c./drivers/net/fec_mxc.o./drivers/net/libnet.a
./LOG/imx27lite.ERR
[hs at pollux u-boot]$
and this function is only used in this driver ...
---------------------------------------------------------------
author Stefano Babic <[email protected]>
commit 4294b2485bf0e8d68c893190a96bb0e7856b12c4
fec_mxc: add support for MX51 processor
The patch add support for the Freescale mx51 processor
to the FEC ethernet driver.
---------------------------------------------------------------
... any ideas?
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 2 lines · Heiko Schocher
Hello Stefano,
Hi Heiko,
Quoted 22 lines
your following commit breaks building the imx27lite board (and all boards, which uses the
./drivers/net/fec_mxc.cI think), because the following function is missing:[hs at pollux u-boot]$ grep -lr
imx_get_fecclk../drivers/net/fec_mxc.c./drivers/net/fec_mxc.o./drivers/net/libnet.a
./LOG/imx27lite.ERR
[hs at pollux u-boot]$and this function is only used in this driver ...
---------------------------------------------------------------
author Stefano Babic <[email protected]>
commit4294b2485bf0e8d68c893190a96bb0e7856b12c4
fec_mxc: add support for MX51 processorThe patch add support for the Freescale mx51 processor
Quoted 8 lines
to the FEC ethernet driver.
Signed-off-by Stefano Babic <[email protected]>Signed-off-by Ben Warren <[email protected]>---------------------------------------------------------------
... any ideas?
Yes, at the same time two patches for the fec_imx was sent by me and by John. John sends to me and to the ML a comment informing that he made patches to factor a lot of SOC specific, cleaning up code and avoiding nasty #ifdef.
I see his patch in archive as
http://www.mail-archive.com/u-boot at lists.denx.de/msg27481.html.
I have already used the proposed function, but John's patch is not already in the mainline - probably it is still in the imx queue. Jason is working to bring a lot of MX patches in the mainline this week.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
Quoted 4 lines
Quoted 3 lines · Heiko Schocher
your following commit breaks building the imx27lite board (and all boards, which uses the
./drivers/net/fec_mxc.cI think), because the following function is missing:
Hello Heiko,
I have applied John's patches to the u-boot-imx tree. Building of imx27lite is ok using that tree.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
Hello Stefano,
Quoted 9 lines · Stefano Babic
Quoted 4 lines
Quoted 3 lines · Heiko Schocher
your following commit breaks building the imx27lite board (and all boards, which uses the
./drivers/net/fec_mxc.cI think), because the following function is missing:Hello Heiko,
I have applied John's patches to the u-boot-imx tree. Building of imx27lite is ok using that tree.
Thanks for the info!
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany