Skip to contentSkip to conversation

edac_i5[40]00 sparse warnings

DISCUSSION Randy Dunlap 1 participant 1 message Feb 25, 2010 EDAC-core

lore
Share & tools
lore
#0 lore raw

Hi,

drivers/edac/i5000_edac.c:496:15: warning: right shift by bigger than source value drivers/edac/i5000_edac.c:591:23: warning: right shift by bigger than source value drivers/edac/i5400_edac.c:401:36: warning: right shift by bigger than source value drivers/edac/i5400_edac.c:411:37: warning: right shift by bigger than source value

It appears that

	u16 nrecmemb;

does not contain enough bits for these drivers. ;)

i5000_edac:
#define NREC_CAS(x) (((x)>>16) & 0xFFFFFF)

where x is nrecmemb:

	cas = NREC_CAS(info->nrecmemb);

so 'cas' is always 0. Maybe it is.

i5400_edac:

	return (info->nrecmemb) >> 31;
and
	return ((info->nrecmemb) >> 16) & 0x1fff;
Signature · 8 lines
~Randy

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev