Skip to contentSkip to conversation

Likewise policy

PATCH New Scott Salley 2 participants 3 messages Mar 8, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Likewise policy

Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+allow lwiod_t likewise_krb5_ad_t:file read_file_perms;
+allow lwiod_t netlogond_var_lib_t:file read_file_perms;
+
+corenet_tcp_bind_generic_node(lwiod_t)
+corenet_tcp_bind_smbd_port(lwiod_t)
+corenet_tcp_connect_smbd_port(lwiod_t)

The networking block is missing to interface calls to ensure compatibility.

Sorry, I don't understand the comment 'The networking block is missing...". Could you please explain?

Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +3 -0
+allow lwsmd_t lwregd_t:process { signal siginh rlimitinh };
+allow lwsmd_t netlogond_t:process { signal siginh rlimitinh };
+allow lwsmd_t srvsvcd_t:process { signal siginh rlimitinh };

I suspect these can be removed. signal is already allowed and the other permissions are rarely needed.

Where is signal already allowed? (siginh and rlimitinh can certainly be removed).

Thank you for all the comments/advice/criticism.

#1 lore raw

PATCH 1/1 Likewise policy

Quoted 11 lines · Scott Salley
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+allow lwiod_t likewise_krb5_ad_t:file read_file_perms;
+allow lwiod_t netlogond_var_lib_t:file read_file_perms;
+
+corenet_tcp_bind_generic_node(lwiod_t)
+corenet_tcp_bind_smbd_port(lwiod_t)
+corenet_tcp_connect_smbd_port(lwiod_t)

The networking block is missing to interface calls to ensure compatibility.

Sorry, I don't understand the comment 'The networking block is missing...". Could you please explain?

SELinux supports some (optional) network controls. If you want your policy to work in an environment that implements these network controls you are required to make your policy compatible by adding those interface calls.

Quoted 9 lines
Quoted 7 lines

Review

Quoted 4 lines
(quoted diff) +3 -0
+allow lwsmd_t lwregd_t:process { signal siginh rlimitinh };
+allow lwsmd_t netlogond_t:process { signal siginh rlimitinh };
+allow lwsmd_t srvsvcd_t:process { signal siginh rlimitinh };

I suspect these can be removed. signal is already allowed and the other permissions are rarely needed.

Where is signal already allowed? (siginh and rlimitinh can certainly be removed).

+ allow $1 self:process { signal_perms getsched setsched };

It is included in the signal_perms permission set. (likewise.if)

Quoted 6 lines

Thank you for all the comments/advice/criticism.
_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100308/3b202aac/attachment.bin

#2 lore raw

PATCH 1/1 Likewise policy

Quoted 12 lines · Dominick Grift
Quoted 8 lines · Scott Salley
Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +3 -0
+allow lwsmd_t lwregd_t:process { signal siginh rlimitinh };
+allow lwsmd_t netlogond_t:process { signal siginh rlimitinh };
+allow lwsmd_t srvsvcd_t:process { signal siginh rlimitinh };

I suspect these can be removed. signal is already allowed and the other permissions are rarely needed.

Where is signal already allowed? (siginh and rlimitinh can certainly be removed).

(quoted diff) +1 -0
+	allow $1 self:process { signal_perms getsched setsched };
Quoted 1 line

It is included in the signal_perms permission set. (likewise.if)

Whoops my bad. That is to self and yours is to other domain types.

skip that comment please.

Quoted 8 lines
Quoted 6 lines

Thank you for all the comments/advice/criticism.
_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100308/1450dd94/attachment.bin