Skip to contentSkip to conversation

inotify: Don't leak user struct on inotify release

PATCH New Pavel Emelyanov 1 participant 1 message Mar 11, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 inotify: Don't leak user struct on inotify release

The inotify_new_group receives a get_uid-ed user_struct and saves the reference on group->inotify_data.user. The problem is that the free_uid is never called on it.

Issue seem to be introduced by 63c882a0 (inotify: reimplement inotify using fsnotify) after 2.6.30 (so stable is in Cc)

---

fs/notify/inotify/inotify_fsnotify.c +2 -0
index 1afb0a1..e27960c 100644
@@ -28,6 +28,7 @@
 #include <linux/path.h> /* struct path */
 #include <linux/slab.h> /* kmem_* */
 #include <linux/types.h>
+#include <linux/sched.h>
 
 #include "inotify.h"
 
@@ -146,6 +147,7 @@ static void inotify_free_group_priv(struct fsnotify_group *group)
 	idr_for_each(&group->inotify_data.idr, idr_callback, group);
 	idr_remove_all(&group->inotify_data.idr);
 	idr_destroy(&group->inotify_data.idr);
+	free_uid(group->inotify_data.user);
 }
 
 void inotify_free_event_priv(struct fsnotify_event_private_data *fsn_event_priv)