sky2: Avoid rtnl_unlock without rtnl_lock
Subsystems (2)
PATCH 1/1 sky2: Avoid rtnl_unlock without rtnl_lock
Make sure we always call rtnl_lock before going down the error path in sky2_resume, which unlocks the rtnl lock.
Signed-off-by Mike McCormack <[email protected]>
--- drivers/net/sky2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/sky2.c +1 -1
@@ -4863,6 +4863,7 @@ static int sky2_resume(struct pci_dev *pdev)if (!hw)return 0 ; +rtnl_lock (); err =pci_set_power_state (pdev,PCI_D0 );if (err) goto out;
@@ -4884,7 +4885,6 @@ static int sky2_resume(struct pci_dev *pdev)sky2_write32 (hw,B0_IMSK ,Y2_IS_BASE );napi_enable (&hw->napi); -rtnl_lock ();for (i =0 ; i < hw->ports; i++) { err =sky2_reattach (hw->dev[i]);if (err)
Signature · 1 line
1.5.6.5
From: Mike McCormack <[email protected]>
Date: Sat, 13 Mar 2010 08:11:47 +0900
Quoted 4 lines
Make sure we always call
rtnl_lockbefore going down the error path insky2_resume, which unlocks the rtnl lock.Signed-off-by Mike McCormack <[email protected]>
Applied, thanks Mike.