rqdm: remove superfluous irq disablement
PATCH 1/1 rqdm: remove superfluous irq disablement
Hi Alasdair,
This patch changes spin_lock_irq() to spin_lock() in dm_request_fn(). This patch is just a clean-up and no functional change. Made for 2.6.34-rc1.
Please review and apply.
The spin_lock_irq() was leftover from the early request-based dm code, where map_request() used to enable interrupts.
Since current map_request() never enable interrupts, we can change it to spin_lock() so to match with the prior spin_unlock().
Auditing through the dm and block-layer code called from map_request(), I confirmed all functions save/restore interrupt status, so no function returning with interrupts enabled. Also I haven't observed any problem on my test environment which uses scsi and lpfc driver after heavy I/O testing with occasional path down/up.
Added BUG_ON() to detect breakage in future.
--- drivers/md/dm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/md/dm.c +4 -2
@@ -1688,13 +1688,15 @@ static void dm_request_fn(struct requestif (map_request (ti, clone, md)) goto requeued; -spin_lock_irq (q->queue_lock); +BUG_ON (!irqs_disabled ()); +spin_lock (q->queue_lock); } goto out; requeued: -spin_lock_irq (q->queue_lock); +BUG_ON (!irqs_disabled ()); +spin_lock (q->queue_lock); plug_and_out:if (!elv_queue_empty (q))