drivers:misc: Kconfig, Makefile for TI's ST ldisc
patch below....
Quoted 163 lines
_______________________________________
From: Randy Dunlap [[email protected]]
Sent: Tuesday, March 23, 2010 3:15 AM
To: Savoy, Pavan
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 2/6] drivers:misc:Kconfig,Makefilefor TI's ST ldiscQuoted 46 lines · On 03/22/10 14:19, [email protected] wrote:
From: Pavan Savoy <[email protected]>
This change adds the
Kconfigand Make file for TI's ST line discipline driver and the BlueZ driver for BT core of the TI BT/FM/GPS combo chip.Signed-off-by Pavan Savoy <[email protected]>--- drivers/misc/Kconfig | 1 + drivers/misc/Makefile | 1 + drivers/misc/ti-st/Kconfig | 24 ++++++++++++++++++++++++ drivers/misc/ti-st/Makefile | 7 +++++++ 4 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 drivers/misc/ti-st/Kconfig create mode 100644 drivers/misc/ti-st/Makefiledrivers/misc/Kconfig +1
-0@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" source "drivers/misc/iwmc3200top/Kconfig" +source "drivers/misc/ti-st/Kconfig" endif # MISC_DEVICESdrivers/misc/Makefile +1
-0@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP) += iwmc3200top/ obj-$(CONFIG_HWLAT_DETECTOR) += hwlat_detector.o obj-y += eeprom/ obj-y += cb710/ +obj-y += ti-st/drivers/misc/ti-st/Kconfig new file +4
-0@@ -0,0 +1,24 @@ +# +# TI's shared transport line discipline and the protocol +# drivers (BT, FM and GPS) +#drivers/misc/ti-st/Kconfig line 14
Quoted 10 lines
drivers/misc/ti-st/Kconfig new file +10
-0+menu "Texas Instruments shared transport line discipline" + config TI_ST + tristate "shared transport core driver" + select FW_LOADER + help + This enables the shared transport core driver for TI + BT / FM and GPS combo chips.This enables protocol drivers + to register themselves with core and send data, the responses + are returned to relevant protocol drivers based on their + packet types.Please indent kconfig help text with one tab + 2 spaces.
drivers/misc/ti-st/Kconfig line 17
Quoted 3 lines
drivers/misc/ti-st/Kconfig new file +3
-0+ + config ST_BT + tristate "BlueZ bluetooth driver for ST"I'd be careful. There are some places in the kernel tree where ST means STMicroelectronics.
drivers/misc/ti-st/Kconfig line 18
Quoted 1 line
drivers/misc/ti-st/Kconfig new file +1
-0+ select BTThat select looks unsafe. You don't know that
CONFIG_NETis even enabled here, do you? Most drivers use "depends on BT" instead of "select BT" from my grepping.drivers/misc/ti-st/Kconfig line 21
Quoted 3 lines
drivers/misc/ti-st/Kconfig new file +3
-0+ select TI_ST + help + This enables the Bluetooth driver for TI BT/FM/GPS combo devicesEnd sentence with period.
drivers/misc/ti-st/Makefile line 3
Quoted 12 lines
drivers/misc/ti-st/Kconfig new file +3
-0+ This makes use of shared transport line discipline core driver to + communicate with the BT core of the combo chip. +endmenudrivers/misc/ti-st/Makefile new file +3
-0@@ -0,0 +1,7 @@ +# +# Makefile for TI's shared transport line discipline +# and it's protocol drivers (BT, FM, GPS)its
drivers/misc/ti-st/Makefile line 7
Quoted 4 lines
drivers/misc/ti-st/Makefile new file +4
-0+# +obj-$(CONFIG_TI_ST) += st_drv.o +st_drv-objs := st_core.o st_kim.o st_ll.o +obj-$(CONFIG_ST_BT) += bt_drv.o--
~RandyFrom
91b326a876066f0724f08957ee446f6b6bbed40eMon Sep 17 00:00:00 2001
From: Pavan Savoy <[email protected]>
Date: Mon, 22 Mar 2010 16:40:19 -0400
Subject: [PATCH 2/7] drivers:misc:Kconfig,Makefilefor TI's ST ldisc This change adds theKconfigand Make file for TI's
ST line discipline driver and the BlueZ driver for BT
core of the TI BT/FM/GPS combo chip.Signed-off-by Pavan Savoy <[email protected]>--- drivers/misc/Kconfig | 1 + drivers/misc/Makefile | 1 + drivers/misc/ti-st/Kconfig | 24 ++++++++++++++++++++++++ drivers/misc/ti-st/Makefile | 7 +++++++ 4 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 drivers/misc/ti-st/Kconfig create mode 100644 drivers/misc/ti-st/Makefiledrivers/misc/Kconfig +1
-0@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" source "drivers/misc/iwmc3200top/Kconfig" +source "drivers/misc/ti-st/Kconfig" endif # MISC_DEVICESdrivers/misc/Makefile +1
-0@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP) += iwmc3200top/ obj-$(CONFIG_HWLAT_DETECTOR) += hwlat_detector.o obj-y += eeprom/ obj-y += cb710/ +obj-y += ti-st/drivers/misc/ti-st/Kconfig new file +8
-0@@ -0,0 +1,24 @@ +# +# TI's shared transport line discipline and the protocol +# drivers (BT, FM and GPS) +# +menu "Texas Instruments shared transport line discipline" + config TI_ST + tristate "shared transport core driver" + select FW_LOADER
drivers/misc/ti-st/Kconfig line 18
Quoted 10 lines
drivers/misc/ti-st/Kconfig new file +10
-0+ help + This enables the shared transport core driver for TI + BT / FM and GPS combo chips.This enables protocol drivers + to register themselves with core and send data, the responses + are returned to relevant protocol drivers based on their + packet types. + + config ST_BT + tristate "BlueZ bluetooth driver for ST" + depends on BT
OK.
drivers/misc/ti-st/Kconfig line 23
Quoted 5 lines
drivers/misc/ti-st/Kconfig new file +5
-0+ select TI_ST + help + This enables the Bluetooth driver for TI BT/FM/GPS combo devices + This makes use of shared transport line discipline core driver to + communicate with the BT core of the combo chip.
There are no tabs above. They appear to have been eaten (assuming that they were there at some point).
drivers/misc/ti-st/Makefile line 3
Quoted 10 lines
drivers/misc/ti-st/Kconfig new file +1
-0+endmenudrivers/misc/ti-st/Makefile new file +3
-0@@ -0,0 +1,7 @@ +# +# Makefile for TI's shared transport line discipline +# and it's protocol drivers (BT, FM, GPS)
^^^^
should be "its"
Quoted 8 lines
drivers/misc/ti-st/Makefile new file +4
-0+# +obj-$(CONFIG_TI_ST) += st_drv.o +st_drv-objs := st_core.o st_kim.o st_ll.o +obj-$(CONFIG_ST_BT) += bt_drv.oPS:
If you still see problems with identation - blame my email editor (outlook express)
I guess that you'll need to do something about that.
Signature · 26 lines
~Randy [Pavan]>>>>>>>>>>>>>>> I suppose this should be fine ... From f12153a01e9f4a1ce2c381319fdfde60daeef461 Mon Sep 17 00:00:00 2001 From: Pavan Savoy <[email protected]> Date: Mon, 22 Mar 2010 16:40:19 -0400 Subject: [PATCH 2/7] drivers:misc: Kconfig, Makefile for TI's ST ldisc This change adds the Kconfig and Make file for TI's ST line discipline driver and the BlueZ driver for BT core of the TI BT/FM/GPS combo chip. Signed-off-by: Pavan Savoy <[email protected]> --- drivers/misc/Kconfig | 1 + drivers/misc/Makefile | 1 + drivers/misc/ti-st/Kconfig | 24 ++++++++++++++++++++++++ drivers/misc/ti-st/Makefile | 7 +++++++ 4 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 drivers/misc/ti-st/Kconfig create mode 100644 drivers/misc/ti-st/Makefile
drivers/misc/Kconfig +1 -0
@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" source "drivers/misc/iwmc3200top/Kconfig" +source "drivers/misc/ti-st/Kconfig" endif # MISC_DEVICES
drivers/misc/Makefile +1 -0
@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP) += iwmc3200top/ obj-$(CONFIG_HWLAT_DETECTOR) += hwlat_detector.o obj-y += eeprom/ obj-y += cb710/ +obj-y += ti-st/
drivers/misc/ti-st/Kconfig new file +24 -0
@@ -0,0 +1,24 @@ +# +# TI's shared transport line discipline and the protocol +# drivers (BT, FM and GPS) +# +menu "Texas Instruments shared transport line discipline" + config TI_ST + tristate "shared transport core driver" + select FW_LOADER + help + This enables the shared transport core driver for TI + BT / FM and GPS combo chips.This enables protocol drivers + to register themselves with core and send data, the responses + are returned to relevant protocol drivers based on their + packet types. + + config ST_BT + tristate "BlueZ bluetooth driver for ST" + depends on BT + select TI_ST + help + This enables the Bluetooth driver for TI BT/FM/GPS combo devices + This makes use of shared transport line discipline core driver to + communicate with the BT core of the combo chip. +endmenu
drivers/misc/ti-st/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# +# Makefile for TI's shared transport line discipline +# and its protocol drivers (BT, FM, GPS) +# +obj-$(CONFIG_TI_ST) += st_drv.o +st_drv-objs := st_core.o st_kim.o st_ll.o +obj-$(CONFIG_ST_BT) += bt_drv.o
Signature · 1 line
1.5.4.3
Quoted 3 lines · On Mon, 22 Mar 2010 18:45:42 -0500 Pavan Savoy wrote:
[Pavan]>>>>>>>>>>>>>>>
I suppose this should be fine ...
Well, almost there...
Quoted 57 lines
From
f12153a01e9f4a1ce2c381319fdfde60daeef461Mon Sep 17 00:00:00 2001
From: Pavan Savoy <[email protected]>
Date: Mon, 22 Mar 2010 16:40:19 -0400
Subject: [PATCH 2/7] drivers:misc:Kconfig,Makefilefor TI's ST ldiscThis change adds the
Kconfigand Make file for TI's ST line discipline driver and the BlueZ driver for BT core of the TI BT/FM/GPS combo chip.Signed-off-by Pavan Savoy <[email protected]>--- drivers/misc/Kconfig | 1 + drivers/misc/Makefile | 1 + drivers/misc/ti-st/Kconfig | 24 ++++++++++++++++++++++++ drivers/misc/ti-st/Makefile | 7 +++++++ 4 files changed, 33 insertions(+), 0 deletions(-)create mode 100644
drivers/misc/ti-st/Kconfig
create mode 100644drivers/misc/ti-st/Makefiledrivers/misc/Kconfig +1
-0@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" source "drivers/misc/iwmc3200top/Kconfig" +source "drivers/misc/ti-st/Kconfig" endif # MISC_DEVICESdrivers/misc/Makefile +1
-0@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP) += iwmc3200top/ obj-$(CONFIG_HWLAT_DETECTOR) += hwlat_detector.o obj-y += eeprom/ obj-y += cb710/ +obj-y += ti-st/drivers/misc/ti-st/Kconfig new file +11
-0@@ -0,0 +1,24 @@ +# +# TI's shared transport line discipline and the protocol +# drivers (BT, FM and GPS) +# +menu "Texas Instruments shared transport line discipline" + config TI_ST + tristate "shared transport core driver" + select FW_LOADER + help + This enables the shared transport core driver for TI + BT / FM and GPS combo chips.This enables protocol drivers
drivers/misc/ti-st/Kconfig line 21
Quoted 10 lines
drivers/misc/ti-st/Kconfig new file +10
-0+ to register themselves with core and send data, the responses + are returned to relevant protocol drivers based on their + packet types. + + config ST_BT + tristate "BlueZ bluetooth driver for ST" + depends on BT + select TI_ST + help + This enables the Bluetooth driver for TI BT/FM/GPS combo devices
End sentence with period (missed from first review comments).
But please fix all of the Kconfig file as documented in Documentation/CodingStyle, Chapter 10: Kconfig configuration files:
Lines under a "config" definition
are indented with one tab, while help text is indented an additional two spaces.
Quoted 10 lines
drivers/misc/ti-st/Kconfig new file +3
-0+ This makes use of shared transport line discipline core driver to + communicate with the BT core of the combo chip. +endmenudrivers/misc/ti-st/Makefile new file +0
-0
drivers/misc/ti-st/Makefile line 7
Quoted 7 lines
drivers/misc/ti-st/Makefile new file +7
-0@@ -0,0 +1,7 @@ +# +# Makefile for TI's shared transport line discipline +# and its protocol drivers (BT, FM, GPS) +# +obj-$(CONFIG_TI_ST) += st_drv.o +st_drv-objs := st_core.o st_kim.o st_ll.o +obj-$(CONFIG_ST_BT) += bt_drv.o
---
~Randy