Skip to contentSkip to conversation

drivers:misc: Kconfig, Makefile for TI's ST ldisc

PATCH Pavan Savoy 2 participants 2 messages Mar 23, 2010 Char and misc drivers

lore
Share & tools
lore
#0 lore raw
Quoted 74 lines · On Mon, 22 Mar 2010 18:45:42 -0500 Pavan Savoy wrote:

[Pavan]>>>>>>>>>>>>>>>
I suppose this should be fine ...

Well, almost there...

From f12153a01e9f4a1ce2c381319fdfde60daeef461 Mon Sep 17 00:00:00 2001
From: Pavan Savoy <[email protected]>
Date: Mon, 22 Mar 2010 16:40:19 -0400
Subject: [PATCH 2/7] drivers:misc: Kconfig, Makefile for TI's ST ldisc

This change adds the Kconfig and Make file for TI's ST line discipline driver and the BlueZ driver for BT core of the TI BT/FM/GPS combo chip.

---
  drivers/misc/Kconfig        |    1 +
  drivers/misc/Makefile       |    1 +
  drivers/misc/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
  drivers/misc/ti-st/Makefile |    7 +++++++
  4 files changed, 33 insertions(+), 0 deletions(-)

create mode 100644 drivers/misc/ti-st/Kconfig
create mode 100644 drivers/misc/ti-st/Makefile

drivers/misc/Kconfig +1 -0
index 625e3a6..c059bca 100644
@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig"
  source "drivers/misc/eeprom/Kconfig"
  source "drivers/misc/cb710/Kconfig"
  source "drivers/misc/iwmc3200top/Kconfig"
+source "drivers/misc/ti-st/Kconfig"
 
  endif # MISC_DEVICES
drivers/misc/Makefile +1 -0
index c221917..021f282 100644
@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP)      += iwmc3200top/
  obj-$(CONFIG_HWLAT_DETECTOR)        += hwlat_detector.o
  obj-y                               += eeprom/
  obj-y                               += cb710/
+obj-y                                += ti-st/
drivers/misc/ti-st/Kconfig new file +21 -0
new file mode 100644
index 0000000..fe5b0e8
@@ -0,0 +1,24 @@
+#
+# TI's shared transport line discipline and the protocol
+# drivers (BT, FM and GPS)
+#
+menu "Texas Instruments shared transport line discipline"
+    config TI_ST
+    tristate "shared transport core driver"
+    select FW_LOADER
+    help
+       This enables the shared transport core driver for TI
+       BT / FM and GPS combo chips.This enables protocol drivers
+       to register themselves with core and send data, the responses
+       are returned to relevant protocol drivers based on their
+       packet types.
+
+    config ST_BT
+    tristate "BlueZ bluetooth driver for ST"
+    depends on BT
+    select TI_ST
+    help
+       This enables the Bluetooth driver for TI BT/FM/GPS combo devices
Quoted 7 lines

End sentence with period (missed from first review comments).

But please fix all of the Kconfig file as documented in Documentation/CodingStyle, Chapter 10: Kconfig configuration files:

Lines under a "config" definition
are indented with one tab, while help text is indented an >additional two

spaces.

Quoted 18 lines
drivers/misc/ti-st/Kconfig new file +3 -0
+       This makes use of shared transport line discipline core driver to
+       communicate with the BT core of the combo chip.
+endmenu
drivers/misc/ti-st/Makefile new file +7 -2
new file mode 100644
index 0000000..ad9cff2
@@ -0,0 +1,7 @@
+#
+# Makefile for TI's shared transport line discipline
+# and its protocol drivers (BT, FM, GPS)
+#
+obj-$(CONFIG_TI_ST) += st_drv.o
+st_drv-objs                  := st_core.o st_kim.o st_ll.o
+obj-$(CONFIG_ST_BT) += bt_drv.o
--
---
Quoted 1 line

~Randy

[pavan]>>>>>>>
How about this ?

From 7304d21df4c11244651754976f662d301bef5361 Mon Sep 17 00:00:00 2001
From: Pavan Savoy <[email protected]>
Date: Mon, 22 Mar 2010 16:40:19 -0400
Subject: [PATCH 2/7] drivers:misc: Kconfig, Makefile for TI's ST ldisc

This change adds the Kconfig and Make file for TI's ST line discipline driver and the BlueZ driver for BT core of the TI BT/FM/GPS combo chip.

---
 drivers/misc/Kconfig        |    1 +
 drivers/misc/Makefile       |    1 +
 drivers/misc/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
 drivers/misc/ti-st/Makefile |    7 +++++++
 4 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/ti-st/Kconfig
 create mode 100644 drivers/misc/ti-st/Makefile
drivers/misc/Kconfig +1 -0
index 625e3a6..c059bca 100644
@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig"
 source "drivers/misc/eeprom/Kconfig"
 source "drivers/misc/cb710/Kconfig"
 source "drivers/misc/iwmc3200top/Kconfig"
+source "drivers/misc/ti-st/Kconfig"
 
 endif # MISC_DEVICES
drivers/misc/Makefile +1 -0
index c221917..021f282 100644
@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP)      += iwmc3200top/
 obj-$(CONFIG_HWLAT_DETECTOR)	+= hwlat_detector.o
 obj-y				+= eeprom/
 obj-y				+= cb710/
+obj-y				+= ti-st/
drivers/misc/ti-st/Kconfig new file +24 -0
new file mode 100644
index 0000000..55fc054
@@ -0,0 +1,24 @@
+#
+# TI's shared transport line discipline and the protocol
+# drivers (BT, FM and GPS)
+#
+menu "Texas Instruments shared transport line discipline"
+config TI_ST
+	tristate "shared transport core driver"
+	select FW_LOADER
+	help
+	  This enables the shared transport core driver for TI
+	  BT / FM and GPS combo chips.This enables protocol drivers
+	  to register themselves with core and send data, the responses
+	  are returned to relevant protocol drivers based on their
+	  packet types.
+
+config ST_BT
+	tristate "BlueZ bluetooth driver for ST"
+	depends on BT
+	select TI_ST
+	help
+	  This enables the Bluetooth driver for TI BT/FM/GPS combo devices.
+	  This makes use of shared transport line discipline core driver to
+	  communicate with the BT core of the combo chip.
+endmenu
drivers/misc/ti-st/Makefile new file +7 -0
new file mode 100644
index 0000000..0167d1d
@@ -0,0 +1,7 @@
+#
+# Makefile for TI's shared transport line discipline
+# and its protocol drivers (BT, FM, GPS)
+#
+obj-$(CONFIG_TI_ST) 		+= st_drv.o
+st_drv-objs			:= st_core.o st_kim.o st_ll.o
+obj-$(CONFIG_ST_BT) 		+= bt_drv.o
Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 30 lines · On Tue, 23 Mar 2010 10:10:35 -0500 Pavan Savoy wrote:

On Mon, 22 Mar 2010 18:45:42 -0500 Pavan Savoy wrote:

[pavan]>>>>>>>
How about this ?

From 7304d21df4c11244651754976f662d301bef5361 Mon Sep 17 00:00:00 2001
From: Pavan Savoy <[email protected]>
Date: Mon, 22 Mar 2010 16:40:19 -0400
Subject: [PATCH 2/7] drivers:misc: Kconfig, Makefile for TI's ST ldisc

This change adds the Kconfig and Make file for TI's ST line discipline driver and the BlueZ driver for BT core of the TI BT/FM/GPS combo chip.

---
  drivers/misc/Kconfig        |    1 +
  drivers/misc/Makefile       |    1 +
  drivers/misc/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
  drivers/misc/ti-st/Makefile |    7 +++++++
  4 files changed, 33 insertions(+), 0 deletions(-)

create mode 100644 drivers/misc/ti-st/Kconfig
create mode 100644 drivers/misc/ti-st/Makefile

drivers/misc/Kconfig +0 -0
index 625e3a6..c059bca 100644

drivers/misc/Kconfig source "drivers/misc/c2port/Kconfig" · line 347

Quoted 4 lines
drivers/misc/Kconfig +1 -0
@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig"
  source "drivers/misc/eeprom/Kconfig"
  source "drivers/misc/cb710/Kconfig"
  source "drivers/misc/iwmc3200top/Kconfig"
+source "drivers/misc/ti-st/Kconfig"

Too many spaces " " before "source" in the 3 preceding lines, so it does not apply cleanly. Same for the Makefile below.

Quoted 1 line

patch -p1 --dry-run < ~/misc-tist-kconfig.patch

patching file drivers/misc/Kconfig
Hunk #1 FAILED at 344.
1 out of 1 hunk FAILED -- saving rejects to file drivers/misc/Kconfig.rej patching file drivers/misc/Makefile
Hunk #1 FAILED at 30.
1 out of 1 hunk FAILED -- saving rejects to file drivers/misc/Makefile.rej patching file drivers/misc/ti-st/Kconfig
patching file drivers/misc/ti-st/Makefile

Quoted 18 lines

endif # MISC_DEVICES

drivers/misc/Makefile +1 -0
index c221917..021f282 100644
@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP)      += iwmc3200top/
  obj-$(CONFIG_HWLAT_DETECTOR)	+= hwlat_detector.o
  obj-y				+= eeprom/
  obj-y				+= cb710/
+obj-y				+= ti-st/
drivers/misc/ti-st/Kconfig new file +1 -0
new file mode 100644
index 0000000..55fc054
@@ -0,0 +1,24 @@
+#

drivers/misc/ti-st/Kconfig line 11

Quoted 10 lines
drivers/misc/ti-st/Kconfig new file +10 -0
+# TI's shared transport line discipline and the protocol
+# drivers (BT, FM and GPS)
+#
+menu "Texas Instruments shared transport line discipline"
+config TI_ST
+	tristate "shared transport core driver"
+	select FW_LOADER
+	help
+	  This enables the shared transport core driver for TI
+	  BT / FM and GPS combo chips.This enables protocol drivers

Sigh. Put a space after "chips."

drivers/misc/ti-st/Kconfig line 24

Quoted 13 lines
drivers/misc/ti-st/Kconfig new file +13 -0
+	  to register themselves with core and send data, the responses
+	  are returned to relevant protocol drivers based on their
+	  packet types.
+
+config ST_BT
+	tristate "BlueZ bluetooth driver for ST"
+	depends on BT
+	select TI_ST
+	help
+	  This enables the Bluetooth driver for TI BT/FM/GPS combo devices.
+	  This makes use of shared transport line discipline core driver to
+	  communicate with the BT core of the combo chip.
+endmenu

Aside from the typo above, this drivers/misc/ti-st/Kconfig file looks OK now.

Quoted 7 lines
drivers/misc/ti-st/Makefile new file +0 -0
new file mode 100644
index 0000000..0167d1d

drivers/misc/ti-st/Makefile line 7

Quoted 7 lines
drivers/misc/ti-st/Makefile new file +7 -0
@@ -0,0 +1,7 @@
+#
+# Makefile for TI's shared transport line discipline
+# and its protocol drivers (BT, FM, GPS)
+#
+obj-$(CONFIG_TI_ST) 		+= st_drv.o
+st_drv-objs			:= st_core.o st_kim.o st_ll.o
+obj-$(CONFIG_ST_BT) 		+= bt_drv.o

---
~Randy