DA8XX/OMAP-L1XX: FB: Implement double buffering
Hello.
Quoted 10 lines · Martin Ambrose
This work includes the following:
. Implement handler forFBIO_WAITFORVSYNCioctl.. Allocate the data and palette buffers separately.
A consequence of this is that the palette and data loading is now done in different phases. And that the LCD must be disabled temporarily after the palette is loaded but this will only happen once after init and each time the palette is changed. I think this is OK.
Quoted 7 lines
. Allocate two (ping and pong) framebuffers from memory.
. Add
pan_displayhandler which toggles the LCDC DMA registers between
the ping and pong buffers.Signed-off-by Martin Ambrose <[email protected]>
Just a quick comment on code formatting...
drivers/video/da8xx-fb.c line 41
Quoted 12 lines
drivers/video/da8xx-fb.c +2
-0@@ -35,7 +35,9 @@#define DRIVER_NAME "da8xx_lcdc"/* LCD Status Register */ +#define LCD_END_OF_FRAME1 BIT(9)#define LCD_END_OF_FRAME0 BIT(8) +#define LCD_PL_LOAD_DONE BIT(6)
Could you use tabs consistently?
Quoted 5 lines
drivers/video/da8xx-fb.c +0
-0#define LCD_FIFO_UNDERFLOW BIT(5)#define LCD_SYNC_LOST BIT(2)@@ -57,11 +59,13 @@#define LCD_PALETTE_LOAD_MODE (x) ((x) << 20)
drivers/video/da8xx-fb.c line 69
Quoted 10 lines
drivers/video/da8xx-fb.c +2
-0#define PALETTE_AND_DATA 0x00#define PALETTE_ONLY 0x01 +#define DATA_ONLY 0x02#define LCD_MONO_8BIT_MODE BIT(9)#define LCD_RASTER_ORDER BIT(8)#define LCD_TFT_MODE BIT(7)#define LCD_UNDERFLOW_INT_ENA BIT(6) +#define LCD_PL_ENABLE BIT(4)
Same here...
WBR, Sergei
Sergei,
Quoted 50 lines
-----Original Message-----
From: Sergei Shtylyov [mailto:[email protected]]
Sent: Wednesday, March 24, 2010 9:53 AMQuoted 10 lines · Martin Ambrose
This work includes the following:
. Implement handler forFBIO_WAITFORVSYNCioctl.. Allocate the data and palette buffers separately.
A consequence of this is that the palette and data loading is now done in different phases. And that the LCD must be disabled temporarily after the palette is loaded but this will only happen once after init and each time the palette is changed. I think this is OK.Quoted 7 lines
. Allocate two (ping and pong) framebuffers from memory.
. Add
pan_displayhandler which toggles the LCDC DMA registers between
the ping and pong buffers.Signed-off-by Martin Ambrose <[email protected]>Just a quick comment on code formatting...
drivers/video/da8xx-fb.c line 41
Quoted 12 lines
drivers/video/da8xx-fb.c +2
-0@@ -35,7 +35,9 @@#define DRIVER_NAME "da8xx_lcdc"/* LCD Status Register */ +#define LCD_END_OF_FRAME1 BIT(9)#define LCD_END_OF_FRAME0 BIT(8) +#define LCD_PL_LOAD_DONE BIT(6)Could you use tabs consistently?
Quoted 9 lines
drivers/video/da8xx-fb.c +1
-0#define LCD_FIFO_UNDERFLOW BIT(5)#define LCD_SYNC_LOST BIT(2)@@ -57,11 +59,13 @@#define LCD_PALETTE_LOAD_MODE (x) ((x) << 20)#define PALETTE_AND_DATA 0x00#define PALETTE_ONLY 0x01 +#define DATA_ONLY 0x02
Quoted 8 lines
drivers/video/da8xx-fb.c line 69
Quoted 6 lines
drivers/video/da8xx-fb.c +1
-0#define LCD_MONO_8BIT_MODE BIT(9)#define LCD_RASTER_ORDER BIT(8)#define LCD_TFT_MODE BIT(7)#define LCD_UNDERFLOW_INT_ENA BIT(6) +#define LCD_PL_ENABLE BIT(4)Same here...
Thanks. I fixed and I'll be sending out a rev 2 shortly.
Regards,
Martin
Quoted 1 line
WBR, Sergei