Skip to contentSkip to conversation

btrfs: Calculate member variant's address directly for btrfs_set_##name

PATCH In review Miao Xie 1 participant 1 message Mar 25, 2010 Btrfs file system

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 3/18 btrfs: Calculate member variant's address directly for btrfs_set_##name

From: Zhao Lei <[email protected]>

It can decrease a additional address calculation and increase little speed.

---
 fs/btrfs/struct-funcs.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
fs/btrfs/struct-funcs.c +5 -5
index b0f80c0..4ec8055 100644
@@ -86,13 +86,13 @@ void btrfs_set_##name(struct extent_buffer *eb,				\
 {									\
 	unsigned long part_offset = (unsigned long)s;			\
 	unsigned long offset = part_offset + offsetof(type, member);	\
-	type *p;							\
+	u##bits *p;							\
 	/* ugly, but we want the fast path here */			\
 	if (eb->map_token && offset >= eb->map_start &&			\
 	    offset + sizeof(((type *)0)->member) <= eb->map_start +	\
 	    eb->map_len) {						\
-		p = (type *)(eb->kaddr + part_offset - eb->map_start);	\
-		p->member = cpu_to_le##bits(val);			\
+		p = (u##bits *)(eb->kaddr + offset - eb->map_start);	\
+		*p = cpu_to_le##bits(val);				\
 		return;							\
 	}								\
 	{								\
@@ -112,8 +112,8 @@ void btrfs_set_##name(struct extent_buffer *eb,				\
 			write_eb_member(eb, s, type, member, &val2);	\
 			return;						\
 		}							\
-		p = (type *)(kaddr + part_offset - map_start);		\
-		p->member = cpu_to_le##bits(val);			\
+		p = (u##bits *)(kaddr + offset - map_start);		\
+		*p = cpu_to_le##bits(val);				\
 		if (unmap_on_exit)					\
 			unmap_extent_buffer(eb, map_token, KM_USER1);	\
 	}								\
Signature · 1 line
1.6.5.2