Skip to contentSkip to conversation

btrfs: Fix a BUG_ON boundary typo

PATCH In review Miao Xie 1 participant 1 message Mar 25, 2010 Btrfs file system

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 7/18 btrfs: Fix a BUG_ON boundary typo

From: Zhao Lei <[email protected]>

logical's value should be [em->start, em->start + em->len), so we need to use
BUG_ON(em->start > logical || em->start + em->len <= logical);
instead of
BUG_ON(em->start > logical || em->start + em->len < logical);

---
 fs/btrfs/volumes.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/btrfs/volumes.c +2 -2
index 9df8e3f..844c393 100644
@@ -2598,7 +2598,7 @@ int btrfs_num_copies(struct btrfs_mapping_tree *map_tree, u64 logical, u64 len)
 	read_unlock(&em_tree->lock);
 	BUG_ON(!em);
 
-	BUG_ON(em->start > logical || em->start + em->len < logical);
+	BUG_ON(em->start > logical || em->start + em->len <= logical);
 	map = (struct map_lookup *)em->bdev;
 	if (map->type & (BTRFS_BLOCK_GROUP_DUP | BTRFS_BLOCK_GROUP_RAID1))
 		ret = map->num_stripes;
@@ -2673,7 +2673,7 @@ again:
 		BUG();
 	}
 
-	BUG_ON(em->start > logical || em->start + em->len < logical);
+	BUG_ON(em->start > logical || em->start + em->len <= logical);
 	map = (struct map_lookup *)em->bdev;
 	offset = logical - em->start;
 
Signature · 1 line
1.6.5.2