Skip to contentSkip to conversation

btrfs-progs: Avoid uninitialized variant compile warning

PATCH New Miao Xie 1 participant 1 message Mar 25, 2010 Btrfs file system

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 2/3 btrfs-progs: Avoid uninitialized variant compile warning

From: Zhao Lei <[email protected]>

When we compile btrfs-progs in RHEL5(with default gcc version 4.1.2 20070626), we can get following error:

cc1: warnings being treated as errors
btrfs-list.c: In function 'find_updated_files':
btrfs-list.c:668: warning: 'disk_offset' may be used uninitialized in this function btrfs-list.c:667: warning: 'disk_start' may be used uninitialized in this function btrfs-list.c:666: warning: 'len' may be used uninitialized in this function
make: *** [btrfs-list.o] Error 1

These varient are always initialized except inconsistent data in file system. We can set initial value for these variant for this situation.

---
 btrfs-list.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
btrfs-list.c +3 -3
index 9dedb5d..112bed2 100644
@@ -663,9 +663,9 @@ static int print_one_extent(int fd, struct btrfs_ioctl_search_header *sh,
 			    char **cache_dir_name, u64 *cache_ino,
 			    char **cache_full_name)
 {
-	u64 len;
-	u64 disk_start;
-	u64 disk_offset;
+	u64 len = 0;
+	u64 disk_start = 0;
+	u64 disk_offset = 0;
 	u8 type;
 	int compressed = 0;
 	int flags = 0;
Signature · 1 line
1.6.5.2