Skip to contentSkip to conversation

rcu: remove needless struct notifier_block predeclaration

PATCH In review Lai Jiangshan 2 participants 2 messages Mar 29, 2010 RCU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: remove needless struct notifier_block predeclaration

cleanup: remove needless struct notifier_block predeclaration

include/linux/rcutiny.h +0 -2
index a519587..ae7b05e 100644
@@ -86,8 +86,6 @@ static inline void synchronize_rcu_bh_expedited(void)
 	synchronize_sched();
 }
 
-struct notifier_block;
-
 #ifdef CONFIG_NO_HZ
 
 extern void rcu_enter_nohz(void);
include/linux/rcutree.h +0 -2
index 42cc3a0..3be62e1 100644
@@ -30,8 +30,6 @@
 #ifndef __LINUX_RCUTREE_H
 #define __LINUX_RCUTREE_H
 
-struct notifier_block;
-
 extern void rcu_sched_qs(int cpu);
 extern void rcu_bh_qs(int cpu);
 extern int rcu_needs_cpu(int cpu);
#1 lore raw
Quoted 2 lines · Lai Jiangshan

cleanup: remove needless struct notifier_block predeclaration

Good catch!

These forward declarations used to be essential. ;-)

If they have been made available on purpose, I am all for applying this patch. But if their appearance is accidental, perhaps to disappear again in the next release, I would keep the forward declarations.

Could you please check?

Thanx, Paul

Quoted 31 lines
include/linux/rcutiny.h +0 -2
index a519587..ae7b05e 100644
@@ -86,8 +86,6 @@ static inline void synchronize_rcu_bh_expedited(void)
 	synchronize_sched();
 }
 
-struct notifier_block;
-
 #ifdef CONFIG_NO_HZ
 
 extern void rcu_enter_nohz(void);
include/linux/rcutree.h +0 -3
index 42cc3a0..3be62e1 100644
@@ -30,8 +30,6 @@
 #ifndef __LINUX_RCUTREE_H
 #define __LINUX_RCUTREE_H
 
-struct notifier_block;
-
 extern void rcu_sched_qs(int cpu);
 extern void rcu_bh_qs(int cpu);
 extern int rcu_needs_cpu(int cpu);
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/