Skip to contentSkip to conversation

Linux 2.6.34-rc3

DISCUSSION Larry Finger 4 participants 6 messages Mar 30, 2010 – Apr 4, 2010

lore
Share & tools
lore
#0 lore raw

Remember our old friend? See also
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02769.html and a long related discussion at
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02772.html.

BUG: key ffff8800374d2660 not in .data!
------------[ cut here ]------------
WARNING: at kernel/lockdep.c:2706 lockdep_init_map+0x236/0x5d0()
Hardware name: HP Pavilion dv2700 Notebook PC
Modules linked in: processor(+) ide_pci_generic amd74xx ide_core thermal
Pid: 612, comm: modprobe Not tainted 2.6.34-rc3-Linus #192
Call Trace:
 [<ffffffff81046168>] warn_slowpath_common+0x78/0xb0
 [<ffffffff810461af>] warn_slowpath_null+0xf/0x20
 [<ffffffff810772c6>] lockdep_init_map+0x236/0x5d0
 [<ffffffff811649aa>] sysfs_add_file_mode+0x6a/0xc0
 [<ffffffff811acaa0>] ? sprintf+0x40/0x50
 [<ffffffff81164a0c>] sysfs_add_file+0xc/0x10
 [<ffffffff81164ae1>] sysfs_create_file+0x21/0x30
 [<ffffffff81247cc4>] device_create_file+0x14/0x20
 [<ffffffff8126d7d4>] thermal_zone_bind_cooling_device+0x1c4/0x310

-- dump truncated here --

I understand that you do not want a whole set of such "fix one such bug at a time" patches, but the bottom line is that these lockdep warnings for known problems interfere with "normal" debugging because further lockdep checking is disabled. I do not feel qualified to detect other cases and fix them. Only when a warning hits my logs am I qualified to fix and test.

Larry

#1 lore raw
Quoted 3 lines

Remember our old friend? See also
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02769.html and a long

There is a patch available:

https://patchwork.kernel.org/patch/87436/
(or https://bugzilla.kernel.org/show_bug.cgi?id=15548)

Seems it was jussed missed.

Quoted 2 lines

related discussion at
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02772.html.

The firmware bug should be gone, but there is also

https://patchwork.kernel.org/patch/87359/

pointing out a few more potential issues. I will resend it without the thermal_sys-part and hope I'll get some comments.

Kind regards,

Wolfram

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#2 lore raw
Quoted 14 lines · Wolfram Sang
Quoted 3 lines

Remember our old friend? See also
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02769.html and a long

There is a patch available:

https://patchwork.kernel.org/patch/87436/
(or https://bugzilla.kernel.org/show_bug.cgi?id=15548)

Seems it was jussed missed.

Quoted 2 lines

related discussion at
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02772.html.

Quoted 6 lines

The firmware bug should be gone, but there is also

https://patchwork.kernel.org/patch/87359/

pointing out a few more potential issues. I will resend it without the thermal_sys-part and hope I'll get some comments.

Glad to hear that these will soon be fixed.

Larry

#3 lore raw
In reply to Larry Finger
Quoted 6 lines · Larry Finger

I understand that you do not want a whole set of such "fix one such bug at a time" patches, but the bottom line is that these lockdep warnings for known problems interfere with "normal" debugging because further lockdep checking is disabled. I do not feel qualified to detect other cases and fix them. Only when a warning hits my logs am I qualified to fix and test.

I'd actually like the owner for this to send me the patches - I don't go out downloading things from patchwork, and quite frankly, I was expecting Eric Biederman to follow up on these issues, since that's where the new requirements came from. Maybe the patches are already waiting in Greg's tree or something?

But if people are just waiting around for others to take them, if somebody who has tracked this issue (hint hint, Larry) sends me the final patches, I can take them that way too.

Linus

#4 lore raw
Quoted 2 lines · Linus Torvalds

requirements came from. Maybe the patches are already waiting in Greg's tree or something?

Andrew picked them up meanwhile.

Regards,

Wolfram

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#5 lore raw
Quoted 6 lines · Wolfram Sang
Quoted 2 lines · Linus Torvalds

requirements came from. Maybe the patches are already waiting in Greg's tree or something?

Andrew picked them up meanwhile.

And I have them as well, Linus will get them in a few days also, when I catch up with my queue.

thanks,

greg k-h