Skip to contentSkip to conversation

drm: build error when magic sysrq isn't enabled

PATCH New Changli Gao 1 participant 1 message Mar 31, 2010

Subsystems (3)
DRM drivers DRM misc Linux-next tree
lore
Share & tools
lore

Changli Gao

author
#0 lore raw

PATCH 1/1 drm: build error when magic sysrq isn't enabled

drm build error when magic sysrq isn't enabled

sysrq_drm_fb_helper_restore_op is only valid when magic sysrq is enabled, but it is used whenever magic sysrq is enabled or not.

Signed-off-by Changli Gao <[email protected]>

----
drivers/gpu/drm/drm_fb_helper.c | 4 ++++

1 file changed, 4 insertions(+)
drivers/gpu/drm/drm_fb_helper.c +4 -0
index 85cdf05..0e5b4f6 100644
@@ -913,7 +913,9 @@ int drm_fb_helper_single_fb_probe(struct drm_device *dev,
 		printk(KERN_INFO "registered panic notifier\n");
 		atomic_notifier_chain_register(&panic_notifier_list,
 					       &paniced);
+#ifdef CONFIG_MAGIC_SYSRQ
 		register_sysrq_key('v', &sysrq_drm_fb_helper_restore_op);
+#endif
 	}
 	list_add(&fb_helper->kernel_fb_list, &kernel_fb_helper_list);
 	return 0;

@@ -927,7 +929,9 @@ void drm_fb_helper_free(struct drm_fb_helper *helper)
 		printk(KERN_INFO "unregistered panic notifier\n");
 		atomic_notifier_chain_unregister(&panic_notifier_list,
 						 &paniced);
+#ifdef CONFIG_MAGIC_SYSRQ
 		unregister_sysrq_key('v', &sysrq_drm_fb_helper_restore_op);
+#endif
 	}
 	drm_fb_helper_crtc_free(helper);
 	fb_dealloc_cmap(&helper->fb->fbdev->cmap);