Skip to contentSkip to conversation

mke2fs: be explicit if external journal device is not found

PATCH Applied Eric Sandeen 2 participants 2 messages Apr 1, 2010 – May 12, 2010

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 mke2fs: be explicit if external journal device is not found

This for RH bug #572935 -
RFE: Misleading error message from mke2fs -J option

If the journal device UUID is typo'd or otherwise not found, the error message looks like it's a usage() type of problem.

It'd be helpful to explicitly say that the device requested could not be found.

Signed-off-by Eric Sandeen <[email protected]>

---

misc/util.c +4 -0
index b8a3cac..51bdb60 100644
@@ -207,6 +207,10 @@ void parse_journal_opts(const char *opts)
 		if (strcmp(token, "device") == 0) {
 			journal_device = blkid_get_devname(NULL, arg, NULL);
 			if (!journal_device) {
+				if (arg)
+					fprintf(stderr, _("\nCould not find "
+						"journal device matching %s\n"),
+						arg);
 				journal_usage++;
 				continue;
 			}
Applied
#1 lore raw
Quoted 2 lines · Eric Sandeen

This for RH bug #572935 -
RFE: Misleading error message from mke2fs -J option

Applied into the e2fsprogs maint branch, thanks.

- Ted