ath9k compilation error

DISCUSSION Torquil Macdonald Sørensen 2 participants 4 messages Apr 12, 2010

Share & tools

Torquil Macdonald Sørensen

author

2010-04-12 10:00 UTC #0 lore raw

Hi!

I hope this is the right place to report this. If not, I would appreciate directions to the correct mailing list. In that case, sorry for spamming! :-)

I'm getting an error when compiling the ath9k driver in compat-wireless-2010-04-11. The version 2010-04-04 compiles fine after fixing a simple

First I do:

./scripts/driver-select ath9k

The I run "make", and after some time I get the following:

CC [M] /home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o
/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c: In function ‘ieee80211_alloc_hw’:
/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c:394: error: implicit declaration of function ‘__hw_addr_init’ make[5]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o] Error 1
make[4]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211] Error 2
make[3]: *** [_module_/home/tmac/src/compat-wireless-2010-04-11] Error 2
make[2]: *** [sub-make] Error 2

I want to try the newest driver because I have a lot of dropout problems when using my "Atheros Communications Inc. AR9285 Wireless Network Adapter (PCI-Express) (rev 01)"

gcc (Debian 4.4.3-7) 4.4.3

Best regards
Torquil Sørensen

Luis R. Rodriguez

2010-04-12 19:22 UTC #1 lore raw

Quoted 5 lines · Torquil Macdonald Sørensen

Hi!
I hope this is the right place to report this. If not, I would appreciate directions to the correct mailing list. In that case, sorry for spamming! :-)

This is the right list indeed.

Quoted 23 lines

I'm getting an error when compiling the ath9k driver in compat-wireless-2010-04-11. The version 2010-04-04 compiles fine after fixing a simple
First I do:
./scripts/driver-select ath9k
The I run "make", and after some time I get the following:
CC [M] /home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o /home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c: In function ‘ieee80211_alloc_hw’:
/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c:394: error:
implicit declaration of function ‘__hw_addr_init’
make[5]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o] Error 1
make[4]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211] Error 2
make[3]: *** [_module_/home/tmac/src/compat-wireless-2010-04-11] Error 2 make[2]: *** [sub-make] Error 2

Quoted 5 lines

I want to try the newest driver because I have a lot of dropout problems when using my "Atheros Communications Inc. AR9285 Wireless Network Adapter (PCI-Express) (rev 01)"
gcc (Debian 4.4.3-7) 4.4.3

What kernel version are you on?

Luis

Torquil Macdonald Sørensen

author

2010-04-12 20:06 UTC #2 lore raw

Quoted 24 lines · Luis R. Rodriguez

On Mon, Apr 12, 2010 at 3:00 AM, Torquil Macdonald Sørensen
Quoted 23 lines
I'm getting an error when compiling the ath9k driver in compat-wireless-2010-04-11. The version 2010-04-04 compiles fine after fixing a simple
First I do:
./scripts/driver-select ath9k
The I run "make", and after some time I get the following:
CC [M] /home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o
/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c: In function ‘ieee80211_alloc_hw’:
/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c:394: error:
implicit declaration of function ‘__hw_addr_init’
make[5]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o] Error 1
make[4]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211] Error 2
make[3]: *** [_module_/home/tmac/src/compat-wireless-2010-04-11] Error 2 make[2]: *** [sub-make] Error 2

Quoted 8 lines

Quoted 5 lines
I want to try the newest driver because I have a lot of dropout problems when using my "Atheros Communications Inc. AR9285 Wireless Network Adapter (PCI-Express) (rev 01)"
gcc (Debian 4.4.3-7) 4.4.3
What kernel version are you on?

Hi Luis!

tmac@asus ~$ uname -a
Linux asus 2.6.32-3-amd64 #1 SMP Wed Feb 24 18:07:42 UTC 2010 x86_64 GNU/Linux

It is from the Debian package linux-image-2.6.32-3-amd64, with Debian version number 2.6.32-9. At the same time I have the corresponding kernel header packages installed:

linux-headers-2.6.32-3-common (Debian version 2.6.32-9) linux-headers-2.6.32-3-amd64 (Debian version 2.6.32-9)

Torquil

Luis R. Rodriguez

Reviewed-by Jiri Pirko

2010-04-12 21:59 UTC #3 lore raw

Quoted 46 lines · Torquil Macdonald Sørensen

Quoted 29 lines · Luis R. Rodriguez
On Mon, Apr 12, 2010 at 3:00 AM, Torquil Macdonald Sørensen
Quoted 27 lines
I'm getting an error when compiling the ath9k driver in compat-wireless-2010-04-11. The version 2010-04-04 compiles fine after fixing a simple
First I do:
./scripts/driver-select ath9k
The I run "make", and after some time I get the following:
CC [M] /home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o /home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c: In function
‘ieee80211_alloc_hw’:
/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.c:394: error:
implicit declaration of function ‘__hw_addr_init’
make[5]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211/main.o] Error 1
make[4]: *** [/home/tmac/src/compat-wireless-2010-04-11/net/mac80211] Error
2
make[3]: *** [_module_/home/tmac/src/compat-wireless-2010-04-11] Error 2 make[2]: *** [sub-make] Error 2
Quoted 9 lines
Quoted 6 lines
I want to try the newest driver because I have a lot of dropout problems when using my "Atheros Communications Inc. AR9285 Wireless Network Adapter
(PCI-Express) (rev 01)"
gcc (Debian 4.4.3-7) 4.4.3
What kernel version are you on?
Hi Luis!
tmac@asus ~$ uname -a
Linux asus 2.6.32-3-amd64 #1 SMP Wed Feb 24 18:07:42 UTC 2010 x86_64 GNU/Linux

Quoted 6 lines

It is from the Debian package linux-image-2.6.32-3-amd64, with Debian version number 2.6.32-9. At the same time I have the corresponding kernel header packages installed:
linux-headers-2.6.32-3-common (Debian version 2.6.32-9) linux-headers-2.6.32-3-amd64 (Debian version 2.6.32-9)

OK so I checked this and the problems is these two patches on linux-next:

commit 2f787b0b76bf5de2eaa3ca3a29d89123ae03c856

Author: YOSHIFUJI Hideaki / 吉藤英明 <[email protected]>
Date:   Sun Apr 4 17:59:30 2010 +0000

mac80211: Ensure initializing private mc_list in prepare_multicast().

Fix kernel panic by NULL pointer dereference in the context of ieee80211_ops->prepare_multicast().

This bug was introduced by commit 22bedad3c.. ("net: convert multicast list to list_head").

Call __hw_addr_init() in ieee80211_alloc_hw() to initialize list_head of private device multicast list, like we do in bond_init().

Signed-off-by YOSHIFUJI Hideaki <[email protected]>

Reviewed-by Jiri Pirko <[email protected]>

Signed-off-by David S. Miller <[email protected]>

Author: Jiri Pirko <[email protected]>
Date:   Thu Apr 1 21:22:57 2010 +0000

net: convert multicast list to list_head

Converts the list and the core manipulating with it to be the same
as uc_list.

+uses two functions for adding/removing mc address (normal and "global"
variant) instead of a function parameter.
+removes dev_mcast.c completely.
+exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
manipulation with lists on a sandbox (used in bonding and 80211 drivers)

Signed-off-by Jiri Pirko <[email protected]>

Signed-off-by David S. Miller <[email protected]>

I don't have time to address this at the moment but reverting it should do it for you for now. I welcome someone else's patch if they get to it first.

Luis