Skip to contentSkip to conversation

igbvf: dobule increment nr_frags

PATCH Superseded Koki Sanagi 2 participants 2 messages Apr 15, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 igbvf: dobule increment nr_frags

There is no need to increment nr_frags becasue skb_fill_page_desc increments it.

---
 drivers/net/igbvf/netdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/igbvf/netdev.c +1 -1
index ea8abf5..97cfc60 100644
@@ -288,7 +288,7 @@ static bool igbvf_clean_rx_irq(struct igbvf_adapter *adapter,
 			               PCI_DMA_FROMDEVICE);
 			buffer_info->page_dma = 0;
 
-			skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+			skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
 			                   buffer_info->page,
 			                   buffer_info->page_offset,
 			                   length);
#1 lore raw

2010/4/15 Koki Sanagi <[email protected]>:

Quoted 8 lines

There is no need to increment nr_frags becasue skb_fill_page_desc increments it.

---
 drivers/net/igbvf/netdev.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)

Thanks I have added this patch to my queue of patches.

Signature · 14 lines
Cheers,
Jeff

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired