Skip to contentSkip to conversation

igb: dobule increment nr_frags

PATCH RESEND In review Koki Sanagi 2 participants 2 messages Apr 15, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Koki Sanagi

author
#0 lore raw

PATCH RESEND 1/2 igb: dobule increment nr_frags

Previous patch has some mail format problem.
Maybe I've fixed and re-sent.

There is no need to increment nr_frags becasue skb_fill_page_desc increments it.

Signed-off-by Koki Sanagi <[email protected]>
---
 drivers/net/igb/igb_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/igb/igb_main.c +1 -1
index 78cc742..8bde6c3 100644
@@ -5254,7 +5254,7 @@ static bool igb_clean_rx_irq_adv(struct igb_q_vector *q_vector,
 				       PAGE_SIZE / 2, PCI_DMA_FROMDEVICE);
 			buffer_info->page_dma = 0;
 
-			skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+			skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
 						buffer_info->page,
 						buffer_info->page_offset,
 						length);
#1 lore raw
Quoted 11 lines · Koki Sanagi

Previous patch has some mail format problem.
Maybe I've fixed and re-sent.

There is no need to increment nr_frags becasue skb_fill_page_desc increments it.

Signed-off-by Koki Sanagi <[email protected]>

---
 drivers/net/igb/igb_main.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, I have added the patch to my queue of patches.

Signature · 2 lines
Cheers,
Jeff