Skip to contentSkip to conversation

kvm: do not need hardware_disable when CPU_UP_CANCELED

PATCH Applied Lai Jiangshan 2 participants 2 messages Apr 17, 2010 – Apr 21, 2010 KVM

lore
Share & tools
lore

Lai Jiangshan

author
#0 lore raw

PATCH 1/1 kvm: do not need hardware_disable when CPU_UP_CANCELED

When CPU_UP_CANCELED, hardware_enable() has not been called at the CPU which is going up because raw_notifier_call_chain(CPU_ONLINE) has not been called for this cpu.

Signed-off-by Lai Jiangshan <[email protected]>

---

virt/kvm/kvm_main.c +0 -5
index 5a0cd19..b03f863 100644
@@ -1921,11 +1921,6 @@ static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val,
 		       cpu);
 		hardware_disable(NULL);
 		break;
-	case CPU_UP_CANCELED:
-		printk(KERN_INFO "kvm: disabling virtualization on CPU%d\n",
-		       cpu);
-		smp_call_function_single(cpu, hardware_disable, NULL, 1);
-		break;
 	case CPU_ONLINE:
 		printk(KERN_INFO "kvm: enabling virtualization on CPU%d\n",
 		       cpu);
Applied
#1 lore raw
Quoted 4 lines · Lai Jiangshan

When CPU_UP_CANCELED, hardware_enable() has not been called at the CPU which is going up because raw_notifier_call_chain(CPU_ONLINE) has not been called for this cpu.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function