trivial: use (C) instead of \251
PATCH 1/1 trivial: use (C) instead of \251
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
---
I'm not really sure this would survive transport over mail in appliable form, attaching the patch too just in case.
kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/perf_event.c +1 -1
@@ -4,7 +4,7 @@* Copyright (C) 2008 Thomas Gleixner <[email protected]> * Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar * Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <[email protected]> -* Copyright © 2009 Paul Mackerras, IBM Corp. <[email protected]> +* Copyright (C) 2009 Paul Mackerras, IBM Corp. <[email protected]> * * For licensing details see kernel-base/COPYING */
Subject: [PATCH] trivial: use (C) instead of \251
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
--- kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/perf_event.c +1 -1
@@ -4,7 +4,7 @@* Copyright (C) 2008 Thomas Gleixner <[email protected]> * Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar * Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <[email protected]> -* Copyright � 2009 Paul Mackerras, IBM Corp. <[email protected]> +* Copyright (C) 2009 Paul Mackerras, IBM Corp. <[email protected]> * * For licensing details see kernel-base/COPYING */
Quoted 3 lines · Tejun Heo
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Why do we need anything there at all?
Signature · 1 line
Hilsen Harald.
Quoted 7 lines · Harald Arnesen
Quoted 3 lines · Tejun Heo
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Why do we need anything there at all?
We don't necessarily need it but it's also pretty rude to strip other's copyright notices and other entries use (C), so.... :-)
Signature · 1 line
tejun
Quoted 9 lines · Tejun Heo
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Signed-off-by Tejun Heo <[email protected]>Cc Paul Mackerras <[email protected]>---
I'm not really sure this would survive transport over mail in appliable form, attaching the patch too just in case.
It didn't survive :) But it was easy enough to fix by hand. Applied, thanks Tejun.
Quoted 17 lines
kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/perf_event.c +1
-1@@ -4,7 +4,7 @@* Copyright (C) 2008 Thomas Gleixner <[email protected]> * Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar * Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <[email protected]> -* Copyright © 2009 Paul Mackerras, IBM Corp. <[email protected]> +* Copyright (C) 2009 Paul Mackerras, IBM Corp. <[email protected]> * * For licensing details see kernel-base/COPYING */
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
Quoted 10 lines · Ingo Molnar
Quoted 10 lines
Quoted 9 lines
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Signed-off-by Tejun Heo <[email protected]>Cc Paul Mackerras <[email protected]>---
I'm not really sure this would survive transport over mail in appliable form, attaching the patch too just in case.
Quoted 7 lines
Quoted 2 lines
It didn't survive :) But it was easy enough to fix by hand. Applied, thanks Tejun.
NAK.
A similar patch was sent a few weeks ago, it was objected to and rejected - the copyright character was used for legal reasons.
Well, Paul himself stated that according to their lawyer department, "Copyright" (which is there) is enough. So it made sense to remove invalid (at least in some sense) character.
Also zillion of other files copyrighted by Paul contain "Copyright (C)".
If we really want this character there then, why not rather in UTF-8, so that it works flawlessly?
Quoted 3 lines
Jiri, in the future please dont apply 'trivial' patches that involve subsystems that i co-maintain and which is not acked by any of the subsystem maintainers.
OK, as you wish.
Signature · 1 line
Jiri Kosina
Quoted 4 lines · Ingo Molnar
Quoted 4 lines
Well, Paul himself stated that according to their lawyer department, "Copyright" (which is there) is enough. So it made sense to remove invalid (at least in some sense) character.
Quoted 8 lines
Quoted 4 lines
Also zillion of other files copyrighted by Paul contain "Copyright (C)".
If we really want this character there then, why not rather in UTF-8, so that it works flawlessly?
It might be fine but i havent seen Paul reply to this thread - and this is my
point: _you_ should have waited for an ack from Paul (who is co-maintaining that file) before applying it. The commit doesnt have it:
I got Pauls reply as "as soon as there is `Copyright', it's fine". If I misunderstood it, sorry for that, and I'll drop the patch.
Paul, could you please send explicit Acked-by: or Naked-by:, so that everything is in line?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
Quoted 11 lines · Tejun Heo
Quoted 7 lines · Harald Arnesen
Quoted 3 lines · Tejun Heo
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Why do we need anything there at all?
We don't necessarily need it but it's also pretty rude to strip other's copyright notices and other entries use (C), so.... :-)
I meant that:
Copyright © somename
Copyright (C) somename
Copyright somename
all have the same legal meaning.
Signature · 1 line
Hilsen Harald.
Quoted 8 lines · Jiri Kosina
Quoted 6 lines · Ingo Molnar
Quoted 6 lines
Well, Paul himself stated that according to their lawyer department, "Copyright" (which is there) is enough. So it made sense to remove invalid (at least in some sense) character.
Also zillion of other files copyrighted by Paul contain "Copyright (C)".
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
If we really want this character there then, why not rather in UTF-8, so that it works flawlessly?
It might be fine but i havent seen Paul reply to this thread - and this is my
point: _you_ should have waited for an ack from Paul (who is co-maintaining that file) before applying it. The commit doesnt have it:I got Pauls reply as "as soon as there is `Copyright', it's fine". [...]
If lkml was not Cc:-ed to that reply (which appears to be the case) then it's worth asking for / waiting for an explicit ack.
Quoted 4 lines
[...] If I misunderstood it, sorry for that, and I'll drop the patch.
Paul, could you please send explicit Acked-by: or Naked-by:, so that everything is in line?
And in that case my NAK is moot.
Thanks,
Ingo
Ingo Molnar
NAKQuoted 6 lines · Jiri Kosina
Quoted 4 lines · Tejun Heo
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Tejun Heo <[email protected]>Cc Paul Mackerras <[email protected]>---
I'm not really sure this would survive transport over mail in appliable form, attaching the patch too just in case.It didn't survive :) But it was easy enough to fix by hand. Applied, thanks Tejun.
NAK.
A similar patch was sent a few weeks ago, it was objected to and rejected - the copyright character was used for legal reasons.
Jiri, in the future please dont apply 'trivial' patches that involve subsystems that i co-maintain and which is not acked by any of the subsystem maintainers.
Thanks,
Ingo
Quoted 20 lines · Jiri Kosina
Quoted 10 lines · Ingo Molnar
Quoted 10 lines
Quoted 9 lines
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Signed-off-by Tejun Heo <[email protected]>Cc Paul Mackerras <[email protected]>---
I'm not really sure this would survive transport over mail in appliable form, attaching the patch too just in case.Quoted 7 lines
Quoted 2 lines
It didn't survive :) But it was easy enough to fix by hand. Applied, thanks Tejun.
NAK.
A similar patch was sent a few weeks ago, it was objected to and rejected - the copyright character was used for legal reasons.
Quoted 8 lines
Well, Paul himself stated that according to their lawyer department, "Copyright" (which is there) is enough. So it made sense to remove invalid (at least in some sense) character.
Also zillion of other files copyrighted by Paul contain "Copyright (C)".
If we really want this character there then, why not rather in UTF-8, so that it works flawlessly?
It might be fine but i havent seen Paul reply to this thread - and this is my
point: _you_ should have waited for an ack from Paul (who is co-maintaining that file) before applying it. The commit doesnt have it:
commit 62006c58a9a2d8b72b5b65301965bc444d43e22c
Author: Tejun Heo <[email protected]>
Date: Wed Apr 28 11:30:31 2010 +0200
trivial: use (C) instead of \251
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
We dont just go and change people's copyright notices, no matter how trivial it may seem ...
Thanks,
Ingo
Hello,
Quoted 2 lines · Paul Mackerras
I don't want "(C)" in there because our lawyers tell me that it is legally meaningless, but "Copyright" on its own is good enough.
The other lines contain the (C) so if it's not harming, let's leave it like that. It might be legally meaningless but is textually / aesthetically meaningful to your fellow coders. :-)
Thanks.
Signature · 1 line
tejun
Hello,
Quoted 1 line · Paul Mackerras
Trouble is, the lawyers tell us that "(C)" is legally meaningless.
Ah... okay.
Quoted 2 lines
However, "Copyright" on its own is enough, so if the copyright symbol annoys you, we could just remove it.
That's relieving. It sure is an annoyance for anyone who's not on latin-1. It's an outright invalid character and as you've seen it's not easy to even send a patch changing it. IMHO, if it were something which couldn't be avoided at all, encoding it using utf-8 would be much more appropriate.
Thanks.
Signature · 1 line
tejun
Hello,
Quoted 2 lines · Ingo Molnar
A similar patch was sent a few weeks ago, it was objected to and rejected - the copyright character was used for legal reasons.
Paul says that "Copyright" is enough, so what are the legal reasons?
Also, if the copyright designator absolutely has to be there, then can it be in UTF-8 at least?
Thanks.
Signature · 1 line
tejun
Quoted 6 lines · Jiri Kosina
Quoted 4 lines · Tejun Heo
The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Tejun Heo <[email protected]>Cc Paul Mackerras <[email protected]>---
I'm not really sure this would survive transport over mail in appliable form, attaching the patch too just in case.It didn't survive :) But it was easy enough to fix by hand. Applied, thanks Tejun.
I tried to reply to this earlier but I think my reply vanished due to a mail problem.
I don't want "(C)" in there because our lawyers tell me that it is legally meaningless, but "Copyright" on its own is good enough. So I would prefer that you either remove the (C) entirely or convert the copyright symbol to proper UTF-8 (0xc2 0xa9).
Thanks,
Paul.
Quoted 6 lines · Tejun Heo
Hello,
Quoted 2 lines · Ingo Molnar
A similar patch was sent a few weeks ago, it was objected to and rejected - the copyright character was used for legal reasons.
Quoted 7 lines
Paul says that "Copyright" is enough, so what are the legal reasons?
Also, if the copyright designator absolutely has to be there, then can it be in UTF-8 at least?
Thanks.
Transcoding to UTF-8 would seem appropriate. On the other hand, I am most definitely not a lawyer.
-hpa
Quoted 15 lines · Jiri Kosina
Quoted 4 lines · Ingo Molnar
Quoted 4 lines
Well, Paul himself stated that according to their lawyer department, "Copyright" (which is there) is enough. So it made sense to remove invalid (at least in some sense) character.
Quoted 8 lines
Quoted 4 lines
Also zillion of other files copyrighted by Paul contain "Copyright (C)".
If we really want this character there then, why not rather in UTF-8, so that it works flawlessly?
It might be fine but i havent seen Paul reply to this thread - and this is my
point: _you_ should have waited for an ack from Paul (who is co-maintaining that file) before applying it. The commit doesnt have it:
Quoted 5 lines
I got Pauls reply as "as soon as there is `Copyright', it's fine". If I misunderstood it, sorry for that, and I'll drop the patch.
Paul, could you please send explicit Acked-by: or Naked-by:, so that everything is in line?
Please apply the patch I just sent that changes the encoding to UTF-8.
I take your point that there are lots of other copyright notices in the kernel with "(C)", including mine, and I'm not for a moment suggesting that they are all invalid. Nevertheless, it seems that it is better to use the proper copyright symbol rather than "(C)" for new code, so I'd like to keep the copyright symbol here.
Paul.