eventfd01: should to check ret in overflow_poll_test()

PATCH In review Shi Weihua 3 participants 3 messages May 6, 2010 – May 7, 2010

lore

Share & tools

lore

Shi Weihua

author

2010-05-06 09:26 UTC #0 lore raw

PATCH 1/1 eventfd01: should to check ret in overflow_poll_test()

We should to check the return value of trigger_eventfd_overflow() in overflow_poll_test().

Signed-off-by Shi Weihua <[email protected]>

---

testcases/kernel/syscalls/eventfd/eventfd01.c +1 -1

index 83eb86e..ce55746 100644
@@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
 	int ret;
 
 	ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
-	if (fd == -1) {
+	if (ret == -1) {
 		tst_resm(TBROK, "error triggering eventfd overflow");
 		return;
 	}

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

Acked-by on v1 1/1

2010-05-06 18:03 UTC #1 lore raw

Quoted 10 lines · Shi Weihua

We should to check the return value of trigger_eventfd_overflow() in overflow_poll_test().
Signed-off-by Shi Weihua <[email protected]>
---
testcases/kernel/syscalls/eventfd/eventfd01.c +0 -0
index 83eb86e..ce55746 100644

testcases/kernel/syscalls/eventfd/eventfd01.c static void overflow_poll_test(int evfd) · line 608

Quoted 8 lines

testcases/kernel/syscalls/eventfd/eventfd01.c +1 -1

@@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
        int ret;
 
        ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
-       if (fd == -1) {
+       if (ret == -1) {
                tst_resm(TBROK, "error triggering eventfd overflow");
                return;
        }

Acked-by Garrett Cooper <[email protected]>

Subrata Modak

2010-05-07 05:46 UTC #2 lore raw

Quoted 13 lines · Garrett Cooper

Quoted 12 lines · Shi Weihua
We should to check the return value of trigger_eventfd_overflow() in overflow_poll_test().
Signed-off-by Shi Weihua <[email protected]>
---
testcases/kernel/syscalls/eventfd/eventfd01.c +0 -0
index 83eb86e..ce55746 100644
@@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
       int ret;
 

Quoted 8 lines

testcases/kernel/syscalls/eventfd/eventfd01.c static void overflow_poll_test(int evfd) · line 608
Quoted 6 lines
testcases/kernel/syscalls/eventfd/eventfd01.c +1 -1
       ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
-       if (fd == -1) {
+       if (ret == -1) {
               tst_resm(TBROK, "error triggering eventfd overflow");
               return;
       }
Acked-by Garrett Cooper <[email protected]>

Thanks. Just checked in.

Regards--
Subrata

------------------------------------------------------------------------------

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list