sctp: check parameter value of length in ERROR
Subsystems (2)
When an endpoint receives ERROR that parameter value is invalid, send an ABORT to peer with a Protocol Violation error code.
Signed-off-by Shan Wei <[email protected]>
---v2->v3:
1. Use sctp_sf_violation_paramvalue() to send ABORT with a Protocol Violation error code.
v1->v2:
1. As Vlad's suggestion, use chunk->chunk_end to point to end of chunk.
--- net/sctp/sm_statefuns.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
net/sctp/sm_statefuns.c +5 -0
@@ -3204,6 +3204,7 @@ sctp_disposition_t sctp_sf_operr_notify(const struct sctp_endpoint *ep, sctp_cmd_seq_t *commands) {struct sctp_chunk *chunk = arg; +sctp_errhdr_t *err;if (!sctp_vtag_verify (chunk, asoc))return sctp_sf_pdiscard (ep, asoc, type, arg, commands);
@@ -3212,6 +3213,10 @@ sctp_disposition_t sctp_sf_operr_notify(const struct sctp_endpoint *ep,if (!sctp_chunk_length_valid (chunk,sizeof (sctp_operr_chunk_t)))return sctp_sf_violation_chunklen (ep, asoc, type, arg, commands); +sctp_walk_errors (err, chunk->chunk_hdr); +if ((void *)err != (void *)chunk->chunk_end) +return sctp_sf_violation_paramlen (ep, asoc, type, arg, + (void *)err, commands);sctp_add_cmd_sf (commands,SCTP_CMD_PROCESS_OPERR ,SCTP_CHUNK (chunk));
Signature · 1 line
1.6.3.3