btrfs: fix some problem in btrfs_link()

PATCH In review Miao Xie 1 participant 1 message May 20, 2010 Btrfs file system

lore

Share & tools

lore

Miao Xie

author

2010-05-20 07:24 UTC #0 lore raw

PATCH 9/10 btrfs: fix some problem in btrfs_link()

- add check for btrfs_start_transaction()'s return value

- fix no drop the nlink of the inode if btrfs_set_inode_index() fails,.

Signed-off-by Miao Xie <[email protected]>

---
 fs/btrfs/inode.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

fs/btrfs/inode.c +6 -3

index 1cef510..1392a09 100644
@@ -4418,15 +4418,18 @@ static int btrfs_link(struct dentry *old_dentry, struct inode *dir,
 	if (err)
 		return err;
 
-	btrfs_inc_nlink(inode);
+	trans = btrfs_start_transaction(root, 1);
+	if (!trans) {
+		err = -ENOMEM;
+		goto fail;
+	}
 
 	err = btrfs_set_inode_index(dir, &index);
 	if (err)
 		goto fail;
 
-	trans = btrfs_start_transaction(root, 1);
-
 	btrfs_set_trans_block_group(trans, dir);
+	btrfs_inc_nlink(inode);
 	atomic_inc(&inode->i_count);
 
 	err = btrfs_add_nondir(trans, dentry, inode, 1, index);

Signature · 1 line

1.6.5.2