Am I still the one to fix the NFS_FILE_SYNC problem
Subsystems (2)
Andy, Benny are you waiting on me to fix the NFS_FILE_SYNC problem?
I've been on a long holiday, but I can attempt a fix tomorrow if still needed?
I was hoping someone else need that more urgently then me, since I already have a work around, for my testing ;-)
Boaz
Hi Boaz
The last patch I sent in [PATCH 1/1] SQUASHME pnfs-submit: replace layoutcommit_ctx with rpc_cred fixes the NFS_FILE_SYNC problem for files. It replaces taking a reference on the open context with taking a reference on the rpc_cred.
-->Andy
=09
On Sun, May 23, 2010 at 2:36 PM, Boaz Harrosh <[email protected]> wr= ote:
Quoted 4 lines
Andy, Benny are you waiting on me to fix the
NFS_FILE_SYNCproblem?I've been on a long holiday, but I can attempt a fix tomorrow if stil=
l
Quoted 3 lines
needed?
I was hoping someone else need that more urgently then me, since I al=
ready
Quoted 6 lines
have a work around, for my testing ;-)
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" =
in
Quoted 3 lines
the body of a message to [email protected]
More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): AANLkTilR7cJu1uCv60GrpFimqDWb0ogyvKVh1q0iW_6a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 7 lines · William A. (Andy) Adamson
Hi Boaz
The last patch I sent in [PATCH 1/1] SQUASHME pnfs-submit: replace
layoutcommit_ctxwithrpc_credfixes theNFS_FILE_SYNCproblem for files. It replaces taking a reference on the open context with taking a reference on therpc_cred.
Hi Andy.
I hope you are online could you chat with me a bit about this, on boazharrosh-Re5JQEeQqe9fmgfxC/sS/[email protected]
I have seen your patch and i like it a lot. I have not yet test with it, so I own you.
I'm talking about the other problem I had where the write-out returns NFS_FILE_SYNC and commit is not called and pnfs_client_ops->nfs_commit_complete() is not eventually called, then inode never gets written/updated and we get all these straining .nfs000000000000XXX files and IO never finishes. You said you had them too and I had a work around for objects. (This problem is new in 2.6.34)
Do you have this problem or it's only me?
Boaz
Quoted 20 lines
-->Andy
Quoted 16 lines · Boaz Harrosh
Andy, Benny are you waiting on me to fix the
NFS_FILE_SYNCproblem?I've been on a long holiday, but I can attempt a fix tomorrow if still needed?
I was hoping someone else need that more urgently then me, since I already have a work around, for my testing ;-)
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 17 lines · Boaz Harrosh
Quoted 7 lines · William A. (Andy) Adamson
Hi Boaz
The last patch I sent in [PATCH 1/1] SQUASHME pnfs-submit: replace
layoutcommit_ctxwithrpc_credfixes theNFS_FILE_SYNCproblem for files. It replaces taking a reference on the open context with taking a reference on therpc_cred.Hi Andy.
I hope you are online could you chat with me a bit about this, on boazharrosh-Re5JQEeQqe9fmgfxC/sS/[email protected]
I have seen your patch and i like it a lot. I have not yet test with it, so I own you.
Quoted 9 lines
I'm talking about the other problem I had where the write-out returns
NFS_FILE_SYNCand commit is not called andpnfs_client_ops->nfs_commit_complete()is not eventually called, then inode never gets written/updated and we get all these straining .nfs000000000000XXX files and IO never finishes. You said you had them too and I had a work around for objects. (This problem is new in 2.6.34)Do you have this problem or it's only me?
I have already send a patch to fix it:
http://marc.info/?l=linux-nfs&m=127433056302242&w=2
Quoted 4 lines
Boaz
Quoted 2 lines
-->Andy
Signature · 1 line
tao.
On Mon, May 24, 2010 at 11:39 AM, Boaz Harrosh <[email protected]> w= rote:
Quoted 6 lines · William A. (Andy) Adamson
Quoted 5 lines
Hi Boaz
The last patch I sent in [PATCH 1/1] SQUASHME pnfs-submit: replace
layoutcommit_ctxwithrpc_credfixes theNFS_FILE_SYNCproblem for files. It replaces taking a reference on the open context with takin=
g
Quoted 5 lines
Quoted 2 lines
a reference on the
rpc_cred.Hi Andy.
Quoted 7 lines
I hope you are online could you chat with me a bit about this, on boazharrosh-Re5JQEeQqe9fmgfxC/sS/[email protected]
I have seen your patch and i like it a lot. I have not yet test with it, so I own you.I'm talking about the other problem I had where the write-out returns
NFS_FILE_SYNCand commit is not called and pnfs_client_ops->nfs_commi=
t_complete()
Quoted 1 line
is not eventually called, then inode never gets written/updated and w=
e get all
Quoted 1 line
these straining .nfs000000000000XXX files and IO never finishes. You =
said
Quoted 1 line
you had them too and I had a work around for objects. (This problem i=
s new
Quoted 3 lines
in 2.6.34)
Do you have this problem or it's only me?
Yes, I had that problem - but for the file layout it was the pnfs_need_layoutcommit at the end of pfns4_write_done that was preventing _nfs4_close from being called due to the get on the nfs_open_context. Replacing the nfs_open_context with the rpc_cred solved our problem. Also, remember that the file layout does not need a layout commit - it's just a hint.
-->Andy
Quoted 7 lines
Boaz
Quoted 4 lines
-->Andy
On Sun, May 23, 2010 at 2:36 PM, Boaz Harrosh <[email protected]>=
Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines
Andy, Benny are you waiting on me to fix the
NFS_FILE_SYNCproblem?I've been on a long holiday, but I can attempt a fix tomorrow if st=
ill
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
needed?
I was hoping someone else need that more urgently then me, since I =
already
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
have a work around, for my testing ;-)
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs=
" in
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at =A0http://vger.kernel.org/majordomo-info.htm=
l
Quoted 3 lines
Quoted 1 line
Quoted 1 line