Skip to contentSkip to conversation

ARM: SAMSUNG: MMC: Fix build error when both DMA and PIO mode selected

PATCH New Pinkava J. 3 participants 5 messages May 25, 2010

Subsystems (3)
lore
Share & tools
lore

Pinkava J.

author
#0 lore raw

PATCH 1/2 ARM: SAMSUNG: MMC: Fix build error when both DMA and PIO mode selected

---
 drivers/mmc/host/s3cmci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/s3cmci.c +0 -0
index 2fdf768..4426a4b 100644
@@ -1600,7 +1600,7 @@ static int __devinit s3cmci_probe(struct platform_device

*pdev)
host->pio_active = XFER_NONE;

#ifdef CONFIG_MMC_S3C_PIODMA
- host->dodma = host->pdata->dma;
+ host->dodma = host->pdata->use_dma;
#endif

host->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/2 ARM: Fix MMC power management on Acer n30 / n35

Exchange on and off state, MMC is working even if "powered off", but when comes to write it causes random failures, most frequently zeroes first/all sector(s).

---
 arch/arm/mach-s3c2410/mach-n30.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2410/mach-n30.c +0 -0
index 41f299d..6c3456c 100644
@@ -357,11 +357,11 @@ static void n30_sdi_set_power(unsigned char power_mode,

unsigned short vdd)
switch (power_mode) {
case MMC_POWER_ON:
case MMC_POWER_UP:
- gpio_set_value(S3C2410_GPG(4), 1);
+ gpio_set_value(S3C2410_GPG(4), 0);
break;
case MMC_POWER_OFF:
default:
- gpio_set_value(S3C2410_GPG(4), 0);
+ gpio_set_value(S3C2410_GPG(4), 1);
break;
}
}

Signature · 1 line
1.7.1
#3 lore raw

PATCH 1/2 ARM: SAMSUNG: MMC: Fix build error when both DMA and PIO mode selected

In reply to Pinkava J.
Quoted 2 lines · Pinkava J.

please send to the linux mmc list and/or akpm for inclusion.

Quoted 25 lines
---
 drivers/mmc/host/s3cmci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/s3cmci.c +1 -1
index 2fdf768..4426a4b 100644
@@ -1600,7 +1600,7 @@ static int __devinit s3cmci_probe(struct platform_device
 *pdev)
 	host->pio_active 	= XFER_NONE;
 
 #ifdef CONFIG_MMC_S3C_PIODMA
-	host->dodma		= host->pdata->dma;
+	host->dodma		= host->pdata->use_dma;
 #endif
 

host->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Signature · 6 lines
1.7.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
author
#2 lore raw

PATCH 2/2 ARM: Fix MMC power management on Acer n30 / n35

In reply to Pinkava J.

Dne 25.5.2010 03:22, Pinkava J. napsal(a):

Quoted 2 lines

Exchange on and off state, MMC is working even if "powered off", but when comes to write it causes random failures, most frequently zeroes first/all sector(s).

Sorry for mess, this is idependend on previous patch and should be included.

(Or removed patch named:
ARM: n30: Add support for power on/off on Acer n30 / Acer n35 MMC card reader )

Quoted 25 lines
---
 arch/arm/mach-s3c2410/mach-n30.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2410/mach-n30.c +2 -2
index 41f299d..6c3456c 100644
@@ -357,11 +357,11 @@ static void n30_sdi_set_power(unsigned char power_mode,
 unsigned short vdd)
 	switch (power_mode) {
 	case MMC_POWER_ON:
 	case MMC_POWER_UP:
-		gpio_set_value(S3C2410_GPG(4), 1);
+		gpio_set_value(S3C2410_GPG(4), 0);
 		break;
 	case MMC_POWER_OFF:
 	default:
-		gpio_set_value(S3C2410_GPG(4), 0);
+		gpio_set_value(S3C2410_GPG(4), 1);
 		break;
 	}

}

#4 lore raw

PATCH 1/2 ARM: SAMSUNG: MMC: Fix build error when both DMA and PIO mode selected

In reply to Pinkava J.

Hello.

drivers/mmc/host/s3cmci.c static int __devinit s3cmci_probe(struct platform_device · line 1600

Quoted 11 lines · Pinkava J.
---
 drivers/mmc/host/s3cmci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/s3cmci.c +0 -0
index 2fdf768..4426a4b 100644
@@ -1600,7 +1600,7 @@ static int __devinit s3cmci_probe(struct platform_device
 *pdev)

Your patch is line wrapped. Should be easy to fix however...

WBR, Sergei