tools: Allow space in vbd path name
PATCH 1/1 tools: Allow space in vbd path name
Trivial fix for block script ...
Regards,
Jim
# HG changeset patch
# User Jim Fehlig <[email protected]>
# Date 1274807602 21600
# Node ID 14d040342c6618365750b2c3b96ca01ff4a5e5dd # Parent 93410e5e4ad8799932ad31820d0d82c74d1f63a2 Allow space in vbd path name
c/s 20393 breaks existing domain configuration that contains spaces in the vbd path name. Fixed by this trivial patch which provides missing quotes.
tools/hotplug/Linux/block +2 -2
@@ -272,8 +272,8 @@ if [ "x$mode" != 'x!' ] then - inode=$(stat -c '%i' $file) - dev=$(stat -c '%D' $file) + inode=$(stat -c '%i' "$file") + dev=$(stat -c '%D' "$file") if [ -z "$inode" ] || [ -z "$dev" ] then fatal "Unable to lookup $file: dev: $dev inode: $inode"
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 2 lines · Jim Fehlig
Trivial fix for block script ...
Hello,
was this patch merged? There's an user on ##xen complaining about vif devices not released if there's a typo on the vbd path..
I think he tried both xen 4.0 and 4.1-unstable.
-- Pasi
Quoted 36 lines
Regards,
Jim# HG changeset patch
# User Jim Fehlig <[email protected]>
# Date 1274807602 21600
# Node ID14d040342c6618365750b2c3b96ca01ff4a5e5dd# Parent93410e5e4ad8799932ad31820d0d82c74d1f63a2Allow space in vbd path namec/s 20393 breaks existing domain configuration that contains spaces in the vbd path name. Fixed by this trivial patch which provides missing quotes.
Signed-off-by Jim Fehlig <[email protected]>diff -r
93410e5e4ad8-r14d040342c66tools/hotplug/Linux/blocktools/hotplug/Linux/block +2
-2@@ -272,8 +272,8 @@ if [ "x$mode" != 'x!' ] then - inode=$(stat -c '%i' $file) - dev=$(stat -c '%D' $file) + inode=$(stat -c '%i' "$file") + dev=$(stat -c '%D' "$file") if [ -z "$inode" ] || [ -z "$dev" ] then fatal "Unable to lookup $file: dev: $dev inode: $inode"_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 11 lines · Pasi Kärkkäinen
Quoted 3 lines · Jim Fehlig
Trivial fix for block script ...
Hello,
was this patch merged? There's an user on ##xen complaining about vif devices not released if there's a typo on the vbd path..
Yes, as c/s 21459.
Jim