Skip to contentSkip to conversation

ext3: fix non-update ctime when changing the file's permission by setfacl

PATCH In review Miao Xie 2 participants 2 messages May 27, 2010 – Jun 2, 2010

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 1/1 ext3: fix non-update ctime when changing the file's permission by setfacl

ext3 didn't update the ctime of the file when its permission was changed.

Steps to reproduce:

 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822				<- unchanged

But, according to the spec of the ctime, ext3 must update it.

---
 fs/ext3/acl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ext3/acl.c +1 -0
index 01552ab..8a11fe2 100644
@@ -205,6 +205,7 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type,
 					return error;
 				else {
 					inode->i_mode = mode;
+					inode->i_ctime = CURRENT_TIME_SEC;
 					ext3_mark_inode_dirty(handle, inode);
 					if (error == 0)
 						acl = NULL;
Signature · 1 line
1.6.5.2
#1 lore raw
Quoted 11 lines

ext3 didn't update the ctime of the file when its permission was changed.

Steps to reproduce:

 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822				<- unchanged

But, according to the spec of the ctime, ext3 must update it.

Yeah, good spotting. Thanks. Looking at various code, the bug was probably
cut-n-pasted to all the filesystems (except XFS)... Sigh. It would be nice to handle this somehow generically in VFS but currently I don't see a way. So probably I'll take filesystems one by one and fix them.

Honza

Quoted 26 lines
---
 fs/ext3/acl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ext3/acl.c +1 -0
index 01552ab..8a11fe2 100644
@@ -205,6 +205,7 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type,
 					return error;
 				else {
 					inode->i_mode = mode;
+					inode->i_ctime = CURRENT_TIME_SEC;
 					ext3_mark_inode_dirty(handle, inode);
 					if (error == 0)
 						acl = NULL;
Signature · 7 lines
1.6.5.2


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Jan Kara <[email protected]>
SuSE CR Labs