Skip to contentSkip to conversation

libxl: enable remote shutdown for pure hvm domain.

PATCH In review Zhigang Wang 3 participants 5 messages May 31, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl: enable remote shutdown for pure hvm domain.

Hi Stefano,

Is this a typo or intended to be so?

Thanks,

Zhigang

libxl: enable remote shutdown for pure hvm domain.

tools/libxl/libxl.c +1 -1
diff -r 96917cf25bf3 tools/libxl/libxl.c
@@ -550,7 +550,7 @@
     shutdown_path = libxl_sprintf(ctx, "%s/control/shutdown", dom_path);
 
     xs_write(ctx->xsh, XBT_NULL, shutdown_path, req_table[req], strlen(req_table[req]));
-    if (/* hvm */ 0) {
+    if (is_hvm(ctx, domid)) {
         unsigned long acpi_s_state = 0;
         unsigned long pvdriver = 0;
         xc_get_hvm_param(ctx->xch, domid, HVM_PARAM_ACPI_S_STATE, &acpi_s_state);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#4 lore raw
In reply to Zhigang Wang
Quoted 3 lines · Zhigang Wang

Hi Stefano,

Is this a typo or intended to be so?

I think I disabled it at the time because I couldn't test it so I wasn't sure it was working.
You can safely enable it now.
Thanks,

Stefano

#3 lore raw

Re: [PATCH]libxl: enable remote shutdown for pure hvm domain. - withdraw

In reply to Zhigang Wang
Quoted 8 lines · Zhigang Wang
Quoted 7 lines · Yang Hongyang

Hi,

Quoted 3 lines · Zhigang Wang

Hi Stefano,

Is this a typo or intended to be so?

Quoted 9 lines
Quoted 4 lines

Please refer to this thread's discussion.

http://lists.xensource.com/archives/html/xen-devel/2010-05/msg00361.html

Thanks Hongyang.

I'll withdraw this patch and try to help Gihan Munasinghe to improve his patch.

Yeah, that would be ideal.
However we know that the code to detect that PV drivers are running in the guest is correct because we are using it already in the suspend/resume case (libxl_dom.c:core_suspend_callback).