Topcliff PHUB: Generate PacketHub driver
Hi Alan
We are now updating our Phub driver.
I have a questions for your comment.
(1)
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+#ifdef PCH_CAN_PCLK_50MHZ + /* save clk cfg register */ + g_pch_phub_reg.clkcfg_reg = PCH_READ_REG(CLKCFG_REG_OFFSET); +#endifThis makes it hard to build one kernel for everything
We couldn't understand your intention.
Does the above mean we must not use "#ifdef PCH_CAN_PCLK_50MHZ" in source code ?
BTW, We show our modification policy the following email with inline. Please confirm it.
If there is any mistake, please inform us.
Thanks.
Ohtake.
----- Original Message -----
From: "Alan Cox" <[email protected]>
To: "Masayuki Ohtak" <[email protected]>
Sent: Tuesday, June 08, 2010 12:05 AM
Subject: Re: [PATCH] Topcliff PHUB: Generate PacketHub driver
Quoted 38 lines
O> +/* Status Register offset */
Quoted 35 lines
(quoted diff) +18
-0+#define PHUB_STATUS (0x00) +/* Control Register offset */ +#define PHUB_CONTROL (0x04) +/* Time out value for Status Register */ +#define PHUB_TIMEOUT (0x05) +/* Enabling for writing ROM */ +#define PCH_PHUB_ROM_WRITE_ENABLE (0x01) +/* Disabling for writing ROM */ +#define PCH_PHUB_ROM_WRITE_DISABLE (0x00) +/* ROM data area start address offset */ +#define PCH_PHUB_ROM_START_ADDR (0x14) +/* MAX number of INT_REDUCE_CONTROL registers */ +#define MAX_NUM_INT_REDUCE_CONTROL_REG (128) + +#define PCI_DEVICE_ID_PCH1_PHUB (0x8801) + +#define PCH_MINOR_NOS (1) +#define CLKCFG_CAN_50MHZ (0x12000000)
Quoted 7 lines
Quoted 1 line
+#define
CLKCFG_CANCLK_MASK(0xFF000000)Style: constants don't need brackets - might also look more Linux like
tabbed out a bit
The above brackets are deleted
Quoted 14 lines
Review
Quoted 7 lines
(quoted diff) +3
-0+#define PCH_READ_REG(a) ioread32((pch_phub_base_address + a)) + +#define PCH_WRITE_REG(a, b) iowrite32(a, (pch_phub_base_address + b))These on the other hand do - but not where they are now
Quoted 5 lines
iowrite32((a), pcb_phub_base_address + (b))(so that if a or b are expressions they are evaluated first)
Modify like below.
#define PCH_READ_REG(a) ioread32(pch_phub_base_address + (a))
#define PCH_WRITE_REG(a, b) iowrite32(a, pch_phub_base_address + (b))
Quoted 38 lines
Quoted 37 lines
(quoted diff) +17
-0+struct pch_phub_reg { + u32 phub_id_reg; /* PHUB_ID register val */ + u32 q_pri_val_reg; /* QUEUE_PRI_VAL register val */ + u32 rc_q_maxsize_reg; /* RC_QUEUE_MAXSIZE register val */ + u32 bri_q_maxsize_reg; /* BRI_QUEUE_MAXSIZE register val */ + u32 comp_resp_timeout_reg; /* COMP_RESP_TIMEOUT register val */ + u32 bus_slave_control_reg; /* BUS_SLAVE_CONTROL_REG register val */ + u32 deadlock_avoid_type_reg; /* DEADLOCK_AVOID_TYPE register val */ + u32 intpin_reg_wpermit_reg0; /* INTPIN_REG_WPERMIT register 0 val */ + u32 intpin_reg_wpermit_reg1; /* INTPIN_REG_WPERMIT register 1 val */ + u32 intpin_reg_wpermit_reg2; /* INTPIN_REG_WPERMIT register 2 val */ + u32 intpin_reg_wpermit_reg3; /* INTPIN_REG_WPERMIT register 3 val */ + /* INT_REDUCE_CONTROL registers val */ + u32 int_reduce_control_reg[MAX_NUM_INT_REDUCE_CONTROL_REG]; +#ifdef PCH_CAN_PCLK_50MHZ + u32 clkcfg_reg; /* CLK CFG register val */ +#endif
Quoted 7 lines
Quoted 1 line
+}
g_pch_phub_reg;Stylewise the kernel doesn't use the g_ convention that many Windows
people do, so lose the g_
Delete prefix 'g_'.
Quoted 6 lines
Quoted 5 lines
(quoted diff) +2
-0+s32 pch_phub_opencount; /* check whether opened or not */ +u32 pch_phub_base_address;
Quoted 7 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+u32 pch_phub_extrom_base_address; +s32 pch_phub_suspended;Any reason these can't be in the struct ?
Move the above 4 variables into 'struct pch_phub_reg_t'.
Quoted 7 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ +struct device *dev_dbg;Not a good name for a global variable as it will clash with others
Modify to phub_dev_dbg.
Quoted 7 lines
Quoted 3 lines
+DEFINE_SPINLOCK(pch_phub_lock); /* for spin lock */
Can this be static or in the struct ?
Modify lile below.
static DEFINE_SPINLOCK(pch_phub_lock); /* for spin lock */
Quoted 18 lines
Quoted 17 lines
(quoted diff) +8
-0+ +/** + * file_operations structure initialization + */ +const struct file_operations pch_phub_fops = { + .owner = THIS_MODULE, + .open = pch_phub_open, + .release = pch_phub_release,
Quoted 9 lines
Quoted 3 lines
+ .ioctl =
pch_phub_ioctl,+};
static const ?
Modify to 'static const'.
Quoted 9 lines
Quoted 5 lines
+/*--------------------------------------------
+ exported function prototypes
+--------------------------------------------*/
They start 'static' I don't think they are exportdd !
Modify comment to 'Internal function prototypes'
Quoted 54 lines
Quoted 41 lines
(quoted diff) +19
-0+static int __devinit pch_phub_probe(struct pci_dev *pdev, const + struct pci_device_id *id); +static void __devexit pch_phub_remove(struct pci_dev *pdev); +static int pch_phub_suspend(struct pci_dev *pdev, pm_message_t state); +static int pch_phub_resume(struct pci_dev *pdev); +static struct pci_driver pch_phub_driver = { + .name = "pch_phub", + .id_table = pch_phub_pcidev_id, + .probe = pch_phub_probe, + .remove = __devexit_p(pch_phub_remove), +#ifdef CONFIG_PM + .suspend = pch_phub_suspend, + .resume = pch_phub_resume +#endif +}; + +static int __init pch_phub_pci_init(void); +static void __exit pch_phub_pci_exit(void); +Review
Quoted 10 lines
(quoted diff) +5
-0+MODULE_DESCRIPTION("PCH PACKET HUB PCI Driver"); +MODULE_LICENSE("GPL"); +module_init(pch_phub_pci_init); +module_exit(pch_phub_pci_exit); +module_param(pch_phub_major_no, int, S_IRUSR | S_IWUSR);
Quoted 5 lines
If you migrated the module registration/PCI registration to the bottom of
the file you could avoid the forward declations and make the code easier
to follow ?
Move the PCI registration code to the bottom of the file.
Quoted 32 lines
Review
Quoted 13 lines
(quoted diff) +6
-0+void pch_phub_read_modify_write_reg(unsigned long reg_addr_offset, + unsigned long data, unsigned long mask) +{ + unsigned long reg_addr = pch_phub_base_address + reg_addr_offset; + iowrite32(((ioread32((void __iomem *)reg_addr) & ~mask)) | data, + (void __iomem *)reg_addr);When you have that many casts in a line it's perhaps a hint you have the
types wrong initially. At the very least
reg_addrshould be void__iomem,and probably
pch_phub_base_addressshould beIt would probably make sense to pass a pointer to your struct
pch_hub_regand use that to hold the base address. Then if you ever get a box with
two in some future design it won't be a disaster
Quoted 5 lines
Quoted 1 line
+void
pch_phub_save_reg_conf(void)Ditto
reg_addr/pch_phub_base_address are defined as 'void __iomem',
Quoted 6 lines
Quoted 5 lines
+#ifdef
PCH_CAN_PCLK_50MHZ+ /* save clk cfg register */
Quoted 7 lines
Quoted 3 lines
+ g_pch_phub_reg.clkcfg_reg =
PCH_READ_REG(CLKCFG_REG_OFFSET);+#endif
This makes it hard to build one kernel for everything
???
Quoted 12 lines
Quoted 11 lines
+ return;
(quoted diff) +3
-0+} +void pch_phub_restore_reg_conf(void) +{
Quoted 7 lines
Quoted 1 line
+ u32 i = 0;
Why = 0, if you do that here you may hide initialisation errors from
future changes ?
Delete '=0'
Quoted 22 lines
Quoted 21 lines
(quoted diff) +10
-0+/** pch_phub_read_serial_rom - Implements the functionality of reading Serial + * ROM. + * @offset_address: Contains the Serial ROM address offset value + * @data: Contains the Serial ROM value + */ +int pch_phub_read_serial_rom(unsigned long offset_address, unsigned char *data) +{ + unsigned long mem_addr = pch_phub_extrom_base_address + offset_address; + + dev_dbg(dev_dbg,
Quoted 7 lines
Quoted 3 lines
+ "pch_phub_read_serial_rom:mem_addr=0x%08x\n", (u32)mem_addr);
+ *data =
ioread8((void __iomem *)mem_addr);Same comments about casts
Please refer the above.(defined as 'void __iomem',)
Quoted 16 lines
Quoted 15 lines
(quoted diff) +5
-0+int pch_phub_ioctl(struct inode *inode, struct file *file, + unsigned int cmd, unsigned long arg) +{ + int ret_value = 0; + struct pch_phub_reqt *p_pch_phub_reqt;
Quoted 7 lines
Quoted 1 line
+ unsigned long
addr_offset;This will change size on 32/64bit boxes makign your copy a bit
problematic
Modify like belwo,
u64 addr_offset;
Quoted 14 lines
Quoted 11 lines
+
p_pch_phub_reqt= (structpch_phub_reqt*)arg;+
ret_value= copy_from_user((void *)&addr_offset,+ (void *)&p_pch_phub_reqt->addr_offset,
+
sizeof(addr_offset));+ if (
ret_value) {
Quoted 7 lines
Quoted 1 line
+ /* End of Access area check */
Remember here ioctl isn't single threaded so you may want to double check
some of these
The above copy_from_user is Copy global variable to local variable. Thus, We think this code has re-entrant.
Quoted 10 lines
Quoted 9 lines
+struct
pch_phub_reqt{+ unsigned long
addr_offset; /*specifies the register address+ offset */
+ unsigned long data; /*specifies the data */
Quoted 7 lines
Quoted 1 line
+ unsigned long mask; /*specifies the mask */
If they may need to be long make them u64. That way 32 and 64bit systems
get the same ioctl structure and life is good.
Modify type of addr_offset to u64
Quoted 14 lines
Quoted 13 lines
(quoted diff) +6
-0+}; + +/* exported function prototypes */ +int pch_phub_open(struct inode *inode, struct file *file); +int pch_phub_release(struct inode *inode, struct file *file); +int pch_phub_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
Quoted 7 lines
Quoted 1 line
+ unsigned long arg);
You have various other functions that are not static - if they should be
then make them static
Add static description for all of internal functions.
Hi Alan
Quoted 6 lines
Quoted 3 lines
Remember here ioctl isn't single threaded so you may want to double check
some of these
The above
copy_from_useris Copy global variable to local variable. Thus, We think this code has re-entrant.
The above is not true.
Our ioctl routine is just used under single pthread.
Quoted 1 line
Hi Andrew
Sorry, I have not checked my email.
Thanks,
----- Original Message -----
From: "Masayuki Ohtak" <[email protected]>
To: "Alan Cox" <[email protected]>
Cc: "LKML" <[email protected]>; "Andrew" <[email protected]>; "Intel OTC" <[email protected]>; "Wang, Qi" <[email protected]>; "Wang, Yong Y" <[email protected]>; "Masayuki Ohtak" <[email protected]>
Sent: Tuesday, June 08, 2010 2:00 PM
Subject: Re: [PATCH] Topcliff PHUB: Generate PacketHub driver
Quoted 27 lines
Hi Alan
We are now updating our Phub driver.
I have a questions for your comment.
(1)
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+#ifdef PCH_CAN_PCLK_50MHZ + /* save clk cfg register */ + g_pch_phub_reg.clkcfg_reg = PCH_READ_REG(CLKCFG_REG_OFFSET); +#endifThis makes it hard to build one kernel for everything
We couldn't understand your intention.
Does the above mean we must not use "#ifdefPCH_CAN_PCLK_50MHZ" in source code ?BTW, We show our modification policy the following email with inline. Please confirm it.
If there is any mistake, please inform us.Thanks.
Ohtake.
Quoted 7 lines
----- Original Message -----
From: "Alan Cox" <[email protected]>
To: "Masayuki Ohtak" <[email protected]>
Cc "LKML" <[email protected]>; "Andrew" <[email protected]>; "Intel OTC"
<[email protected]>; "Wang, Qi" <[email protected]>; "Wang, Yong Y" <[email protected]>
Quoted 524 lines
Sent: Tuesday, June 08, 2010 12:05 AM
Subject: Re: [PATCH] Topcliff PHUB: Generate PacketHub driver
Quoted 38 lines
O> +/* Status Register offset */
Quoted 35 lines
(quoted diff) +18
-0+#define PHUB_STATUS (0x00) +/* Control Register offset */ +#define PHUB_CONTROL (0x04) +/* Time out value for Status Register */ +#define PHUB_TIMEOUT (0x05) +/* Enabling for writing ROM */ +#define PCH_PHUB_ROM_WRITE_ENABLE (0x01) +/* Disabling for writing ROM */ +#define PCH_PHUB_ROM_WRITE_DISABLE (0x00) +/* ROM data area start address offset */ +#define PCH_PHUB_ROM_START_ADDR (0x14) +/* MAX number of INT_REDUCE_CONTROL registers */ +#define MAX_NUM_INT_REDUCE_CONTROL_REG (128) + +#define PCI_DEVICE_ID_PCH1_PHUB (0x8801) + +#define PCH_MINOR_NOS (1) +#define CLKCFG_CAN_50MHZ (0x12000000)Quoted 7 lines
Quoted 1 line
+#define
CLKCFG_CANCLK_MASK(0xFF000000)Style: constants don't need brackets - might also look more Linux like
tabbed out a bit
The above brackets are deleted
Quoted 14 lines
Review
Quoted 7 lines
(quoted diff) +3
-0+#define PCH_READ_REG(a) ioread32((pch_phub_base_address + a)) + +#define PCH_WRITE_REG(a, b) iowrite32(a, (pch_phub_base_address + b))These on the other hand do - but not where they are now
Quoted 5 lines
iowrite32((a), pcb_phub_base_address + (b))(so that if a or b are expressions they are evaluated first)
Modify like below.
#define
PCH_READ_REG(a)ioread32(pch_phub_base_address + (a))#define
PCH_WRITE_REG(a, b)iowrite32(a, pch_phub_base_address + (b))Quoted 38 lines
Quoted 37 lines
(quoted diff) +17
-0+struct pch_phub_reg { + u32 phub_id_reg; /* PHUB_ID register val */ + u32 q_pri_val_reg; /* QUEUE_PRI_VAL register val */ + u32 rc_q_maxsize_reg; /* RC_QUEUE_MAXSIZE register val */ + u32 bri_q_maxsize_reg; /* BRI_QUEUE_MAXSIZE register val */ + u32 comp_resp_timeout_reg; /* COMP_RESP_TIMEOUT register val */ + u32 bus_slave_control_reg; /* BUS_SLAVE_CONTROL_REG register val */ + u32 deadlock_avoid_type_reg; /* DEADLOCK_AVOID_TYPE register val */ + u32 intpin_reg_wpermit_reg0; /* INTPIN_REG_WPERMIT register 0 val */ + u32 intpin_reg_wpermit_reg1; /* INTPIN_REG_WPERMIT register 1 val */ + u32 intpin_reg_wpermit_reg2; /* INTPIN_REG_WPERMIT register 2 val */ + u32 intpin_reg_wpermit_reg3; /* INTPIN_REG_WPERMIT register 3 val */ + /* INT_REDUCE_CONTROL registers val */ + u32 int_reduce_control_reg[MAX_NUM_INT_REDUCE_CONTROL_REG]; +#ifdef PCH_CAN_PCLK_50MHZ + u32 clkcfg_reg; /* CLK CFG register val */ +#endifQuoted 7 lines
Quoted 1 line
+}
g_pch_phub_reg;Stylewise the kernel doesn't use the g_ convention that many Windows
people do, so lose the g_
Delete prefix 'g_'.
Quoted 6 lines
Quoted 5 lines
(quoted diff) +2
-0+s32 pch_phub_opencount; /* check whether opened or not */ +u32 pch_phub_base_address;Quoted 7 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+u32 pch_phub_extrom_base_address; +s32 pch_phub_suspended;Any reason these can't be in the struct ?
Move the above 4 variables into 'struct
pch_phub_reg_t'.Quoted 7 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ +struct device *dev_dbg;Not a good name for a global variable as it will clash with others
Modify to
phub_dev_dbg.Quoted 7 lines
Quoted 3 lines
+DEFINE_SPINLOCK(pch_phub_lock); /* for spin lock */
Can this be static or in the struct ?
Modify lile below.
static
DEFINE_SPINLOCK(pch_phub_lock); /* for spin lock */Quoted 18 lines
Quoted 17 lines
(quoted diff) +8
-0+ +/** + * file_operations structure initialization + */ +const struct file_operations pch_phub_fops = { + .owner = THIS_MODULE, + .open = pch_phub_open, + .release = pch_phub_release,Quoted 9 lines
Quoted 3 lines
+ .ioctl =
pch_phub_ioctl,+};
static const ?
Modify to 'static const'.
Quoted 9 lines
Quoted 5 lines
+/*--------------------------------------------
+ exported function prototypes
+--------------------------------------------*/
They start 'static' I don't think they are exportdd !
Modify comment to 'Internal function prototypes'
Quoted 54 lines
Quoted 41 lines
(quoted diff) +19
-0+static int __devinit pch_phub_probe(struct pci_dev *pdev, const + struct pci_device_id *id); +static void __devexit pch_phub_remove(struct pci_dev *pdev); +static int pch_phub_suspend(struct pci_dev *pdev, pm_message_t state); +static int pch_phub_resume(struct pci_dev *pdev); +static struct pci_driver pch_phub_driver = { + .name = "pch_phub", + .id_table = pch_phub_pcidev_id, + .probe = pch_phub_probe, + .remove = __devexit_p(pch_phub_remove), +#ifdef CONFIG_PM + .suspend = pch_phub_suspend, + .resume = pch_phub_resume +#endif +}; + +static int __init pch_phub_pci_init(void); +static void __exit pch_phub_pci_exit(void); +Review
Quoted 10 lines
(quoted diff) +5
-0+MODULE_DESCRIPTION("PCH PACKET HUB PCI Driver"); +MODULE_LICENSE("GPL"); +module_init(pch_phub_pci_init); +module_exit(pch_phub_pci_exit); +module_param(pch_phub_major_no, int, S_IRUSR | S_IWUSR);Quoted 5 lines
If you migrated the module registration/PCI registration to the bottom of
the file you could avoid the forward declations and make the code easier
to follow ?
Move the PCI registration code to the bottom of the file.
Quoted 32 lines
Review
Quoted 13 lines
(quoted diff) +6
-0+void pch_phub_read_modify_write_reg(unsigned long reg_addr_offset, + unsigned long data, unsigned long mask) +{ + unsigned long reg_addr = pch_phub_base_address + reg_addr_offset; + iowrite32(((ioread32((void __iomem *)reg_addr) & ~mask)) | data, + (void __iomem *)reg_addr);When you have that many casts in a line it's perhaps a hint you have the
types wrong initially. At the very least
reg_addrshould be void__iomem,and probably
pch_phub_base_addressshould beIt would probably make sense to pass a pointer to your struct
pch_hub_regand use that to hold the base address. Then if you ever get a box with
two in some future design it won't be a disaster
Quoted 5 lines
Quoted 1 line
+void
pch_phub_save_reg_conf(void)Ditto
reg_addr/pch_phub_base_address are defined as 'void
__iomem',Quoted 6 lines
Quoted 5 lines
+#ifdef
PCH_CAN_PCLK_50MHZ+ /* save clk cfg register */
Quoted 7 lines
Quoted 3 lines
+ g_pch_phub_reg.clkcfg_reg =
PCH_READ_REG(CLKCFG_REG_OFFSET);+#endif
This makes it hard to build one kernel for everything
???
Quoted 12 lines
Quoted 11 lines
+ return;
(quoted diff) +3
-0+} +void pch_phub_restore_reg_conf(void) +{Quoted 7 lines
Quoted 1 line
+ u32 i = 0;
Why = 0, if you do that here you may hide initialisation errors from
future changes ?
Delete '=0'
Quoted 22 lines
Quoted 21 lines
(quoted diff) +10
-0+/** pch_phub_read_serial_rom - Implements the functionality of reading Serial + * ROM. + * @offset_address: Contains the Serial ROM address offset value + * @data: Contains the Serial ROM value + */ +int pch_phub_read_serial_rom(unsigned long offset_address, unsigned char *data) +{ + unsigned long mem_addr = pch_phub_extrom_base_address + offset_address; + + dev_dbg(dev_dbg,Quoted 7 lines
Quoted 3 lines
+ "pch_phub_read_serial_rom:mem_addr=0x%08x\n", (u32)mem_addr);
+ *data =
ioread8((void __iomem *)mem_addr);Same comments about casts
Please refer the above.(defined as 'void
__iomem',)Quoted 16 lines
Quoted 15 lines
(quoted diff) +5
-0+int pch_phub_ioctl(struct inode *inode, struct file *file, + unsigned int cmd, unsigned long arg) +{ + int ret_value = 0; + struct pch_phub_reqt *p_pch_phub_reqt;Quoted 7 lines
Quoted 1 line
+ unsigned long
addr_offset;This will change size on 32/64bit boxes makign your copy a bit
problematic
Modify like belwo,
u64
addr_offset;Quoted 14 lines
Quoted 11 lines
+
p_pch_phub_reqt= (structpch_phub_reqt*)arg;+
ret_value= copy_from_user((void *)&addr_offset,+ (void *)&p_pch_phub_reqt->addr_offset,
+
sizeof(addr_offset));+ if (
ret_value) {Quoted 7 lines
Quoted 1 line
+ /* End of Access area check */
Remember here ioctl isn't single threaded so you may want to double check
some of these
The above
copy_from_useris Copy global variable to local variable. Thus, We think this code has re-entrant.Quoted 10 lines
Quoted 9 lines
+struct
pch_phub_reqt{+ unsigned long
addr_offset; /*specifies the register address+ offset */
+ unsigned long data; /*specifies the data */
Quoted 7 lines
Quoted 1 line
+ unsigned long mask; /*specifies the mask */
If they may need to be long make them u64. That way 32 and 64bit systems
get the same ioctl structure and life is good.
Modify type of
addr_offsetto u64Quoted 14 lines
Quoted 13 lines
(quoted diff) +6
-0+}; + +/* exported function prototypes */ +int pch_phub_open(struct inode *inode, struct file *file); +int pch_phub_release(struct inode *inode, struct file *file); +int pch_phub_ioctl(struct inode *inode, struct file *file, unsigned int cmd,Quoted 7 lines
Quoted 1 line
+ unsigned long arg);
You have various other functions that are not static - if they should be
then make them static
Add static description for all of internal functions.
Quoted 10 lines · On Tue, 8 Jun 2010 14:46:31 +0900 "Masayuki Ohtake"…
Hi Alan
Quoted 6 lines
Quoted 3 lines
Remember here ioctl isn't single threaded so you may want to double check
some of these
The above
copy_from_useris Copy global variable to local variable. Thus, We think this code has re-entrant.The above is not true.
Our ioctl routine is just used under single pthread.
What if someone else chooses to open it and run multiple threads through it. What if the code changes. What about malicious attempts to confuse the driver ?
The fact your own current userspace does not do this does not mean it can be ignored.
Alan
Quoted 7 lines · Masayuki Ohtak
Hi Alan
We are now updating our Phub driver.
I have a questions for your comment.
(1)
Quoted 9 lines
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+#ifdef PCH_CAN_PCLK_50MHZ + /* save clk cfg register */ + g_pch_phub_reg.clkcfg_reg = PCH_READ_REG(CLKCFG_REG_OFFSET); +#endifThis makes it hard to build one kernel for everything
We couldn't understand your intention.
Does the above mean we must not use "#ifdefPCH_CAN_PCLK_50MHZ" in source code ?
I think what Alan means is that you will have to build two kernel images for two possible configurations of how your hardware is going to be used if you write code this way. One is the case when CAN clock runs at 50MHz and you will build a kernel image with PCH_CAN_PCLK_50MHZ defined. The other is when CAN clock runs at other speed and you need to build another kernel image with PCH_CAN_PCLK_50MHZ undefined. It would be much better if one kernel image could run on all configurations.
Why is 50MHz so special, btw? Don't you need to save and restore the clock config register when CAN clock runs at other speed?
Quoted 17 lines
Quoted 16 lines
Review
Quoted 6 lines
(quoted diff) +3
-0+#define PCH_READ_REG(a) ioread32((pch_phub_base_address + a)) + +#define PCH_WRITE_REG(a, b) iowrite32(a, (pch_phub_base_address + b))These on the other hand do - but not where they are now
iowrite32((a), pcb_phub_base_address + (b))
Quoted 8 lines
Quoted 1 line
(so that if a or b are expressions they are evaluated first)
Modify like below.
#define
PCH_READ_REG(a)ioread32(pch_phub_base_address + (a))#define
PCH_WRITE_REG(a, b)iowrite32(a, pch_phub_base_address + (b))
Note that 'a' is supposed to be surrounded by brackets, too.
#define PCH_WRITE_REG(a, b) iowrite32((a), pcb_phub_base_address + (b))
Thanks
-Yong
Hi Yong Wang
Thank you for your comment.
Quoted 1 line
Why is 50MHz so special, btw?
This code is work around for previous HW bug.
(CAN worked only 50MHz with previous HW)
Since the HW bug has been already fixed for the latest HW, this code is unnecessary for the latest HW.
Quoted 3 lines
Note that 'a' is supposed to be surrounded by brackets, too.
#define
PCH_WRITE_REG(a, b)iowrite32((a), pcb_phub_base_address + (b))
Thank you for your indication. We have updated.
Best Regards,
----- Original Message -----
From: "Yong Wang" <[email protected]>
To: "Masayuki Ohtak" <[email protected]>
Cc: "Alan Cox" <[email protected]>; "LKML" <[email protected]>; "Andrew" <[email protected]>; "Intel OTC" <[email protected]>; "Wang, Qi" <[email protected]>; "Wang, Yong Y" <[email protected]>
Sent: Tuesday, June 08, 2010 4:20 PM
Subject: Re: [PATCH] Topcliff PHUB: Generate PacketHub driver
Quoted 62 lines · Masayuki Ohtak
Quoted 7 lines
Hi Alan
We are now updating our Phub driver.
I have a questions for your comment.
(1)
Quoted 9 lines
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+#ifdef PCH_CAN_PCLK_50MHZ + /* save clk cfg register */ + g_pch_phub_reg.clkcfg_reg = PCH_READ_REG(CLKCFG_REG_OFFSET); +#endifThis makes it hard to build one kernel for everything
We couldn't understand your intention.
Does the above mean we must not use "#ifdefPCH_CAN_PCLK_50MHZ" in source code ?I think what Alan means is that you will have to build two kernel images for two possible configurations of how your hardware is going to be used if you write code this way. One is the case when CAN clock runs at 50MHz and you will build a kernel image with
PCH_CAN_PCLK_50MHZdefined. The other is when CAN clock runs at other speed and you need to build another kernel image withPCH_CAN_PCLK_50MHZundefined. It would be much better if one kernel image could run on all configurations.Why is 50MHz so special, btw? Don't you need to save and restore the clock config register when CAN clock runs at other speed?
Quoted 17 lines
Quoted 16 lines
Review
Quoted 6 lines
(quoted diff) +3
-0+#define PCH_READ_REG(a) ioread32((pch_phub_base_address + a)) + +#define PCH_WRITE_REG(a, b) iowrite32(a, (pch_phub_base_address + b))These on the other hand do - but not where they are now
iowrite32((a), pcb_phub_base_address + (b))Quoted 8 lines
Quoted 1 line
(so that if a or b are expressions they are evaluated first)
Modify like below.
#define
PCH_READ_REG(a)ioread32(pch_phub_base_address + (a))#define
PCH_WRITE_REG(a, b)iowrite32(a, pch_phub_base_address + (b))Note that 'a' is supposed to be surrounded by brackets, too.
#define
PCH_WRITE_REG(a, b)iowrite32((a), pcb_phub_base_address + (b))Thanks
-Yong
Quoted 3 lines
Quoted 1 line
This makes it hard to build one kernel for everything
We couldn't understand your intention.
Does the above mean we must not use "#ifdefPCH_CAN_PCLK_50MHZ" in source code ?
The problem for people building kernels is this
- They want to have a single kernel for all the boxes of a single architecture
- They cannot do this if there are compile time settings that only work on some boards
Ideally this should be done automatically. If not then can it be a module parameter instead ?
Alan