Skip to contentSkip to conversation

xfstests 217: remove file in between mkfs's

PATCH In review Eric Sandeen 2 participants 2 messages Jun 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests 217: remove file in between mkfs's

217 requires a 2G scratch:

_require_fs_space $SCRATCH_MNT 2202000

but as we mkfs different sizes, we actually are filling in the sparse loopback more and more, and 3.8G isn't enough to contain it.

If we remove & recreate the file between mkfs's it doesn't take so much space ... I don't think it adds significantly to test time.

---

217 +3 -0
index 19540ad..ed86a51 100755
@@ -60,6 +60,9 @@ LOOP_MNT=$SCRATCH_MNT/test_fs_dir
 _do_mkfs()
 {
 	for i in $*; do
+		# make large holey file
+		rm -f $LOOP_DEV
+		$XFS_IO_PROG -f -c "truncate 16383g" $LOOP_DEV
 		echo -n "fssize=${i}g "
 		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
 			-d name=$LOOP_DEV,size=${i}g |grep log

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Eric Sandeen

217 requires a 2G scratch:

_require_fs_space $SCRATCH_MNT 2202000

but as we mkfs different sizes, we actually are filling in the sparse loopback more and more, and 3.8G isn't enough to contain it.

If we remove & recreate the file between mkfs's it doesn't take so much space ... I don't think it adds significantly to test time.

Looks good,

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs