Skip to contentSkip to conversation

ia64: Fix xc_save error reporting

PATCH New Michal Novotny 1 participant 1 message Jun 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64: Fix xc_save error reporting

Hi,
this is the patch for error reporting on ia64 that has a special handling in comparison with i386/x86_64 platforms. This is pretty straight-forward just to fail on "cannot map mfn page" message instead of continue since the memory is not being correctly mapped using the xc_map_foreign_range() function.

This patch has been originally done for RHEL-5 version of Xen, tested and working fine on RHEL-5 but when I had a look at Xen-unstable I saw that is *may* be the issue there as well. Unfortunately I'm not having any ia64 machine where I can install Xen-unstable so could somebody please test this patch on Xen-unstable ? Nevertheless, since the code is pretty similar for both RHEL-5 Xen and Xen-unstable it should work the same, i.e. it should be working but unfortunately I can't test it :(

Thanks a lot,
Michal

Signature · 2 lines
Michal Novotny<[email protected]>, RHCE
Virtualization Team (xen userspace), Red Hat
tools/libxc/ia64/xc_ia64_linux_save.c +1 -1
diff -r 0eeda0176d87 tools/libxc/ia64/xc_ia64_linux_save.c
@@ -647,7 +647,7 @@ xc_domain_save(xc_interface *xc_handle, 
                     fprintf(stderr, "cannot map mfn page %lx gpfn %lx: %s\n",
                             xc_ia64_p2m_mfn(&p2m_table, N),
                             N, safe_strerror(errno));
-                    continue;
+                    goto out;
                 }
 
                 if (write_exact(io_fd, &N, sizeof(N))) {

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel