dvb: remove obsolete lgdt3304 driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 dvb: remove obsolete lgdt3304 driver
Some time ago, Mauro wrote:
...
Quoted 13 lines
From the patch comments:
There's a currently-unused lgdt3304 demod driver, which leaves a lot to be desired as far as functionality. The 3304 is unsurprisingly quite similar to the 3305, and empirical testing yeilds far better results and more complete functionality by merging 3304 support into the 3305 driver. (For example, the current lgdt3304 driver lacks support for signal strength, snr, ucblocks, etc., which we get w/the lgdt3305).
For the moment, not dropping the lgdt3304 driver, and its still up to a given device's config setup to choose which demod driver to use, but I'd suggest dropping the 3304 driver entirely.
Quoted 5 lines
If lgdt3305 driver got superseded, just send me a patch dropping it.
Jarod/Michael,
Please send me a patch removing the legacy driver.
More complete support for the lgdt3304 atsc demodulator was added by way of the lgdt3305 driver. There's only one device supported in-tree that has an lgdt3304 (the kworld 340u/ub435-q em28xx stick), and its already using the lgdt3305-provided variant of lgdt3304 support.
--- drivers/media/dvb/frontends/Kconfig | 10 +- drivers/media/dvb/frontends/Makefile | 1 - drivers/media/dvb/frontends/lgdt3304.c | 380 -------------------------------- drivers/media/dvb/frontends/lgdt3304.h | 45 ---- 4 files changed, 1 insertions(+), 435 deletions(-) delete mode 100644 drivers/media/dvb/frontends/lgdt3304.c delete mode 100644 drivers/media/dvb/frontends/lgdt3304.h
drivers/media/dvb/frontends/Kconfig +1 -9
@@ -462,16 +462,8 @@ config DVB_LGDT330X An ATSC 8VSB and QAM64/256 tuner module. Say Y when you want to support this frontend. -config DVB_LGDT3304 - tristate "LG Electronics LGDT3304" - depends on DVB_CORE && I2C - default m if DVB_FE_CUSTOMISE - help - An ATSC 8VSB and QAM64/256 tuner module. Say Y when you want - to support this frontend. - config DVB_LGDT3305 - tristate "LG Electronics LGDT3305 based" + tristate "LG Electronics LGDT3304 and LGDT3305 based" depends on DVB_CORE && I2C default m if DVB_FE_CUSTOMISE help
drivers/media/dvb/frontends/Makefile +0 -1
@@ -46,7 +46,6 @@ obj-$(CONFIG_DVB_OR51132) += or51132.o obj-$(CONFIG_DVB_BCM3510) += bcm3510.o obj-$(CONFIG_DVB_S5H1420) += s5h1420.o obj-$(CONFIG_DVB_LGDT330X) += lgdt330x.o -obj-$(CONFIG_DVB_LGDT3304) += lgdt3304.o obj-$(CONFIG_DVB_LGDT3305) += lgdt3305.o obj-$(CONFIG_DVB_CX24123) += cx24123.o obj-$(CONFIG_DVB_LNBP21) += lnbp21.o
drivers/media/dvb/frontends/lgdt3304.c deleted +0 -380
380 lines not on this page · raw message
drivers/media/dvb/frontends/lgdt3304.h deleted +0 -45
45 lines not on this page · raw message
Signature · 6 lines
1.7.1 -- Jarod Wilson [email protected]