Skip to contentSkip to conversation

Fix endtime issue

PATCH Doug Nazar 2 participants 2 messages Jul 1, 2010 – Jul 19, 2010

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

Doug Nazar

author
#0 lore raw

After finally tracking down an issue with rpc.gssd crashing which had
been bugging me on and off for months, ran into another issue.

Commit 4c5ff6d4 removed the setting of endtime for a few contexts by accident.

Now to figure out why I get stale handles on submounts.

Doug

commit 3e4355dd4a31ee8577620b8b93cd5a811cdcaa7c

Author: Doug Nazar <[email protected]>
Date:   Wed Jun 30 15:49:39 2010 -0400

Return correct context endtime for lucid rfc4121 and mit.

utils/gssd/context_lucid.c +2 -0
index b87bf76..2108487 100644
@@ -202,6 +202,8 @@ prepare_krb5_rfc4121_buffer(gss_krb5_lucid_context_v1_t *lctx,
 
 	if (WRITE_BYTES(&p, end, v2_flags)) goto out_err;
 	if (WRITE_BYTES(&p, end, lctx->endtime)) goto out_err;
+	if (endtime)
+		*endtime = lctx->endtime;
 	if (WRITE_BYTES(&p, end, lctx->send_seq)) goto out_err;
 
 	/* Protocol 0 here implies DES3 or RC4 */
utils/gssd/context_mit.c +2 -0
index f9cbb02..e6db9cb 100644
@@ -191,6 +191,8 @@ serialize_krb5_ctx(gss_ctx_id_t ctx, gss_buffer_desc *buf, int32_t *endtime)
 		if (WRITE_BYTES(&p, end, kctx->signalg)) goto out_err;
 		if (WRITE_BYTES(&p, end, kctx->sealalg)) goto out_err;
 		if (WRITE_BYTES(&p, end, kctx->endtime)) goto out_err;
+		if (endtime)
+			*endtime = kctx->endtime;
 		word_seq_send = kctx->seq_send;
 		if (WRITE_BYTES(&p, end, word_seq_send)) goto out_err;
 		if (write_oid(&p, end, kctx->mech_used)) goto out_err;
#1 lore raw
Quoted 7 lines · Doug Nazar

After finally tracking down an issue with rpc.gssd crashing which had
been bugging me on and off for months, ran into another issue.

Commit 4c5ff6d4 removed the setting of endtime for a few contexts by accident.

Now to figure out why I get stale handles on submounts.

Committed...

steved.