ASoC: SAMSUNG: Add Aquila sound driver
PATCH 1/1 ASoC: SAMSUNG: Add Aquila sound driver
This patch add sound support for the Aquila board based on S5PC110.
The Aquila board is based on Samsung SoC(S5PC110) and include WM8994 codec over I2Sv5 to support sound. As there is currently no driver for the I2Sv5, the code to use I2Sv5 is deleted on this patch.
After I2Sv5 driver is posted in a few weeks, I will post incremental patch which some codes for using I2Sv5. The owner of I2Sv5 said that he will post I2Sv5 driver after a few weeks.
The kind of jack is below states :
* SND_JACK_HEADPHONE
* SND_JACK_HEADSET
* SND_JACK_MECHANICAL
: When TV-OUT cable is inserted on Aquila board, the TV-OUT cable isn't connected to television.
* SND_JACK_AVOUT
: When TV-OUT cable is inserted on Aquila board, the TV-OUT cable is connected to television.
--- sound/soc/s3c24xx/Kconfig | 8 + sound/soc/s3c24xx/Makefile | 2 + sound/soc/s3c24xx/aquila_wm8994.c | 296 +++++++++++++++++++++++++++++++++++++ 3 files changed, 306 insertions(+), 0 deletions(-) create mode 100644 sound/soc/s3c24xx/aquila_wm8994.c
sound/soc/s3c24xx/Kconfig +8 -0
@@ -131,3 +131,11 @@ config SND_S3C64XX_SOC_SMARTQ depends on SND_S3C24XX_SOC && MACH_SMARTQ select SND_S3C64XX_SOC_I2S select SND_SOC_WM8750 + +config SND_S5PC110_SOC_AQUILA_WM8994 + tristate "SoC I2S Audio support for AQUILA - WM8994" + depends on SND_S3C24XX_SOC && MACH_AQUILA + select SND_SOC_WM8994 + help + Say Y if you want to add support for SoC audio on aquila + with the WM8994.
sound/soc/s3c24xx/Makefile +2 -0
@@ -30,6 +30,7 @@ snd-soc-s3c24xx-simtec-tlv320aic23-objs := s3c24xx_simtec_tlv320aic23.o snd-soc-smdk64xx-wm8580-objs := smdk64xx_wm8580.o snd-soc-smdk-wm9713-objs := smdk_wm9713.o snd-soc-s3c64xx-smartq-wm8987-objs := smartq_wm8987.o +snd-soc-aquila-wm8994-objs := aquila_wm8994.o obj-$(CONFIG_SND_S3C24XX_SOC_JIVE_WM8750) += snd-soc-jive-wm8750.o obj-$(CONFIG_SND_S3C24XX_SOC_NEO1973_WM8753) += snd-soc-neo1973-wm8753.o
@@ -43,3 +44,4 @@ obj-$(CONFIG_SND_S3C24XX_SOC_SIMTEC_TLV320AIC23) += snd-soc-s3c24xx-simtec-tlv32 obj-$(CONFIG_SND_S3C64XX_SOC_WM8580) += snd-soc-smdk64xx-wm8580.o obj-$(CONFIG_SND_SOC_SMDK_WM9713) += snd-soc-smdk-wm9713.o obj-$(CONFIG_SND_S3C64XX_SOC_SMARTQ) += snd-soc-s3c64xx-smartq-wm8987.o +obj-$(CONFIG_SND_S5PC110_SOC_AQUILA_WM8994) += snd-soc-aquila-wm8994.o
sound/soc/s3c24xx/aquila_wm8994.c new file +296 -0
296 lines not on this page · raw message
Signature · 1 line
1.6.3.3
Review
Quoted 2 lines · 최찬우
(quoted diff) +2
-0+static const struct snd_kcontrol_new aquila_controls[] = { +};
This should be removed until there are controls to go in it.
sound/soc/s3c24xx/aquila_wm8994.c line 96
Quoted 4 lines
sound/soc/s3c24xx/aquila_wm8994.c new file +4
-0+static int aquila_wm8994_init (struct snd_soc_codec *codec) +{ +int ret; +unsigned int reg;
It'd probably be useful to list any unconnected pins here (if there are any) using snd_soc_nc_pin().
Otherwise this all looks very good - you should probably also include a signoff from Mr. Shim, I guess.
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 7 lines · Mark Brown
Review
Quoted 2 lines · 최찬우
(quoted diff) +2
-0+static const struct snd_kcontrol_new aquila_controls[] = { +};This should be removed until there are controls to go in it.
Ok, I will do.
Quoted 8 lines
sound/soc/s3c24xx/aquila_wm8994.c line 96
Quoted 4 lines
sound/soc/s3c24xx/aquila_wm8994.c new file +4
-0+static int aquila_wm8994_init (struct snd_soc_codec *codec) +{ +int ret; +unsigned int reg;It'd probably be useful to list any unconnected pins here (if there are any) using
snd_soc_nc_pin().
I add unconnected pins using snd_soc_nc_pin().
Quoted 2 lines
Otherwise this all looks very good - you should probably also include a signoff from Mr. Shim, I guess.
I will include Mr. Shim to signoff.
Thank you for your comment.
Chanwoo Choi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel