Skip to contentSkip to conversation

Usage of bi_env ?

U-Boot Dirk Behme 2 participants 3 messages Jul 7, 2010 – Jul 27, 2010

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives:

...
env_t = 0x00000000
...

The code in common/cmd_bdinfo.c for this is

bd_t *bd = gd->bd;
...
print_num ("env_t", (ulong)bd->bi_env);

While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here?

Best regards

Dirk

[1] grep for bi_env in 2010.03:

./include/asm-i386/u-boot.h:54: struct environment_s *bi_env;
./include/asm-i386/u-boot.h:62:#define bi_env_data bi_env->data ./include/asm-i386/u-boot.h:63:#define bi_env_crc bi_env->crc
./include/asm-arm/u-boot.h:42: struct environment_s *bi_env;
./include/asm-arm/u-boot.h:52:#define bi_env_data bi_env->data ./include/asm-arm/u-boot.h:53:#define bi_env_crc bi_env->crc ./include/asm-mips/u-boot.h:45:#define bi_env_data bi_env->data ./include/asm-mips/u-boot.h:46:#define bi_env_crc bi_env->crc
./include/asm-avr32/u-boot.h:29: struct environment_s *bi_env;
./common/cmd_bdinfo.c:328: print_num ("env_t", (ulong)bd->bi_env);

#1 lore raw

Dear Dirk Behme,

Quoted 8 lines · In message <[email protected]> you wrote:

With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives:

...
env_t = 0x00000000
...

The code in common/cmd_bdinfo.c for this is

Quoted 8 lines

bd_t *bd = gd->bd;
...
print_num ("env_t", (ulong)bd->bi_env);

While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here?

You missed sending a patch that cleans this up :-)

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The trouble with our times is that the future is not what it used  to
be.                                                     - Paul Valery
author
#2 lore raw
Quoted 15 lines · Wolfgang Denk

Dear Dirk Behme,

Quoted 12 lines · In message<[email protected]> you wrote:

With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives:

...
env_t = 0x00000000
...

The code in common/cmd_bdinfo.c for this is

bd_t *bd = gd->bd;
...
print_num ("env_t", (ulong)bd->bi_env);

Quoted 6 lines
Quoted 4 lines

While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here?

You missed sending a patch that cleans this up :-)

Fixed some minutes ago ;)

Best regards

Dirk